From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E23FEA09E9; Mon, 14 Dec 2020 18:44:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5081429AC; Mon, 14 Dec 2020 18:44:36 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 273EA137D for ; Mon, 14 Dec 2020 18:44:33 +0100 (CET) IronPort-SDR: Y1IxwKaw30oY5Bx5YC7LwsleQCQu65YQPDFFcVx6uq6KsQPdIcrQWIrg1KTze5cSt4CQJp12+v 522u7F7wY+IA== X-IronPort-AV: E=McAfee;i="6000,8403,9834"; a="172181628" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="172181628" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 09:44:32 -0800 IronPort-SDR: KEfQStX7QaXJQ7cff3MCcSAATeCkInAslmz2Ui/J6fwTcPj0jJmof3+uPq3ELTH62U57Ew/Rdl TTajQz1vQu9w== X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="411348079" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.201.64]) ([10.213.201.64]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 09:44:21 -0800 To: Steve Yang , dev@dpdk.org Cc: hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, jia.guo@intel.com, haiyue.wang@intel.com, xavier.huwei@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, rosen.xu@intel.com, hkalra@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, kirankumark@marvell.com, rmody@marvell.com, shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com, wei.dai@intel.com, fengchunsong@huawei.com, lihuisong@huawei.com, chenhao164@huawei.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, yanglong.wu@intel.com, xiaolong.ye@intel.com, ting.xu@intel.com, xiaoyun.li@intel.com, wenzhuo.lu@intel.com, andy.pei@intel.com, dan.wei@intel.com, skori@marvell.com, vattunuru@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, zyta.szpak@semihalf.com, slawomir.rosek@semihalf.com, rad@semihalf.com, Jeff Guo , Haiyue Wang , Rahul Lakkireddy , Somalapuram Amaranath , Gagandeep Singh , Sachin Saxena , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Hemant Agrawal , Sachin Saxena , Heinrich Kuhn , Shijith Thotton , Srisivasubramanian Srinivasan References: <20201209031628.29572-1-stevex.yang@intel.com> From: Ferruh Yigit Message-ID: Date: Mon, 14 Dec 2020 17:44:17 +0000 MIME-Version: 1.0 In-Reply-To: <20201209031628.29572-1-stevex.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 00/12] fix rx packets dropped issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/9/2020 3:16 AM, Steve Yang wrote: > The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, this > fix will change the boundary condition with 'RTE_ETHER_MTU'. > > When the MTU(1500) set, the frame type of rx packet will be different > if used different overhead, it will cause the consistency issue, and the > normal packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU' > can avoid this issue. > > Following scopes will be changed: > - 'rte_ethdev' > - 'app', e.g.: 'test-pmd'; > - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e; > > Steve Yang (12): > net/dpaa2: fix the jumbo frame flag condition for mtu set > net/e1000: fix the jumbo frame flag condition for mtu set > net/hns3: fix the jumbo frame flag condition for mtu set > net/i40e: fix the jumbo frame flag condition > net/iavf: fix the jumbo frame flag condition > net/ice: fix the jumbo frame flag condition > net/ipn3ke: fix the jumbo frame flag condition for mtu set > net/octeontx: fix the jumbo frame flag condition for mtu set > net/octeontx2: fix the jumbo frame flag condition for mtu > net/qede: fix the jumbo frame flag condition for mtu set > net/sfc: fix the jumbo frame flag condition for mtu set > net/thunderx: fix the jumbo frame flag condition for mtu set > Overall looks good to me, there is no review from the individual drivers, but if there is no objection I am for merging it soon. A few things below: 1) I see following usage not updated, can you please include them in next version: ixgbe_set_vf_lpe ixgbe_dev_mtu_set cxgbe_dev_mtu_set cxgbe_dev_rx_queue_setup axgb_mtu_set enetc_mtu_set hinic_dev_set_mtu dpaa_mtu_set nfp_net_dev_mtu_set lio_dev_mtu_set 2) I guess 'eth_dev' update will come as separate patch, can you please send it without waiting this set to be merged, since both are related having them both can help discussions. Thanks, ferruh