From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CBD87DE0 for ; Thu, 31 Aug 2017 11:13:28 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Aug 2017 02:13:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,451,1498546800"; d="scan'208";a="144026040" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga005.jf.intel.com with ESMTP; 31 Aug 2017 02:13:25 -0700 To: Alejandro Lucero Cc: dev References: <1503591622-16232-1-git-send-email-alejandro.lucero@netronome.com> <1503591622-16232-4-git-send-email-alejandro.lucero@netronome.com> <76562c52-4870-4c08-64b1-41ef1e932093@intel.com> From: Ferruh Yigit Message-ID: Date: Thu, 31 Aug 2017 10:13:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 03/16] nfp: add support for new pci id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 09:13:29 -0000 On 8/31/2017 10:08 AM, Alejandro Lucero wrote: > > > On Mon, Aug 28, 2017 at 5:43 PM, Ferruh Yigit > wrote: > > On 8/24/2017 5:20 PM, Alejandro Lucero wrote: > > A NFP PF PCI devices can have PCI ID 4000 or 6000. > > > > Signed-off-by: Alejandro Lucero > > > <...> > > > @@ -2682,6 +2682,10 @@ static int nfp_pf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > >  static const struct rte_pci_id pci_id_nfp_pf_net_map[] = { > >       { > >               RTE_PCI_DEVICE(PCI_VENDOR_ID_NETRONOME, > > +                            PCI_DEVICE_ID_NFP4000_PF_NIC) > > I have seen nfp documentation updated with this new device, and I > believe it also worth updating release notes to mention new device > support (doc/guides/rel_notes/release_17_11.rst) > > > Yes, I agree. I should add this as well. >   > > Also supported nics web page (http://dpdk.org/doc/nics), needs updating > (http://dpdk.org/browse/tools/dpdk-web/ > ) > > > Not sure about this one. I could not find any file in the repo for > changing this. How should I manage it? Please check [1], currently it lists NFP-6xxx only. [1] http://dpdk.org/browse/tools/dpdk-web/tree/doc/nics.html#n93 >   > > > +     }, > > +     { > > +             RTE_PCI_DEVICE(PCI_VENDOR_ID_NETRONOME, > >                              PCI_DEVICE_ID_NFP6000_PF_NIC) > <...> > >