From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jesna K E <jesna.k.e@amd.com>, dev@dpdk.org
Cc: Selwin.Sebastian@amd.com
Subject: Re: [PATCH v1 1/2] net/axgbe: add multi-process support
Date: Fri, 23 Dec 2022 10:47:02 +0000 [thread overview]
Message-ID: <c2956e13-2338-0cd8-9b72-0034862ea592@amd.com> (raw)
In-Reply-To: <5e98e934-c955-6df8-4908-da9926cab407@amd.com>
On 12/23/2022 10:44 AM, Ferruh Yigit wrote:
> On 12/21/2022 2:52 AM, Jesna K E wrote:
>> +/* Takes ethdev as parameter
>> + * Used in dev_start by primary process and then
>> + * in dev_init by secondary process when attaching to an existing ethdev.
>> + */
>> +void
>> +axgbe_set_tx_function(struct rte_eth_dev *dev)
>> +{
>> + struct axgbe_port *pdata = dev->data->dev_private;
>> + struct axgbe_tx_queue *txq = dev->data->tx_queues[0];
>> +
>> + if (pdata->multi_segs_tx)
>> + dev->tx_pkt_burst = &axgbe_xmit_pkts_seg;
>> +#ifdef RTE_ARCH_X86
>> + if (!txq->vector_disable &&
>> + rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
>> + dev->tx_pkt_burst = &axgbe_xmit_pkts_vec;
>> +#else
>> + dev->tx_pkt_burst = &axgbe_xmit_pkts;
btw, indentation of this line looks wrong
>> +#endif
>> +}
>
> 'txq' is used only for 'RTE_ARCH_X86', that is why it gives "unused
> variable" warning for it.
> Can you please declare 'txq' within 'RTE_ARCH_X86' macro?
next prev parent reply other threads:[~2022-12-23 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 2:52 Jesna K E
2022-12-21 2:52 ` [PATCH v1 2/2] net/axgbe: move offloads to Rx/Tx queue setup Jesna K E
2022-12-21 16:27 ` Ferruh Yigit
2022-12-21 15:37 ` [PATCH v1 1/2] net/axgbe: add multi-process support Ferruh Yigit
2022-12-23 10:44 ` Ferruh Yigit
2022-12-23 10:47 ` Ferruh Yigit [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-04 7:42 Jesna K E
2022-12-21 2:35 Jesna K E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2956e13-2338-0cd8-9b72-0034862ea592@amd.com \
--to=ferruh.yigit@amd.com \
--cc=Selwin.Sebastian@amd.com \
--cc=dev@dpdk.org \
--cc=jesna.k.e@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).