From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC499A0093; Fri, 23 Dec 2022 11:47:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DD4040A7F; Fri, 23 Dec 2022 11:47:10 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2074.outbound.protection.outlook.com [40.107.96.74]) by mails.dpdk.org (Postfix) with ESMTP id CC0A140698 for ; Fri, 23 Dec 2022 11:47:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EK4P2zLodPE9SLh0HOD8Vgor+HhEqeYkHUSrTkd+E7cr+pze+hqi6h+Ngnck8NurDexd0Olirat/AATKeE+9CNIHivppYjbS3hxpB+gVQETmUO1cCZrOAK8h+F/iOQBipl7BIyS0Hv+pjIxet0/CDEdvHMqlIUQD6Pnyvdehx/fvXFtX/Ih3chKn1BZ8fA/kao4q4WQlHLrlTm+5607nYDcSthwBI30OqtYd2vu8Dsl8t632hEpH6LlymsHcNt9C9FpYpkhTjB4je9+gh+Ak0O6ok658SZehqDC63nARq+9i2j4adE/hMOgF3wKybqTi94Sci4Usn9xzJYU9cnvQcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EmkbmEtwbvmmzAj03UVhg0IJErwdpIkcmvXeuYM9AS8=; b=DCmZQagJkxLlJBXJAq4OFwXwicUyCdB+r5eA8/VWYtkXjZQg8srAtLWeDjjd4gTUvPEggsed2kLZcbbD8BMvwoXq07vYrVqy/LrgqrshK11A/6ihj5RLvl99Jqw+2Dc5mnnNKzXOP+c2/TZtTumuSc4IQTLrvfSgpOtbUjD0z3DmyT/A0Rj7ny8cAqQ5+GSC+p0pMEQfo5nSc3fsnaG5i32XfSuO/oUyh8njYf6hNFN4H+UEZbBEA+yxsg3tXAVyCwy0JwZNx9SaINBMy0f+5j/Cesnpva1pSnYdCzeWMmDGMqrW7C68PNyBnq/Z9Oh0NBdWgChJ7f8lmSgDi21/XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EmkbmEtwbvmmzAj03UVhg0IJErwdpIkcmvXeuYM9AS8=; b=crpx1JkqF9gU7ciooCCr3dQPdAxxnFhzxR5wh23r+JSY0N4qyN/nJLPHp6kRSPp7Skvos++0LO3zTBvd3PhM1tr6tdP9k3fcqbA3w43OTmfrdMxiPKSVU4qSDe2oUvo27FVs8AteRoVArV16fwBeV/jNKJcP23VQXW9lQDkUI0A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5269.namprd12.prod.outlook.com (2603:10b6:208:30b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.12; Fri, 23 Dec 2022 10:47:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.5924.016; Fri, 23 Dec 2022 10:47:07 +0000 Message-ID: Date: Fri, 23 Dec 2022 10:47:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v1 1/2] net/axgbe: add multi-process support Content-Language: en-US From: Ferruh Yigit To: Jesna K E , dev@dpdk.org Cc: Selwin.Sebastian@amd.com References: <20221221025202.31733-1-jesna.k.e@amd.com> <5e98e934-c955-6df8-4908-da9926cab407@amd.com> In-Reply-To: <5e98e934-c955-6df8-4908-da9926cab407@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0501.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5269:EE_ X-MS-Office365-Filtering-Correlation-Id: 58c581c0-c43d-4b91-be9e-08dae4d30966 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uzafOpFzRz00fohR9Y+JAF0cfX3ArbqYZ2oshvpxEu20D/5tylEXVFOYtuoULfD7u+mYht3KjyDX26Q3sBdeeko5eNlWtso4iQ8/EXgwdKgB5IVZo0z2vm3zZCaYVM/PS9T4myJZOMU4TztNSzUzE8BF/MB0kZ5Ns+AWsnH7gwx7c6kjtwoKtKIINd+U3uBJgN3tTAc2www6vwtQF1iOh8fIT6z+p27K0mPiBzeNgy58iZWRrjMUm3tkDC7nnD97+kk/BrhQGtmHXWtgAlxBfhGcUGC1f2CF1yRee7Tcb4kwsTBZZk8uLEkDNTihQlNu85j56WPbYKdBzULgf0IHnB/vvdB9/3F8HbP91qwCqGCYUcXRTBDVNhS1bH+6rJRysffv0HzaV2k8I7kbd95L889iDgW56ta7XYfAsEeuML4l+3p5iEnItrgKYc7oOQQjVNTeWQ+lAj27aOaqTaM6NSGaJD/71gkOnaZ1YSZ75HlEN7SY0rkMSNUtXRXuGPBcYT/4G2e+YaiswkONtAMm5icEjBoc5QT7WCTmqIw72sMWQLSHNy9PdM88mj9JT7Jw8TON9ySUuRcgn6ww7d+qtIUmKodrXzo74Sl9qSPAz/TBXOpnaqfCspiIj70OtlRpKptkJnMAJnNwch64h0REOI1HzeK+Ie41NVdSH2PWGRChzH2FenY0aGIHWISB/kFjYUslqNT1X1F1k1vlibxzfDF39U5EOmQJgxXAnto8otg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(396003)(346002)(136003)(366004)(451199015)(53546011)(36756003)(478600001)(6486002)(26005)(38100700002)(2906002)(316002)(6512007)(186003)(6506007)(31686004)(6666004)(8936002)(86362001)(31696002)(41300700001)(66946007)(66556008)(66476007)(2616005)(8676002)(44832011)(5660300002)(83380400001)(4326008)(4744005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGRWTVRvZW02ZmI3WWRLNVNIU0xKNEVtMG1iVTRwNkdHU3NFZVNaYUZ3Rkh3?= =?utf-8?B?eWFvcElTWkZTQnFmMWdkdlhDMXNkbTRUTWhJcGZWNTd5ZGowSHZEOGFLNmNa?= =?utf-8?B?RUZSYnlYeXl1a2tRZ2tFZjNpSDBnaFRxYm0vU1B1ZFNQR0tNcXZWa2dTVXd2?= =?utf-8?B?eUMvbHFJUHlnNytIZjZHSVQ1dXlmQUtxYi95TjdYM05wMkhpbTEzalp2R1BX?= =?utf-8?B?SmRUbXRQRCtDYkJyVGRwSlZqOTVYRzlvV3UrMnFZSXQrNjQreC95NUd2Tks3?= =?utf-8?B?Z24yV2xTbCtTWXltVFdQZnl6TkRRMGpUSWlTclRiK3lrZWZDYVlBUUVyclp1?= =?utf-8?B?eGJPekFJQXNqd0Jmc1cxN3h2aStiUHVsRXlGVVNBbm82MmQ2Q1ZEQUU1Z0Zp?= =?utf-8?B?c2xJbEo4SDJPbVh6YjQ4bkpUdUxpaFgyVTY3d0VUZ3E3MVlpQXdETFJSaDZo?= =?utf-8?B?eU9FZzBCU2tZWkZsNE5FYndoc0RQUUJ3UTV2Wml5VEpqWDlKZnNlTG1vWmdM?= =?utf-8?B?OE5aUkxWcjJlQlFpbWNzbWVTMGUwUDM3dXBUY3VEbjVubjNORmdpbFgwYnNQ?= =?utf-8?B?UWtxRDNVeXBxZDVNV2psNHRQNU1PTzR1ZWcwcEIyUjZObG1hL3hiZENFOFA1?= =?utf-8?B?MlZWZkNMbW54YmFXUWFtZGJrMzhoV2dqdjlRKzJDejUwaTFYbXZPRGo0bUo5?= =?utf-8?B?N05HbmlwSjZTM0Z2UTJBWXQ4d3BsM3lvYXdyVmxFSXBhZEVKQVlsRmwwaTFt?= =?utf-8?B?cUE4ajlZYkNUODEyZkhFTDlrUVk4V0RiWm9kU1pwZzVhOURVKzBqaml0TCsy?= =?utf-8?B?RUlOWGxSWS9iVDdQcWMyaHdhbFFocTFsZ0hicFVCK0dEbVFJdVFWaGprbk00?= =?utf-8?B?VkM5aEVQUmg4aU1WN2lTbjRyNncrK2dwa3BkT0JKNkMxSWdGTXFaaXVOZnJy?= =?utf-8?B?L21NTTR1algwZG9MZG81VmdCSnRoQmpObFNzMDNaNkw4TFpyeG9JMm1ab2Fj?= =?utf-8?B?Sjk5Z0x4TXRtVXZtckt3VFVKWjh2Wk1PcHMyeFJwWk9ObURnYXpnYVVTVHVw?= =?utf-8?B?TWw0d3BnR0xlUTFTeHo2ZFNOeTZ4S05hMm9adXYyMGRJa3NZMEVnUUI0UDlm?= =?utf-8?B?YlFJTHBCc0NmY2ovQkRXK1oxNEhvbUY1dmxadE4rM2VHNXpWWno5Rko1SGRC?= =?utf-8?B?SEUrTWZsUWRkUXdIMER0anZZTjExdW0zN2N5d1l4OTZQYXJkbzUybGs5anNt?= =?utf-8?B?dGV1RHVER1B5a0VnOEkvSDRndEJyYTMzQVNwZU82a3RPSjdpbGtyalpwUFUz?= =?utf-8?B?dEJzbEx0VFJFMFJUWGJCMnEvcjA5bEd1clBuTHBmUDNjZkJua0RnaWxrSnJD?= =?utf-8?B?NTM3cHdNMTNyd21wTDNUNkZOaFRERG8yQnBGTVhPK1pUaUREZ0xFTVl0Wk44?= =?utf-8?B?QTBLQVNjMURwbnluOVZueTZRMHhoZ2lDd1JuRWlPWW9aQkZ3dlRwUndnWjVJ?= =?utf-8?B?b3cyelBkMWROSnlWb092OGJqYVpkMkRHSVRNeldIelo4OVJ3WDF6TU9icFhs?= =?utf-8?B?bDZaRXcrUHdONU9JbXVyRjQ4VDFialY0MkVRR1F6eXE5YmVsclNEaEdlcWVC?= =?utf-8?B?d0JvdU9LMXZVekhQSC92UVhScm5ocVhySGt1aFYrZk9SVGFvRUxGM0JwUjlF?= =?utf-8?B?ZTBEMmhlc0FMZmUyVi9DVzZwQStCNjdJQjl1bGp4K2JKMkFCQ3JtS3loMjg4?= =?utf-8?B?QjJmUWEzWHUyVHhPcHFHcXlDNWNGckcwc05kOU0rRjVMN0hjTitJUWdoRXo0?= =?utf-8?B?bm1oVGRpZkVIVEhtRUNEREIrQ0FaMGIzRGR3eE43aGRsaE5PV2ppdThwN2ZK?= =?utf-8?B?dWs3V3NFZFFzWTFCRWhCMElpSmhIK3g4Y3ZrTHNYSExHb3V0djJBakZrT3dn?= =?utf-8?B?bCsxQ0pITGh1M2VKOW9MNzNLNG9pYTZha1RLYW9lS04ybTZtRVlKVlZzakNN?= =?utf-8?B?dVVjVWhZOStESEhPOUl6WXRiUW5QaitNeStDWFVqQjRpdFVRMCtWUkcydVBK?= =?utf-8?B?Q05wZ00vNTBXQ1ZMYXJyQ3JZSVhmNllyM0tOOUFad2QzcWMyQS9XMXVxVzBz?= =?utf-8?Q?50SvXvcm2gYH9qi6lr845oe8M?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58c581c0-c43d-4b91-be9e-08dae4d30966 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2022 10:47:07.5338 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1dFSd/5MgawIc7h/z3Vck/qq4maeIVuXtbYfWzOlWAvdWQY9uRcc2SIjD1b9tiSP X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5269 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/23/2022 10:44 AM, Ferruh Yigit wrote: > On 12/21/2022 2:52 AM, Jesna K E wrote: >> +/* Takes ethdev as parameter >> + * Used in dev_start by primary process and then >> + * in dev_init by secondary process when attaching to an existing ethdev. >> + */ >> +void >> +axgbe_set_tx_function(struct rte_eth_dev *dev) >> +{ >> + struct axgbe_port *pdata = dev->data->dev_private; >> + struct axgbe_tx_queue *txq = dev->data->tx_queues[0]; >> + >> + if (pdata->multi_segs_tx) >> + dev->tx_pkt_burst = &axgbe_xmit_pkts_seg; >> +#ifdef RTE_ARCH_X86 >> + if (!txq->vector_disable && >> + rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) >> + dev->tx_pkt_burst = &axgbe_xmit_pkts_vec; >> +#else >> + dev->tx_pkt_burst = &axgbe_xmit_pkts; btw, indentation of this line looks wrong >> +#endif >> +} > > 'txq' is used only for 'RTE_ARCH_X86', that is why it gives "unused > variable" warning for it. > Can you please declare 'txq' within 'RTE_ARCH_X86' macro?