From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E4F945D30; Mon, 18 Nov 2024 08:04:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D3DF40DDE; Mon, 18 Nov 2024 08:04:20 +0100 (CET) Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013042.outbound.protection.outlook.com [52.101.67.42]) by mails.dpdk.org (Postfix) with ESMTP id D620F4066D; Mon, 18 Nov 2024 08:04:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GqpbHBfUWRFcd6JjoTsFEjePWnyDWMsA3nsqQ6exEEFZNqIhiphMqHrr2qxDCfHV0pG6OA8DNHgQ5BkApUFuiNMOaEjk4wFE7QhMFW6r8FP7htJJLpv+czaLuwRuVbwzdXIiJUSgO2LBuJyBJa70ieGAXI+wjNubE8t7kkgEcn0VJR/007dx304YJFHVvv/mdvJQ0S6bpxLS7hRFjkMLSHw5SSJAx93Ytr/emHOARhDCavMErt9yX2YHIwlwt+SZHiXAFeNuQ/0ZSkQ/sqjlsyaAHz9TmlTa9rRJyDEuh4V6v2B2KpPtlD++cQAgR7SVPJJpAYf1wpqM4TkdwYvYWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xP45dTR/Rj4o95/rgJnzslKjT9EjuqvhvTObveJF1qg=; b=b35B+AwodoykGa8xVM6bseokb6taAALtyTGXO4F90CYfD3bK0bCkwS7uQnFUlq7bnGeBESrs6KSUoVLBrcKnPCl1xaYHhnyiMl3nR0GhKgmpOQYkew8FULudCBhJBr4CfR3Wn/P/gaHQlPIc/3a03qT/47uwZZTxBinNO7+vy8/O6N2YP9CKmH4OfhD3k/425rQHOovArFZmDGoWJzAIAkmva0ugDyvV0yJszStOX0tUQNM38hKSg/ElzTdmEw7aPCL3Lej9VkgC7GU5Ur98bUNrtpaiOaDvT489RfHF9UyI5pEPOzjLiQlHCR3YpKfZ+qqYwAUOujKj9GuQeVnKsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xP45dTR/Rj4o95/rgJnzslKjT9EjuqvhvTObveJF1qg=; b=T1gfg2rlp7HFL+f/RRTTgwT080bsVLgTLGfJLTkx+TScotKo+qmdSLWJHOQ0fsGXBJBE0VemsMFreVTIZafl1VITuVzmaV/Lqx2bqnkAYhjJQnewbOpyEFM3T4eLeqsEFn68g1WgZxzdgRAIJSnB/c6DpZfKw6H4GhxdD+uxnkIGdg3oOradIZsRPHj9cVtZ+lshHBIq/+4b30REYIN8xwnRW9gZQh3PmR6Hv9MOaXDbSwcf7F5N7h7ELPKGkJ/EH1xomyVlKmTvCZxPx6gXHMpOZS3maQqwErIGOU+GBNdrbQzhjtCWfOnvqsq8H7pLMLPjcKQdOrTBVsUmtLWz8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AS4PR04MB9690.eurprd04.prod.outlook.com (2603:10a6:20b:4fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.22; Mon, 18 Nov 2024 07:04:17 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%5]) with mapi id 15.20.8158.019; Mon, 18 Nov 2024 07:04:17 +0000 Message-ID: Date: Mon, 18 Nov 2024 12:34:10 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 14/16] event/dpaa: fix bitmask truncation Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org Cc: sunil.kori@nxp.com, stable@dpdk.org, Hemant Agrawal , Sachin Saxena , skori@marvell.com References: <20241115060738.313190-1-stephen@networkplumber.org> <20241115060738.313190-15-stephen@networkplumber.org> From: Hemant Agrawal In-Reply-To: <20241115060738.313190-15-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0183.apcprd06.prod.outlook.com (2603:1096:4:1::15) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|AS4PR04MB9690:EE_ X-MS-Office365-Filtering-Correlation-Id: d7a7b104-f118-49da-c2e8-08dd079f37b3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y1pwSFBqcjNyaUZjMU5pUDRMNVpQU1pjYU9WMlk5TjI2cHJBTjZYYllFakVY?= =?utf-8?B?bWJ3QjZTOUx3NXFBZkpYUklxL1VDRjdHbGJSM2ZudW9PQ0QzUGU3TExpVHFz?= =?utf-8?B?Rzk3M3h5WkRqVURrWjA0YldWTzltUjNETCs0c2FvRmE5ODFaUFJFZGYyaGxa?= =?utf-8?B?cGErVTZFOWZQKzYvdFBwZHhBMkNwNTlHdzNvaGtuSnhvZXBiUWxrc0lORGp0?= =?utf-8?B?c1FNaUVPd1IyUG5zY2x0RGRibnBtNkpBSGt5a2xaWWxCUU10QzZDdGwxMzk3?= =?utf-8?B?TFRFbXdicUM5RTVJUDRaQU8yWlBOMW90N1NjYksrSEMrU2RPd3llN0R1RjFJ?= =?utf-8?B?RW9CMTRoSi9wSWNWRVB6YTBjejhNUG9GaGQ0RjdkWldha0pyMnZHV3VmMmpo?= =?utf-8?B?UHJ0OXNvcGI5OHVJTHpTaGVFZjVrK3pZWWl0aEVhVGE3Z3VlampueTh4YWhp?= =?utf-8?B?VXYzNnBsQ0tVRFp6VUhsdE1GNVNkS3ZQeUowdnAzNjBtdGNwcjdlVjlNZjBM?= =?utf-8?B?eG9QTk5EbDNEWFk1ZkdzWHVKbWRNVUlvSGJWWERwTnRGekhZek96YXhWZ3ls?= =?utf-8?B?bWFSZ3kyU0xYaGlNSE9uYWY3Y254d0IyTElCb1YydVF2LzY3dFRHTW9HbUc3?= =?utf-8?B?dFFuakx2UVR3NmU5Z0JYMVhqSGNNTTRVU1kxVGlpVURGV2hRREphTFAvUTdo?= =?utf-8?B?OU8vRWJWaDk5b1BmTlZ2eGZGbnk5R2M4dVduMEY4WDBHNU13NUJzZkxXUVAr?= =?utf-8?B?Wk1NQ1ZRc3F0N0g3VWVhdG9sbXIyRkI2bXpGMElZZExBQ0paRkg0T1FEckVE?= =?utf-8?B?dU1wUjRSWG93YnZXdVV3YmRnUVFKSGluZFBka1dqZjZnUDdqNHdKVHVXWm1L?= =?utf-8?B?RDZoVXUvT1FwV0pkYmZUTW1pYkwwMFpxVzlKZ0daSHhUb2JFdG5pNnNuU2hr?= =?utf-8?B?WjZQUEcxbHQvRmgwcmY0UmErbGhrb1NZczhCN2NZa05kbkJLeWQzOWIwU29H?= =?utf-8?B?VG80RGlOcFdJVGFOMzZhcnByYlpnR0RhTE5HL2FMV0tHckFMQ24rbndjOTh6?= =?utf-8?B?V1NUV3ROWFkzQmRpNGt4WWZ3REdlTXB6b2Nia1V5R2x4YTI5b2IwNkxhMnFu?= =?utf-8?B?UDl1K284WTladGZhcHR4MWdNMTdpY2kwelJlZDlvWFVEOUpqOTF1dzRBU1Y1?= =?utf-8?B?VVBZckQ2K2NZUmdDajNQTVNwOFYwZ0wxNndlWk1xcUYxaUl3YnpEYzc3eC92?= =?utf-8?B?ZUo2cXFocnJDT2gvTGZJVk5HOTgzUFRTZGt6YkU3SEVkSDcyTHlVaCtUb1Bt?= =?utf-8?B?VUptZFhBbkhhL2E1Qi9wdzh6ZDlsazlCUEZZOG9ncDlCbW5TSzRhWXpIcGRy?= =?utf-8?B?M1J1bWFOZWJuL3VDRmZTRko3YUhnOTBuQjdGcjhNaDlMN29wMTBsUzlMbFI0?= =?utf-8?B?am1USTFuNWR3S2pqM0E1WUFDZ0VDa3VyV3BoV1A2MTlmNXpNUkhiQWpMZ3Ni?= =?utf-8?B?dUxuYlBFYXcvNVhQK3EwdSt1NVdNaEUvS2wvRDdVbTRjTjI4b2QyN0J3d29j?= =?utf-8?B?QlpuOFRvM1JlRkJrbkFaaFBDdmZJcExvbUpGbCtpaFFEaHFiS0NiZXdZQ3RB?= =?utf-8?B?bG04Tll5WHhxZlVaRXkzUU54YVl3c2x2YWZpU0podjg3YmRiM1diUGFNQkVV?= =?utf-8?B?NS9KaGJkY3JqbWZZYm9YWEVxRE0wM2dCWG9HOXdDSnVUUmtlVWxkWStCellz?= =?utf-8?Q?hRiCOPMSfy0ischwD7AEYTfz9oGmeUkmY4Mn4Gn?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1IxdnNBaFB5Q25rNWExaGtCOWt2ODl1V01JK1RkR3JsdzBTY2M3d25tb2pR?= =?utf-8?B?WTlQNmd5WEY1TWYyS0UySlp4eWZML255Y1NYYURsUWNwT2lSM0Q0c2lXR092?= =?utf-8?B?UHNmdXJHczc4emxYMDBMajN6a3JMcmRRTkdWRDFlemdQT2gvamJ1amdXVUZx?= =?utf-8?B?QnNlYnJLdFRYTkVPSFUzQ3ZkMmJkQW56TnVaaU4zV3B2MDZsSFJvZ1dTRG5T?= =?utf-8?B?TXM4REd1T1RQSDJwbExCV0g2cDU2dFJVbmhOZ24vSUt1NFA2T0JyTUx4U1Uy?= =?utf-8?B?QlQwUENkMExzUldhTmt2TUNzQ0lrMFdrd3JQY2Qvc25wRU15cW5tRHRYRExK?= =?utf-8?B?UEt3UXhnRWZuM1dxaTd6MnN3cEcyOFY2bFkrK3pkbkVDUTFsOXRXNUQvb0xt?= =?utf-8?B?OVRaVWJlV21pZ0VMOTNnbnV1VmpNZGZScG9qdzRpcm5lRkJVTHNON3VvdTZz?= =?utf-8?B?akZqQXo4Ykp5dmFjTjJXVUtLS1NVRW1RVEJ1KzNWMjlvNlBPL2V2cTRZUEhh?= =?utf-8?B?YVk3QlhSTFh0S1A4QzFzZmZPQ2tidGhnY0VINWhoYlVkTmdKd2luZHI5UEdN?= =?utf-8?B?UXhkaGtEZnJyaFNQdWJMc2NXOEFiNllnMUd6RGV4M2FMLzFTSVBWS0RjcjBi?= =?utf-8?B?aEpLb0t1SXdUVEx5elJYZVdON3h3OXpmR01lL2tXQ2ZNZks3bFpMVERqVXQz?= =?utf-8?B?aGd4SGpwMS9uVVQxbzVWRkxwRzBwMUh1MlRmM00wOWx3Tlc5K3QwdStSM1J5?= =?utf-8?B?MU11TGlseGlEK3ZqODU2azVHaDJ2NEtNT3ozNkxFa21QU1dwckV6U1lCOHJy?= =?utf-8?B?UE43bXJBOXAzby9WUVJzaDRXTENqK2ZlTDZQaEZxUHdOeGR6bzcxOTN2M0l1?= =?utf-8?B?cjBjbTNIUFY1cWsxTW1ic2t4V25ub1h2WnBabjNzaThsOTVjUFRmYXZpcXhE?= =?utf-8?B?YUkzOW84Zis4NWdtVVAxV3VyZHllQlBEQkh6NHBTWEFDYnJodWs3NFIwYjNO?= =?utf-8?B?YnRlM29FYm93QjlTQ0xka2E2YXZ1VnFQL0pjeFJQejk3UVc4cUhBemZqK3U1?= =?utf-8?B?T0d0eDVUVm5XWVpBK21hdC9KOGpiNXdtTFdSR2FPZ1RUTEt1M1pQWmRCTlV2?= =?utf-8?B?eGJXVlhvUE1LR3pLbkNmOHJUVE82eloydFVRaEt2ZmM0SVpQeGRvV1hXMEls?= =?utf-8?B?Y3ZDTHRHZm5OR2h5N3NjRlJOcXJwNkhVRzFhQ1QzTUFhNzkxeWFlT2dYNmMy?= =?utf-8?B?T3BudStJWkE0Z1B2SlFZTm1SQlc2c2ZEQ3AzUjkrUCtaalZMUjZwd1lubEhX?= =?utf-8?B?WWlMSkF6UHVrdVpGSytZUWlZOEZqQjMzSjhDZHVwYkFxOEhubEtJUytyWVR5?= =?utf-8?B?UjBWeDIySURlWUVDN2Zqa0o4UnI1SHIvcFdZLzFCeEViZUxDZGNiMTBsYUxH?= =?utf-8?B?WFZHN3pLc09zZWxpZ2cxUWtGMmtSL0V6ZWlwU2RZbFJ2OC9QVVkzMWN1NVQ1?= =?utf-8?B?eklOR3Uza0ppblh0QUZPVkdhYVErNjVBcXF3QytBSi9wTVN6RWdnbmhQc3d5?= =?utf-8?B?aldRK21IRXJtVHBkMGxHa3gxcE9DUVMxZm1DTTA3dWRJSWVnRWJaYURsb2ZQ?= =?utf-8?B?NFFGN3RMdXZ0SHZ0Y1pVT0ZwRWRReEhFUWxLMlBwTGc5YmNQcG14cHh5Q2pm?= =?utf-8?B?cVMyUmh0a3FsM2EyMmZUb3BSM1B4RDRJMjZvdldoK1RuUmZGdWw4S3hHVU5F?= =?utf-8?B?MUM3SmV0SXVnVXFHVHhUZHZzTXVJWGxRczZZaXcyc3ZzaGlZaUVMQmthN2pN?= =?utf-8?B?TzNOTWpvNVNYMnZ1emZPZWhSSy9FRXNOOGEvVXV4bXhUTmFvbVMzSGE1ZEFs?= =?utf-8?B?ZFhDWEpaMmx5ZGdRY2kzSFRlTWZSeWNhamVSTUhvMnd2L0pXb29zeFRkL0tz?= =?utf-8?B?dndwRWNGVlZhaDhOVU5Fekt2OWJJdlR1V1h3NVl5VGdGWkorZG9qdUFYRmZ4?= =?utf-8?B?b2ZIUi9RQ2k4Wlh6bEQzWU5TU29WVjN2aHZ2MHpIN2U5MzYxZUZYNk42WWVh?= =?utf-8?B?Y1M5djFvblB3UzVUdXQrY01oYU5IZVFNMXRmZ3EzbDBsZ3M4bU9majBnWXpx?= =?utf-8?B?eTFhd3pzU3BOSE1pL0xvMmlaT3VGR1R2aVZtUHFjUmFISEJzeDZwblNBR3BQ?= =?utf-8?B?bGc9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7a7b104-f118-49da-c2e8-08dd079f37b3 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2024 07:04:17.4613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CqXN2ZdwpOR8iwftYlSvETpVzu7/GdHak1EDxAkrTA94ioOG/8KgH0b+F4gtae2lnH8OCC8vLQFaX4w25vyjNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9690 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 15-11-2024 11:35, Stephen Hemminger wrote: > More bitmask truncation from mask computation. > > Fixes: 0ee17f79ebd0 ("event/dpaa: add enqueue/dequeue") > Cc: sunil.kori@nxp.com > Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > --- > drivers/event/dpaa/dpaa_eventdev.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c > index 853cc1ecf9..400e0ecd1c 100644 > --- a/drivers/event/dpaa/dpaa_eventdev.c > +++ b/drivers/event/dpaa/dpaa_eventdev.c > @@ -102,7 +102,7 @@ dpaa_event_enqueue_burst(void *port, const struct rte_event ev[], > qman_dca_index(ev[i].impl_opaque, 0); > mbuf = DPAA_PER_LCORE_DQRR_MBUF(i); > *dpaa_seqn(mbuf) = DPAA_INVALID_MBUF_SEQN; > - DPAA_PER_LCORE_DQRR_HELD &= ~(1 << i); > + DPAA_PER_LCORE_DQRR_HELD &= ~(UINT64_C(1) << i); > DPAA_PER_LCORE_DQRR_SIZE--; > break; > default: > @@ -199,11 +199,11 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], > /* Check if there are atomic contexts to be released */ > i = 0; > while (DPAA_PER_LCORE_DQRR_SIZE) { > - if (DPAA_PER_LCORE_DQRR_HELD & (1 << i)) { > + if (DPAA_PER_LCORE_DQRR_HELD & (UINT64_C(1) << i)) { > qman_dca_index(i, 0); > mbuf = DPAA_PER_LCORE_DQRR_MBUF(i); > *dpaa_seqn(mbuf) = DPAA_INVALID_MBUF_SEQN; > - DPAA_PER_LCORE_DQRR_HELD &= ~(1 << i); > + DPAA_PER_LCORE_DQRR_HELD &= ~(UINT64_C(1) << i); > DPAA_PER_LCORE_DQRR_SIZE--; > } > i++; > @@ -263,11 +263,11 @@ dpaa_event_dequeue_burst_intr(void *port, struct rte_event ev[], > /* Check if there are atomic contexts to be released */ > i = 0; > while (DPAA_PER_LCORE_DQRR_SIZE) { > - if (DPAA_PER_LCORE_DQRR_HELD & (1 << i)) { > + if (DPAA_PER_LCORE_DQRR_HELD & (UINT64_C(1) << i)) { > qman_dca_index(i, 0); > mbuf = DPAA_PER_LCORE_DQRR_MBUF(i); > *dpaa_seqn(mbuf) = DPAA_INVALID_MBUF_SEQN; > - DPAA_PER_LCORE_DQRR_HELD &= ~(1 << i); > + DPAA_PER_LCORE_DQRR_HELD &= ~(UINT64_C(1) << i); > DPAA_PER_LCORE_DQRR_SIZE--; > } > i++; Acked-by: Hemant Agrawal