From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 689151B64F for <dev@dpdk.org>; Mon, 5 Feb 2018 18:39:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 09:39:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,465,1511856000"; d="scan'208";a="32152347" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.145]) ([10.237.220.145]) by orsmga002.jf.intel.com with ESMTP; 05 Feb 2018 09:39:42 -0800 To: dev@dpdk.org References: <3cf7f9aa904a5ba53ba63d7c32539e8b78638939.1513946317.git.anatoly.burakov@intel.com> <cover.1517848624.git.anatoly.burakov@intel.com> <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <c2b14c1a-f67a-e030-6154-ff5bbe6a061d@intel.com> Date: Mon, 5 Feb 2018 17:39:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <750e30c6dcc7a22a87df9c56fb824042b1db984f.1517848624.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 05 Feb 2018 17:39:47 -0000 On 05-Feb-18 4:37 PM, Anatoly Burakov wrote: > During lcore scan, find maximum socket ID and store it. > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> > --- > > Notes: > v3: > - Added ABI backwards compatibility > > v2: > - checkpatch changes > - check socket before deciding if the core is not to be used > > lib/librte_eal/common/eal_common_lcore.c | 37 +++++++++++++++++++++---------- > lib/librte_eal/common/include/rte_eal.h | 25 +++++++++++++++++++++ > lib/librte_eal/common/include/rte_lcore.h | 8 +++++++ > lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++++++++++- > lib/librte_eal/rte_eal_version.map | 9 +++++++- > 5 files changed, 92 insertions(+), 14 deletions(-) > This patch does not break ABI, but does it in a very ugly way. Is it worth it? -- Thanks, Anatoly