From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9DFE9A0C43;
	Fri, 22 Oct 2021 14:23:45 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0E3A24114A;
	Fri, 22 Oct 2021 14:23:45 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 475BB41149
 for <dev@dpdk.org>; Fri, 22 Oct 2021 14:23:44 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A0DEE7F4FE;
 Fri, 22 Oct 2021 15:23:43 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A0DEE7F4FE
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634905423;
 bh=W+Y36uFqO+z+Q8Ui94XoVF62/mZNLL3Qn1hywlrEaOI=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=p8bV1BjK134UYiVaaXKA3aZQvjRDtsR8ADH2AbqGp9IvLUExY7C9iUEoHUTyFy20x
 ntSRtPiy8iIWL+JHa31AfgydCWa3yYp6Uq2NbfscNhlcpJPlvoxgOtrR/mTjmw4aJC
 KyIpaB0KAS/3BwI98XbVXgFVjBdBnrN4zwOYw2UE=
To: Ferruh Yigit <ferruh.yigit@intel.com>,
 Shepard Siegel <shepard.siegel@atomicrules.com>,
 Ed Czeck <ed.czeck@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>,
 Igor Russkikh <irusskikh@marvell.com>,
 Steven Webster <steven.webster@windriver.com>,
 Matt Peters <matt.peters@windriver.com>, Chandubabu Namburu
 <chandu@amd.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Somnath Kotur <somnath.kotur@broadcom.com>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori
 <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Sachin Saxena <sachin.saxena@oss.nxp.com>,
 Haiyue Wang <haiyue.wang@intel.com>, Marcin Wojtas <mw@semihalf.com>,
 Michal Krawczyk <mk@semihalf.com>, Shai Brandes <shaibran@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>, Igor Chauskin <igorch@amazon.com>,
 Gagandeep Singh <g.singh@nxp.com>, John Daley <johndale@cisco.com>,
 Hyong Youb Kim <hyonkim@cisco.com>, Gaetan Rivet <grive@u256.net>,
 Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,
 Ziyang Xuan <xuanziyang2@huawei.com>,
 Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, "Min Hu (Connor)"
 <humin29@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,
 Lijun Ou <oulijun@huawei.com>, Beilei Xing <beilei.xing@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Qiming Yang <qiming.yang@intel.com>,
 Andrew Boyer <aboyer@pensando.io>, Rosen Xu <rosen.xu@intel.com>,
 Shijith Thotton <sthotton@marvell.com>,
 Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
 Jakub Grajciar <jgrajcia@cisco.com>, Matan Azrad <matan@nvidia.com>,
 Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Zyta Szpak <zr@semihalf.com>,
 Liron Himi <lironh@marvell.com>, Heinrich Kuhn <heinrich.kuhn@corigine.com>,
 Harman Kalra <hkalra@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 Rasesh Mody <rmody@marvell.com>,
 Devendra Singh Rawat <dsinghrawat@marvell.com>,
 Maciej Czekaj <mczekaj@marvell.com>, Jiawen Wu <jiawenwu@trustnetic.com>,
 Jian Wang <jianwang@trustnetic.com>, Yong Wang <yongwang@vmware.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
References: <20211022121708.1591089-1-ferruh.yigit@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <c2b41796-7036-1eb1-0037-875cfa33bd32@oktetlabs.ru>
Date: Fri, 22 Oct 2021 15:23:43 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211022121708.1591089-1-ferruh.yigit@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/22/21 3:17 PM, Ferruh Yigit wrote:
> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is
> given by MTU value checks, but some of the checks were wrong by mistake,
> causing device initialization to fail, fixing them.
> 
> Also removing 'Jumbo frame' feature.

Sorry, but I think is is better to split offload removal and
Intel driver fixes.

> 
> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

for offload removal

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

> ---
> Some of the check mistakes are residue of local changes, I remember
> fixing them, but it looks like something went wrong while sending
> patches.