From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id E81181B3A6 for ; Wed, 24 Apr 2019 12:52:25 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id c5so15605523wrs.11 for ; Wed, 24 Apr 2019 03:52:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=9LEbCRHGt5HZW5Z7l/4+tgRqdpXyat1CpvoMBQ2tHz0=; b=LS3eC1POwwhhjVmxCZkzn9a/802emiNiRnDWiWeT319bIz8ipSgmRQrphwYmaG79/v iXWRrdxuEjXMi3OkesAQb/lMtzfnztj+TkLz4ydat2/n44LsXhYTBrL8WQc7GPTRvm4u 3wM0lpdSWgpLRuXvyve3WiG+6wo/4sBJogofi/5y1e/h5THABiMZYItfELCwOCcbj7bN K+K9ugWqQe8xnvEVzO2LjGadDlg+o6iO+Jp2lnx3LHijOuCt9nTyDT2QaBn/teajwKZP 7o8YHPTvC28Zyk0ei1JgRKoyNzTzrdbmKVvc88Ces8NVP7lwn2LHD8+iI8VzDwFTLC3D WD/w== X-Gm-Message-State: APjAAAWeUb9pyKX/GV6js6lW0VXuRDfNeiBWhCjKdBCadxH3fvN2vE46 IS/kHrC6LMl8iAPpx0tK6FM= X-Google-Smtp-Source: APXvYqxyLyU85sKLGatfTC7b1VU5GiTZDjAcjnFnGV2roHckFzYR4eBqWdoZiX71Bt3pvcwnqqDXGA== X-Received: by 2002:adf:dbc1:: with SMTP id e1mr3884077wrj.203.1556103145517; Wed, 24 Apr 2019 03:52:25 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u6sm34525200wrg.72.2019.04.24.03.52.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 03:52:24 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Date: Wed, 24 Apr 2019 11:52:23 +0100 In-Reply-To: <20190424103857.GA1885@bricha3-MOBL.ger.corp.intel.com> References: <20190423154357.29877-1-bruce.richardson@intel.com> <20190423154357.29877-2-bruce.richardson@intel.com> <8b22d3442a857ddf747d38de63c57e5d68f7b1e9.camel@debian.org> <20190424103857.GA1885@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Apr 2019 10:52:26 -0000 On Wed, 2019-04-24 at 11:38 +0100, Bruce Richardson wrote: > On Wed, Apr 24, 2019 at 10:19:20AM +0100, Luca Boccassi wrote: > > On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote: > > > The aesni_mb driver and the aesni_gcm driver both require the > > > same > > > version > > > of the IPSec_MB library, but only the former has a check of the > > > library > > > found by meson to see if it's the correct version. Add a similar > > > check to > > > the aesni_gcm library's meson.build file, so that the auto- > > > detection > > > of > > > dependencies works correctly. > > >=20 > > > Signed-off-by: Bruce Richardson < > > > bruce.richardson@intel.com > > >=20 > > >=20 > > > --- > > > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > >=20 > > > diff --git a/drivers/crypto/aesni_gcm/meson.build > > > b/drivers/crypto/aesni_gcm/meson.build > > > index 70f57ad73..7183cfcba 100644 > > > --- a/drivers/crypto/aesni_gcm/meson.build > > > +++ b/drivers/crypto/aesni_gcm/meson.build > > > @@ -1,11 +1,22 @@ > > > # SPDX-License-Identifier: BSD-3-Clause > > > # Copyright(c) 2018 Intel Corporation > > > =20 > > > +IMB_required_ver =3D '0.52.0' > > > lib =3D cc.find_library('IPSec_MB', required: false) > > > if not lib.found() > > > build =3D false > > > else > > > ext_deps +=3D lib > >=20 > > Shouldn't this be moved into a new else branch after the version > > check? > >=20 >=20 > No, it's harmless where it is, since if build is set to false, the > values > set for sources, deps etc. are all ignored and reset for building the > next > driver in the list. >=20 > /Bruce Ah I see, thanks --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 90FEAA05D3 for ; Wed, 24 Apr 2019 12:52:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E6A21B4AB; Wed, 24 Apr 2019 12:52:27 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id E81181B3A6 for ; Wed, 24 Apr 2019 12:52:25 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id c5so15605523wrs.11 for ; Wed, 24 Apr 2019 03:52:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=9LEbCRHGt5HZW5Z7l/4+tgRqdpXyat1CpvoMBQ2tHz0=; b=LS3eC1POwwhhjVmxCZkzn9a/802emiNiRnDWiWeT319bIz8ipSgmRQrphwYmaG79/v iXWRrdxuEjXMi3OkesAQb/lMtzfnztj+TkLz4ydat2/n44LsXhYTBrL8WQc7GPTRvm4u 3wM0lpdSWgpLRuXvyve3WiG+6wo/4sBJogofi/5y1e/h5THABiMZYItfELCwOCcbj7bN K+K9ugWqQe8xnvEVzO2LjGadDlg+o6iO+Jp2lnx3LHijOuCt9nTyDT2QaBn/teajwKZP 7o8YHPTvC28Zyk0ei1JgRKoyNzTzrdbmKVvc88Ces8NVP7lwn2LHD8+iI8VzDwFTLC3D WD/w== X-Gm-Message-State: APjAAAWeUb9pyKX/GV6js6lW0VXuRDfNeiBWhCjKdBCadxH3fvN2vE46 IS/kHrC6LMl8iAPpx0tK6FM= X-Google-Smtp-Source: APXvYqxyLyU85sKLGatfTC7b1VU5GiTZDjAcjnFnGV2roHckFzYR4eBqWdoZiX71Bt3pvcwnqqDXGA== X-Received: by 2002:adf:dbc1:: with SMTP id e1mr3884077wrj.203.1556103145517; Wed, 24 Apr 2019 03:52:25 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u6sm34525200wrg.72.2019.04.24.03.52.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 03:52:24 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org Date: Wed, 24 Apr 2019 11:52:23 +0100 In-Reply-To: <20190424103857.GA1885@bricha3-MOBL.ger.corp.intel.com> References: <20190423154357.29877-1-bruce.richardson@intel.com> <20190423154357.29877-2-bruce.richardson@intel.com> <8b22d3442a857ddf747d38de63c57e5d68f7b1e9.camel@debian.org> <20190424103857.GA1885@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190424105223.pHUCbxxW1rlH6T7r3vJuKbFixFZ0ZDgV4tVx37dgGz4@z> On Wed, 2019-04-24 at 11:38 +0100, Bruce Richardson wrote: > On Wed, Apr 24, 2019 at 10:19:20AM +0100, Luca Boccassi wrote: > > On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote: > > > The aesni_mb driver and the aesni_gcm driver both require the > > > same > > > version > > > of the IPSec_MB library, but only the former has a check of the > > > library > > > found by meson to see if it's the correct version. Add a similar > > > check to > > > the aesni_gcm library's meson.build file, so that the auto- > > > detection > > > of > > > dependencies works correctly. > > >=20 > > > Signed-off-by: Bruce Richardson < > > > bruce.richardson@intel.com > > >=20 > > >=20 > > > --- > > > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > >=20 > > > diff --git a/drivers/crypto/aesni_gcm/meson.build > > > b/drivers/crypto/aesni_gcm/meson.build > > > index 70f57ad73..7183cfcba 100644 > > > --- a/drivers/crypto/aesni_gcm/meson.build > > > +++ b/drivers/crypto/aesni_gcm/meson.build > > > @@ -1,11 +1,22 @@ > > > # SPDX-License-Identifier: BSD-3-Clause > > > # Copyright(c) 2018 Intel Corporation > > > =20 > > > +IMB_required_ver =3D '0.52.0' > > > lib =3D cc.find_library('IPSec_MB', required: false) > > > if not lib.found() > > > build =3D false > > > else > > > ext_deps +=3D lib > >=20 > > Shouldn't this be moved into a new else branch after the version > > check? > >=20 >=20 > No, it's harmless where it is, since if build is set to false, the > values > set for sources, deps etc. are all ignored and reset for building the > next > driver in the list. >=20 > /Bruce Ah I see, thanks --=20 Kind regards, Luca Boccassi