From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08F3A42D01; Tue, 20 Jun 2023 04:53:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9983F4068E; Tue, 20 Jun 2023 04:53:45 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 987D2400D6; Tue, 20 Jun 2023 04:53:44 +0200 (CEST) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QlWNT5k3sztR0d; Tue, 20 Jun 2023 10:51:05 +0800 (CST) Received: from [10.78.231.32] (10.78.231.32) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 20 Jun 2023 10:53:40 +0800 Message-ID: Date: Tue, 20 Jun 2023 10:53:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v3] net/bonding: fix bond startup failure when NUMA is -1 To: Ferruh Yigit , Chaoyong He , CC: , , Zerun Fu , , Peng Zhang , Long Wu References: <20230616071558.1278520-1-chaoyong.he@corigine.com> <20230616072034.1278546-1-chaoyong.he@corigine.com> <3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com> From: "humin (Q)" In-Reply-To: <3237ae77-bd68-cffa-f1f6-537ff871496e@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.78.231.32] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/6/19 16:57, Ferruh Yigit 写道: > On 6/16/2023 1:00 PM, humin (Q) wrote: >> Hi, >> >> 在 2023/6/16 15:20, Chaoyong He 写道: >>> From: Zerun Fu >>> >>> After the mainline Linux kernel commit >>> "fe205d984e7730f4d21f6f8ebc60f0698404ac31" (ACPI: Remove side effect >>> of partly creating a node in acpi_map_pxm_to_online_node) by >>> Jonathan Cameron. When the system does not support NUMA architecture, >>> the "socket_id" is expected to be -1. The valid "socket_id" in >>> BOND PMD is greater than or equal to zero. So it will cause an error >>> when DPDK checks the validity of the "socket_id" when starting the >>> bond. This commit can fix this bug. >>> >>> Fixes: f294e04851fd ("net/bonding: fix socket ID check") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Zerun Fu >>> Reviewed-by: Peng Zhang >>> Reviewed-by: Chaoyong He >>> Reviewed-by: Long Wu >> No need add your colleagues unless they "reviwed-by" through email-list. >> > Hi Connor, > > This is done time to time, if code is already internally reviewed, send > review/ack tags within the patch, to reduce noise in the mail list. ok. > > It looks like there were additional reviewers of code, which is good, > but it requires maintainers' (you and Chas) ack to get accepted. Acked-by: Min Hu (Connor)