Re: [dpdk-dev] [PATCH v2 17/20] net/bnxt: drop untagged frames when specified

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/3/2019 12:25 AM, Ajit Khaparde wrote:
> When a drop action for L2 filters is specified, support it.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>

<...>

> @@ -1121,19 +1152,27 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev,
>  		break;
>  	case RTE_FLOW_ACTION_TYPE_DROP:
>  		vnic0 = &bp->vnic_info[0];
> +		filter->dst_id = vnic0->fw_vnic_id;
> +		filter->valid_flags |= BNXT_FLOW_L2_DROP_FLAG;
>  		filter1 = bnxt_get_l2_filter(bp, filter, vnic0);
>  		if (filter1 == NULL) {
> +			rte_flow_error_set(error,
> +					   ENOSPC,
> +					   RTE_FLOW_ERROR_TYPE_ACTION,
> +					   act,
> +					   "Filter not available");
>  			rc = -ENOSPC;
>  			goto ret;
>  		}
>  
> -		filter->fw_l2_filter_id = filter1->fw_l2_filter_id;
>  		if (filter->filter_type == HWRM_CFA_EM_FILTER)
>  			filter->flags =
>  				HWRM_CFA_EM_FLOW_ALLOC_INPUT_FLAGS_DROP;
> -		else
> +		else if (filter->filter_type == HWRM_CFA_NTUPLE_FILTER)
>  			filter->flags =
>  				HWRM_CFA_NTUPLE_FILTER_ALLOC_INPUT_FLAGS_DROP;
> +
> +		bnxt_update_filter_flags_en(filter, filter1);

This function gets three parameter [1], you are breaking the build here and
fixing it later in the patches, I will fix this while merging.
But please test patch by patch build next time.

[1]
bnxt_update_filter_flags_en(filter, filter1, use_ntuple);