From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 7691E2E83
 for <dev@dpdk.org>; Mon, 12 Dec 2016 21:10:39 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga105.jf.intel.com with ESMTP; 12 Dec 2016 12:10:38 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,338,1477983600"; d="scan'208";a="1098189140"
Received: from dbouroub-mobl.ger.corp.intel.com (HELO [10.252.29.162])
 ([10.252.29.162])
 by fmsmga002.fm.intel.com with ESMTP; 12 Dec 2016 12:10:37 -0800
To: Harish Patil <harish.patil@qlogic.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com>
 <1480733039-13046-7-git-send-email-harish.patil@qlogic.com>
 <ef349aec-eed6-d82d-c68f-b613cab89776@intel.com>
 <D47438FD.C04E6%Harish.Patil@cavium.com>
Cc: Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <c2f4e2b7-4d4a-fecc-eb41-b82c596edfc2@intel.com>
Date: Mon, 12 Dec 2016 20:10:36 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <D47438FD.C04E6%Harish.Patil@cavium.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 7/7] net/qede: restrict maximum queues for
 PF/VF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 20:10:39 -0000

On 12/12/2016 7:29 PM, Harish Patil wrote:
> 
>> On 12/3/2016 2:43 AM, Harish Patil wrote:
>>> Fix to adverstise max_rx_queues by taking into account the number
>>
>> s/adverstise/advertise
> 
> Will correct that, thanks.
> 
>>
>>> of PF connections instead of returning max_queues supported by the
>>> HW.
>>
>> Can you please describe what is the effect, what happens if this is not
>> fixed, and driver keeps reporting max_queues supported by the HW?
> 
> We have tested up to 32 Rx/Tx queues across different qede devices, so I
> would like to advertise only those many.
> Hope that is okay.

That is OK, can you please add this information to the commit log,
otherwise it is not possible to know the reasoning of the change just
with code.

Thanks.

> 
>>
>>>
>>> Fixes: 2ea6f76a ("qede: add core driver")
>>>
>>> Signed-off-by: Harish Patil <harish.patil@qlogic.com>
>>> ---
>> <...>
>>
> 
>