From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1A3345A81; Fri, 4 Oct 2024 05:56:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A26FA402DD; Fri, 4 Oct 2024 05:56:42 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2053.outbound.protection.outlook.com [40.107.95.53]) by mails.dpdk.org (Postfix) with ESMTP id 4CED6402C9 for ; Fri, 4 Oct 2024 05:56:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OCz8ds3fc4UXQiFxq46az/ZgjlRPVbKTj5f76QNPo+PzYPIG0CZqF0xdmuu6Qb7KR7Gnr/MITv29X5Ctr6LmRLMud7J8mkn3YxcJyrFlgTNpgN7oIN6YqRUebM+vR8KmXziC4whZZLTJSHfj2tVTpOiRY7N6bEvC8163N6SsF5v7snUNynQSZP9UtG23peVZ16s9ttyzST8oPsi+T2HYU/aHKzuHwyo4Gv1Fw01LIBuh6wibaOxZ8GoqiXHXMXrdUx00x7DT6DkCazEceFkLK6XOwRt3Jaus93XyMOp+c32wQqNNQJA4SoonRtz3031G/ut/863GxIpSZWiQSt0UxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zW7jhGGDNptnDoNdkCdpubwRLdU0r6hBtAzh3OzeTqg=; b=arwvc5cVIr8tmh3L8npC97rIAeoOX+zZzDPIgZZzZrXMQ6O8uotnaoR9dq6vcJnCPYpF/LkitD522jAjR1lJPD8GUa86+/fQSw+k7RXfmAj2w/4rSy+4elXNbVLo9278B0OhgnRlT98u0R9TF9SvYJZ+do9Onl5fPHRxCwBZGbEsM0ripnhTAlF1kFC9VEHS+JUOvNJFRQlXOWJnty1Uyx6aDEx6k7tmkAmvk0O6HEDEkDiZ0PnGioqUa9FvCroUEXb+wDV2qZiWVbJC5VZGMdJP5Jk+MB3XO+j/ebQ/x4WKadBDiE2v/Bf4tGA1sbHGNqxUK0vPVA6CchdwH6hkJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zW7jhGGDNptnDoNdkCdpubwRLdU0r6hBtAzh3OzeTqg=; b=DspLo5gAz9hYLMjShRvtNoS6Y+i+o9OtVqjqQ/cnFCyxFEwE68V1wXik7wxcKsBv+NIhr6w8LQLcR2hXa0r2uU8KJTcHZ+b0LzmXYFrv9iK0Z8NZTMCXS3Vk7GBr0Gn7FqBUtjC3UklSQZThUFDolvGz1IWNYM22uxugdgQ9KUA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by BY1PR12MB8445.namprd12.prod.outlook.com (2603:10b6:a03:523::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Fri, 4 Oct 2024 03:56:39 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8026.017; Fri, 4 Oct 2024 03:56:39 +0000 Message-ID: Date: Fri, 4 Oct 2024 04:56:30 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [EXTERNAL] Re: [PATCH] [RFC] cryptodev: replace LIST_END enumerators with APIs To: Akhil Goyal , fengchengwen , =?UTF-8?Q?Morten_Br=C3=B8rup?= , "dev@dpdk.org" Cc: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "pablo.de.lara.guarch@intel.com" , "fiona.trahe@intel.com" , "declan.doherty@intel.com" , "matan@nvidia.com" , "g.singh@nxp.com" , "fanzhang.oss@gmail.com" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "konstantin.v.ananyev@yandex.ru" , "radu.nicolau@intel.com" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , "mdr@ashroe.eu" References: <20240905101438.3888274-1-gakhil@marvell.com> <98CBD80474FA8B44BF855DF32C47DC35E9F6A8@smartserver.smartshare.dk> <1d17f91a-fbfe-229b-9772-c149ed9d335a@huawei.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0648.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::19) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|BY1PR12MB8445:EE_ X-MS-Office365-Filtering-Correlation-Id: 67a23501-0e49-4311-8b00-08dce4288cbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7416014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WmRWZVN2R2VyOUlpNXFtWStQQlQ0YWNhalhVVGF5a0hYbGJnQTFvd1ozR213?= =?utf-8?B?VUhCa3ZxYXdZQTlHdGJYb1g1cnMzNXV6SjIzYjFLYkdiSHo0UW9hekRrSG1w?= =?utf-8?B?Q3RYRXAzejV4NFFWYzhZeUVDemJPNFA0VGlZNXdoWkx3anNWQ2ZreFgra0Zi?= =?utf-8?B?MUVXemZPcFhjdTRIeTIzQjQ5SUcvclNoSzhONGNOWWJjK1JRL0lwZElYRUth?= =?utf-8?B?NktCRkJ2MWNFQ3JlRms0SCsyVSt5TEZvQW01R01DOTlpOUNIMzNiRWcrZUlx?= =?utf-8?B?VTgyK1UwRUhNM1pQOEtTTlY0TzlveitGbDZHYzBsYWNTd1ZjSlJxdXdqV3VC?= =?utf-8?B?am1Gb0RRbUQ3YjJBSFpJaVBJQW5yNlhxaEN0SlZvOWYxbm9RaG1Hc2daNjhJ?= =?utf-8?B?VTdMQTZEM1g1VkFLREtuQUxleit5RGpuY0o1aDVtWjFxamtNOXdnRTR0SXNC?= =?utf-8?B?dDc4WlpmM0V0S2ZCV0NzaERhcE8xRHNkZmNmZHlQc0RVUHpKNUNvUUtxRUxZ?= =?utf-8?B?L0NMaGhmdm5wZmFBcDZ3MkNnd1VNdm1uWWpUYWwyM2tTdHBZWmxnUVBpMEx2?= =?utf-8?B?aS9nM3lDQXBneThqaURxN0doRzF3VGdLdUZsaDlrSGdaK1A1TkFEd3dscjUv?= =?utf-8?B?OVVtYVFoQ2xrM1J6d0U2eEpGeWEzWE9RZVVYbkt3cTFGTkQ1RzE4YWtocHRk?= =?utf-8?B?Z1ZWRnBQNG5xY09JdEdEVmIyMjZUZUxRenkwcEVVcXh4ckxkMEt0L25sK3M1?= =?utf-8?B?U1IrSC9iY05zVUtlODRpS2YrZzdHK0NtejVSMkk5V0tYTHdCV0I4UjJTVzdj?= =?utf-8?B?R0Z6bGMza2xQRVBKTmR0OG45M3BKdW4wSnE3d3F6WTRBVHRhUjV0dkNhSEpD?= =?utf-8?B?K2VMTXh0UjBORUx6cms5cCs1d0Yra0k5M21LRjBMNHZYb1FUUm8vN0V1Z3BY?= =?utf-8?B?cy9SRGRMV25sNk1NVUhvLzl5a2tubVhoWU9lTkJ3RXNvNmkzbTkvTWlqaXhQ?= =?utf-8?B?SDVpS3NObUVjYjRXQ0tLY2tFajl6cDFMUjg5TDIvR1RMaEFmdm13d2lGWkky?= =?utf-8?B?d3R6Nktaa1pUaU9YdzBXRkE0STg4YUFrd1FVTnVxdng3MUgwOEl5MnRSM2ov?= =?utf-8?B?N0xLVVNiL21sT253L2xCd05JdWY0cXFkMnZpcUtFWm5udU1TNDg5S0pxTkNV?= =?utf-8?B?R1U5eVozMytpUTU2bXhUQVE3UWRvNWdzRFpqUmlBeWxXemNqbmRlTUVnK2Z2?= =?utf-8?B?MlF3enVRc1dNTy9FWW5nd3RUMVRwUCsvVVo1dFhnNnlDMnBDdml5NlVjQnF0?= =?utf-8?B?STdQMkUxejZ2b0pUdkVsQWtUWDZpOWpZYm4vaXRrWThnOWxFanFtWDhkZXdJ?= =?utf-8?B?Ty9YTXNlU21odG9MQjhqREMyUElKeWxJT0tpc0Uvc25GbkxaRmhkTXlTYWE1?= =?utf-8?B?eFQ4aXhWVDgvK0JTK0VoVXRkS2dJRGdsaW5NeDh6UGNxdnpVeWE2R09WM3Jl?= =?utf-8?B?d2VZZmZPR2tpTzd2UCtYL2xONC9EUkFxV1RuVjMzVmZ5bXlLM0hhOUhMclNS?= =?utf-8?B?cUd1SnVld1RRaElQVVM3c3dqK3p6N3YzVkNtcVcvV1ZBZ0hUckgwY05ZUFdu?= =?utf-8?B?REE3UTM2MzJmeDlObTBSWllMaHVuMkNPS3hUZzNqaXNaU210d2pNdTRKQjJh?= =?utf-8?B?dW9aV0xsbjM5cDR6ak5QYzNkYTI2dnZsUDhyUDQxenp5d2VBajBLaFpnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(7416014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0lNMGRtUG1rU0U4T3dnaWNOQVVMdmc1Z1ppTVg3NGZyR1N4ZUJORUlkcEZB?= =?utf-8?B?VVJUV2ViRm5lRzdCV2JnN3NkdXZQVXpqcGh0c0dWWU42VXNQNnVUREkrREFK?= =?utf-8?B?MHRSK2NrWHc4SzgvVVovbVZLMk12Y0JzMUh3cDFQMitXaEh4TXBSNTlkaUJL?= =?utf-8?B?L2svais3UVJJaDczNVl1TWQ4d3hXSXR4TVFTSUpkcHR4TWg2cis3Sk1tbWR0?= =?utf-8?B?a1l2WUxVMTdkdXgyVS9ESndMWlpweDdiZlVDUU4vb0RSNU1TRCttQ2dHZ0hq?= =?utf-8?B?SGl3K0xoRE5IUUZQaUhWSGY3Q0hTNmp2TWgrRUVvRDhoejNVRmxkUnpjdWxI?= =?utf-8?B?ZUYrK0V6dlR2SXYvTzYwMlJqMGRFbFNXYWhCRzA2M3BnRHRzU3ZiUWQ4K3B0?= =?utf-8?B?cHhhWDFxWlZEOXRZSFUzK3BUajczMkwzY2cxR2FxOHIxQTNOdVBQbXNJbmlD?= =?utf-8?B?Q3VNM2xFNU1rdnZQU1NtMTVPbDRZcEJHNDY1ZjEyL2IyNS9ZekdVbVBMdHl5?= =?utf-8?B?TU1EL0c1clVtOXZYRW0vNmI1MTh2MUV2MG5wZ2IwZmljWWtwUHNyWlJmNE0r?= =?utf-8?B?S1dBMFUzUkp0aEF6ZkhNREszUFdKVlZmZWlqclV3S253ZUpVTUtiMER3clpy?= =?utf-8?B?b2ZSNDVOWXM4dTlXa0dRTWFaQm03dksvamJGZXpyenlxL0pzNTZzQ0lEcFRh?= =?utf-8?B?bkdHdEJYOVlFVkxBclhiZnNlc2VCSkwwN0pyWFJyYy9uOE9pbmJMbU5wRmh4?= =?utf-8?B?VHB4SEN5bEdoTVBtRmNGS0srbkhDRjdVV01rOXJNMUJ5TEFVVThQdjFrK0pm?= =?utf-8?B?ZTVuQXE3RUlxT2t0NzlWdXhqQ1BjRXRxNjFXcmRUL1RzU3UweU5HVXhtbThT?= =?utf-8?B?OXBZR2pEVlN2eVRnQ3ZTRTZBeTB5bldPR0JXaUhuVHhhRWVwN0RCRWFmeEla?= =?utf-8?B?VmJaUHBhZHhwUi9KVFBkaE94ZFduY2JwbG5hYlQzTzZEWnV3bDhoWjg5eHEx?= =?utf-8?B?L3RpVlg5dHduaWNXN2NRcmxVbmJ6SzdlUWcxOEhYT0VhV2ozeTNhQitBbkJP?= =?utf-8?B?TlBmMWRvemxscXBGbkNid0F6ZFppS1lpNG5VSTZPOHJrTTRZc08wckZCUUll?= =?utf-8?B?RTEvQjJlT2psQUlHY0lxUjd2YWdNaXFCazhQeWxYc1NXUWJGN1l5WkducldF?= =?utf-8?B?cjA0N2ZNam1lRzd0WWxJcXpCb25jeGpGSkdUTU56WjhESzZmTmRxWnM4RXVl?= =?utf-8?B?bWlacXZQMVBDc2N0T0N3ZGUrZWVzTk1DYkU1L2ZJYWpURndQQUVIS2UraE9o?= =?utf-8?B?Zi9ORUI1cXdQSjkxYWFRZjJOV3luU1Mxc2lycWFMZ1NtcUJOeGlvOEtJdCsx?= =?utf-8?B?NklURlVQSHFBY09aR2JkMmNaR0VtRWVIR1gyVDJJZGYyM2IrWjE1Q015Nnlp?= =?utf-8?B?RG1hM1Q5RCtKeE1mV0NJYWlyckdsdlRreHRSWVhuN0NvQmtkTy9FOC9TZFdY?= =?utf-8?B?QjVaK01VZDV4MTZqSkhlS1B6Tk42NVpaZTk1eEE5dzdTR0xJa0F3OGplaHlN?= =?utf-8?B?dnFuMzlIaVk4WERqdnpIK0lXUnp4b3ZydGRqYlJVUGEzM21MNHJoV0hLR01o?= =?utf-8?B?SzJyU1hMNGRHcFNNaDJoTnBwVjdmVHRLRUt3NXRiQXFCU3VveEpDWWlBeFo2?= =?utf-8?B?cU4wK1FuNVVtV0UxZUNXVlpYVGhkRU13VEpKV3RVeGVXTjdEUjRSaDlLdTdR?= =?utf-8?B?UlhpcE1Zd09wakVHQ0dvRlZ3bVA4WkNBNzY5N0EvZ1lTbTNBNWNKQXhoVFl6?= =?utf-8?B?NXA1bm1rVCttb21UOWZkbXhBbDZPSDZza04vQ2RjZHF0WjQ0ZnJ3RUZZZVNP?= =?utf-8?B?UXQ2MUhXclU3RVl3QWxlUFhVb1pnbVgvY2NKNHM5NUJjWWVJUXpPK3NmeElr?= =?utf-8?B?c1MwQnAwMG95RGY4YkNYa3ZuaTdkT204MHFXRGliUE4zbGJ2cmhMTFRmYjFQ?= =?utf-8?B?ei9lai81MnBmV2I5b3g3Umh5SVpCWmY5aGVYVVVuRTRFK1NNaHpnSUpPbG5h?= =?utf-8?B?bTVnc29HaGIvZ2ozVWowcUVYdE1EekdYaW5UOWJlOWFxTElQcUpaUGpJTGpS?= =?utf-8?Q?IbzoTTuXSHn/v2WTSyiwOlO/W?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67a23501-0e49-4311-8b00-08dce4288cbd X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2024 03:56:39.2919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P2EwyOKq/aQhTKLNyI2Y/UPji+mZMRrSHelE2UWx+D9lWR9IHBw3t2jY47+tv7O3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB8445 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/6/2024 8:45 AM, Akhil Goyal wrote: >>> >>> Here's an idea... >>> >>> We can introduce a generic design pattern where we keep the _LIST_END enum >> value at the end, somehow marking it private (and not part of the API/ABI), and >> move the _list_end() function inside the C file, so it uses the _LIST_END enum >> value that the library was built with. E.g. like this: >>> >>> >>> In the header file: >>> >>> enum rte_crypto_asym_op_type { >>> RTE_CRYPTO_ASYM_OP_VERIFY, >>> /**< Signature Verification operation */ >>> #if RTE_BUILDING_INTERNAL >>> __RTE_CRYPTO_ASYM_OP_LIST_END /* internal */ >>> #endif >>> } >>> >>> int rte_crypto_asym_op_list_end(void); >>> >>> >>> And in the associated library code file, when including rte_crypto_asym.h: >>> >>> #define RTE_BUILDING_INTERNAL >>> #include >>> >>> int >>> rte_crypto_asym_op_list_end(void) >>> { >>> return __RTE_CRYPTO_ASYM_OP_LIST_END; >>> } >> >> It's more generic, and also keep LIST_END in the define, we just add new enum >> before it. >> But based on my understanding of ABI compatibility, from the point view of >> application, >> this API should return old-value even with the new library, but it will return new- >> value >> with new library. It could also break ABI. >> >> So this API should force inline, just as this patch did. But it seem can't work if >> move >> this API to header file and add static inline. >> > Yes, moving to c file does not seem to solve the purpose. > So should we move with the way the patch is submitted or we have some other suggestion? > +1, when it is not inline function, this approach won't work.