From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED922A2F18 for ; Thu, 3 Oct 2019 10:15:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B82F01BFFD; Thu, 3 Oct 2019 10:15:26 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id B2DFC1BFFC for ; Thu, 3 Oct 2019 10:15:25 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id q21so1208986pfn.11 for ; Thu, 03 Oct 2019 01:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=80LxkKwK6mJdeGXviPo0B1za4T5KOxq0EExhCIs2kFw=; b=T8Wwzc6vsIcBryEKRdhZSQFReKHfECRQLkdHQAk1hRV2rNp8CeCrmIzra4DSU7Phuj zQTowGN6EhdI4fHkLPu35a3UcWHw6QO9Kl1/lqKKh1COZ6izugtYhzEi7Agmk3hSFgEW fdK0cV9OP+m0Si2tTOJ8JM28xj44N4vSQxqfPbNEZNVEgCd9mM8FPZCiby85Lx+dSTIN kg93qMsu1jgpsfRurJ5ImJoEOsVTOfvRrcSMazDlJ/Ol1zgfs9E2eMND1CNifuGk+y3R pYWBZe19rUEUQcrdB6OAiWumK2UCVFTYMYYjXG2q3bJM3OelW11m2vqqMG99HBpP1P7a So1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=80LxkKwK6mJdeGXviPo0B1za4T5KOxq0EExhCIs2kFw=; b=GqhmscCXKrOwLFVpS8UHA6NZMitDScrXIIGRBN7XDZqgILAtrlRkHeqwmjbHNyAiWU 9CvyD3KF0Upm+NVRBzm4bdEbL+QdFXq28I8semuxg4dww7XwVw2RHNRCD/3/Vk6k1hae Kajnyd+9pGlIKEOqwzROcIN5NntoXPyfipPkSGdv0knN4/UxsgTbeR5QzUTQ4zIpLbh6 QEHfUfGwrT3/GPy+guiO3DeaMvz+b0obUc3AIrpb9PRRSupmoMpb148Tb2nIAZFusV4d +qIYKEvo2SE2sMuwQ/sQpj0Fz7ALGGjxstRN+ly6OgKMHsqFP4V/P3Pm1SvD4KReS3Le FjtA== X-Gm-Message-State: APjAAAUE+0uIi1GoskN/7rElHEVGLU34nHGu2kNnwh2IPZx4/xuJqQps aJE0CATV759Bgj5/aDS707Y= X-Google-Smtp-Source: APXvYqza6prevz/Fhv3VwCBG/VNBNbnSLswRCXYvaQ0wS261p0Jnrflc5Ii1EV/4HE3CoH13CQJxxA== X-Received: by 2002:a17:90a:bc49:: with SMTP id t9mr9145747pjv.21.1570090524959; Thu, 03 Oct 2019 01:15:24 -0700 (PDT) Received: from mugwort.local ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id x37sm1686560pgl.18.2019.10.03.01.15.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Oct 2019 01:15:24 -0700 (PDT) To: Ferruh Yigit , Tetsuya Mukawa Cc: dev@dpdk.org, Anatoly Burakov , Jingjing Wu , Wenzhuo Lu , Bernard Iremonger References: <20190929024141.30443-1-yasufum.o@gmail.com> <91f5d30e-91ff-d6d4-3adb-a89af97ae6a0@intel.com> From: Yasufumi Ogawa Message-ID: Date: Thu, 3 Oct 2019 17:15:21 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <91f5d30e-91ff-d6d4-3adb-a89af97ae6a0@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/null: fix multi-process rx and tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2019/10/02 1:00, Ferruh Yigit wrote: > On 9/29/2019 3:41 AM, Yasufumi Ogawa wrote: >> Packet processing in secondary process cannot work because rx_pkt_burst >> and tx_pkt_burst in eth_dev are not initialized while probing device. >> This patch is to the initialization. >> >> Signed-off-by: Yasufumi Ogawa >> --- >> drivers/net/null/rte_eth_null.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c >> index 0c60d241a..5a2010e3e 100644 >> --- a/drivers/net/null/rte_eth_null.c >> +++ b/drivers/net/null/rte_eth_null.c >> @@ -586,6 +586,13 @@ rte_pmd_null_probe(struct rte_vdev_device *dev) >> /* TODO: request info from primary to set up Rx and Tx */ >> eth_dev->dev_ops = &ops; >> eth_dev->device = &dev->device; >> + if (packet_copy) { >> + eth_dev->rx_pkt_burst = eth_null_copy_rx; >> + eth_dev->tx_pkt_burst = eth_null_copy_tx; >> + } else { >> + eth_dev->rx_pkt_burst = eth_null_rx; >> + eth_dev->tx_pkt_burst = eth_null_tx; >> + } >> rte_eth_dev_probing_finish(eth_dev); >> return 0; >> } >> > > > Reviewed-by: Ferruh Yigit > > But this seems the issue for other virtual PMDs too, @Yasufumi, can you please > check others too if you have any bandwidth for it? Yes. I have also tried to fix other PMDs, and would like to make some updates for vhost and virtio next if possible. Yasufumi > > > I assume this is missing for a long time because there is not easy way to test > them in secondary process, testpmd doesn't support the multi process. cc'ed > testpmd and multi process maintainers, what do you think about adding multi > process support to testpmd? > > > I tested with "examples/multi_process/symmetric_mp" sample app, it required > fixing with null pmd: > 1- Requested offload config was not supported by null pmd > 2- promics_enable dev_ops was not implemented in null pmd > > We should fix sample app / virtual pmds too so they can work together... >