From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C7942A0C4C;
	Fri, 15 Oct 2021 05:03:17 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9288A40041;
	Fri, 15 Oct 2021 05:03:17 +0200 (CEST)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id B7B4D4003C
 for <dev@dpdk.org>; Fri, 15 Oct 2021 05:03:16 +0200 (CEST)
Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4HVrdV1P9PzWr9T;
 Fri, 15 Oct 2021 11:01:34 +0800 (CST)
Received: from dggema767-chm.china.huawei.com (10.1.198.209) by
 dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id
 15.1.2308.8; Fri, 15 Oct 2021 11:03:12 +0800
Received: from [10.67.103.231] (10.67.103.231) by
 dggema767-chm.china.huawei.com (10.1.198.209) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
 15.1.2308.8; Fri, 15 Oct 2021 11:03:12 +0800
Message-ID: <c31f17a9-f81a-48fc-efea-deb060670729@huawei.com>
Date: Fri, 15 Oct 2021 11:03:12 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
To: Thomas Monjalon <thomas@monjalon.net>
CC: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <aman.deep.singh@intel.com>,
 <andrew.rybchenko@oktetlabs.ru>, <anatoly.burakov@intel.com>
References: <1627908397-51565-1-git-send-email-lihuisong@huawei.com>
 <2527815.Doo92MvZa3@thomas> <13a0f09e-fc93-3256-e58f-11cec1e02dc8@huawei.com>
 <2377545.FrEbOPdPNe@thomas>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <2377545.FrEbOPdPNe@thomas>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To
 dggema767-chm.china.huawei.com (10.1.198.209)
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH V2] ethdev: fix eth device released repeatedly
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


在 2021/10/14 20:50, Thomas Monjalon 写道:
> 14/10/2021 14:32, lihuisong (C):
>> Hi, Thomas
>>
>> *The commit log：*
>> In secondary process, rte_eth_dev_close() doesn't clear eth_dev->data.
>> If calling rte_dev_remove() after rte_eth_dev_close(), in
>> rte_eth_dev_pci_generic_remove()
>> function, the released eth device still can be found by its name in
>> shared memory.
>> As a result, the eth device will be released repeatedly. The state of
>> the eth device
>> is modified to RTE_ETH_DEV_UNUSED after rte_eth_dev_close(). So this
>> state can
>> be used to avoid this problem.
>>
>> Is that will be more clear?
> Yes, that's clear (at least for me).
>
>> /*
>>    * A released eth device can be found by its name in shared memory.
>>    * If the state of the eth device is RTE_ETH_DEV_UNUSED, which means
>>    * the eth device has been released.
>>    */
>>
>> Is it ok to use the above description as a comment in the code?
> Yes. One small change, I think "which" should be "it".
Thanks. I will fix it.
>
>> Hope for your reply.  Thanks.
> Thanks
>
>
>
>
> .