From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mchandras@suse.de>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by dpdk.org (Postfix) with ESMTP id 4F0B12BF5
 for <dev@dpdk.org>; Tue,  4 Apr 2017 14:50:07 +0200 (CEST)
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])
 by mx2.suse.de (Postfix) with ESMTP id E5C3BAAB1
 for <dev@dpdk.org>; Tue,  4 Apr 2017 12:50:06 +0000 (UTC)
To: Nirmoy Das <ndas@suse.de>, dev@dpdk.org
References: <20170404123211.5185-1-ndas@suse.de>
From: Markos Chandras <mchandras@suse.de>
Message-ID: <c374f56f-53ac-4f67-09cd-504aff076c61@suse.de>
Date: Tue, 4 Apr 2017 13:50:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170404123211.5185-1-ndas@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] pci: fix glibc 2.25 warning regarding
 major/minor definitions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Apr 2017 12:50:07 -0000

Hi Nirmoy,

On 04/04/2017 01:32 PM, Nirmoy Das wrote:
> fixes:
> error: In the GNU C Library, "makedev" is defined
> by <sys/sysmacros.h>. For historical compatibility, it is
> currently defined by <sys/types.h> as well, but we plan to
> remove this soon. To use "makedev", include <sys/sysmacros.h>
> directly. If you did not intend to use a system-defined macro
> "makedev", you should undefine it after including <sys/types.h>. [-Werror]
> dev = makedev(major, minor);
>    

You forgot the 'Signed-off-by' line which is required for patches.

See doc/guides/contributing/patches.rst

-- 
markos

SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg