* [dpdk-dev] [PATCH] pci: fix glibc 2.25 warning regarding major/minor definitions
@ 2017-04-04 12:32 Nirmoy Das
2017-04-04 12:50 ` Markos Chandras
0 siblings, 1 reply; 3+ messages in thread
From: Nirmoy Das @ 2017-04-04 12:32 UTC (permalink / raw)
To: dev; +Cc: Nirmoy Das
fixes:
error: In the GNU C Library, "makedev" is defined
by <sys/sysmacros.h>. For historical compatibility, it is
currently defined by <sys/types.h> as well, but we plan to
remove this soon. To use "makedev", include <sys/sysmacros.h>
directly. If you did not intend to use a system-defined macro
"makedev", you should undefine it after including <sys/types.h>. [-Werror]
dev = makedev(major, minor);
^~~~~~~~~~~~~~~~~
---
lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
index 20a4a665e..af0a4a9bc 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
@@ -39,6 +39,7 @@
#include <sys/stat.h>
#include <sys/mman.h>
#include <linux/pci_regs.h>
+#include <sys/sysmacros.h>
#if defined(RTE_ARCH_X86)
#include <sys/io.h>
--
2.12.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix glibc 2.25 warning regarding major/minor definitions
2017-04-04 12:32 [dpdk-dev] [PATCH] pci: fix glibc 2.25 warning regarding major/minor definitions Nirmoy Das
@ 2017-04-04 12:50 ` Markos Chandras
2017-04-04 12:50 ` Markos Chandras
0 siblings, 1 reply; 3+ messages in thread
From: Markos Chandras @ 2017-04-04 12:50 UTC (permalink / raw)
To: Nirmoy Das, dev
Hi Nirmoy,
On 04/04/2017 01:32 PM, Nirmoy Das wrote:
> fixes:
> error: In the GNU C Library, "makedev" is defined
> by <sys/sysmacros.h>. For historical compatibility, it is
> currently defined by <sys/types.h> as well, but we plan to
> remove this soon. To use "makedev", include <sys/sysmacros.h>
> directly. If you did not intend to use a system-defined macro
> "makedev", you should undefine it after including <sys/types.h>. [-Werror]
> dev = makedev(major, minor);
>
You forgot the 'Signed-off-by' line which is required for patches.
See doc/guides/contributing/patches.rst
--
markos
SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] pci: fix glibc 2.25 warning regarding major/minor definitions
2017-04-04 12:50 ` Markos Chandras
@ 2017-04-04 12:50 ` Markos Chandras
0 siblings, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2017-04-04 12:50 UTC (permalink / raw)
To: Nirmoy Das, dev
On 04/04/2017 01:50 PM, Markos Chandras wrote:
> Hi Nirmoy,
>
> On 04/04/2017 01:32 PM, Nirmoy Das wrote:
>> fixes:
>> error: In the GNU C Library, "makedev" is defined
>> by <sys/sysmacros.h>. For historical compatibility, it is
>> currently defined by <sys/types.h> as well, but we plan to
>> remove this soon. To use "makedev", include <sys/sysmacros.h>
>> directly. If you did not intend to use a system-defined macro
>> "makedev", you should undefine it after including <sys/types.h>. [-Werror]
>> dev = makedev(major, minor);
>>
>
> You forgot the 'Signed-off-by' line which is required for patches.
>
> See doc/guides/contributing/patches.rst
>
Ah never mind I just saw v2.
--
markos
SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-04 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 12:32 [dpdk-dev] [PATCH] pci: fix glibc 2.25 warning regarding major/minor definitions Nirmoy Das
2017-04-04 12:50 ` Markos Chandras
2017-04-04 12:50 ` Markos Chandras
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).