From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF141A034F; Wed, 6 May 2020 11:29:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 741161D708; Wed, 6 May 2020 11:29:16 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2BD111D705; Wed, 6 May 2020 11:29:15 +0200 (CEST) IronPort-SDR: 8EOlO3muEWwIw+fxMGB685qusFB9rIsvJyh7YqVLVv/61b1CsUXJdDodJGRYFDbkW2B++ssaIU K7gvryLwjutQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 02:29:14 -0700 IronPort-SDR: kcYakx7bkU/p4Ns9/r/Vmriu7Gy4vsou2/x8vQ1VxURBlcgFzuwueXvm8XI1v3MeycoMyc3zkg 030Ng9sluomA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,358,1583222400"; d="scan'208";a="461370289" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.197.179]) ([10.213.197.179]) by fmsmga005.fm.intel.com with ESMTP; 06 May 2020 02:29:12 -0700 To: "Zhao1, Wei" , "dev@dpdk.org" Cc: "stable@dpdk.org" , "Xing, Beilei" , "maxime.leroy@6wind.com" , Kevin Traynor References: <20200428073919.5583-1-wei.zhao1@intel.com> <20200429020353.20266-1-wei.zhao1@intel.com> <20200429020353.20266-3-wei.zhao1@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Wed, 6 May 2020 10:29:11 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each pctype for FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/6/2020 2:05 AM, Zhao1, Wei wrote: > HI, Ferruh > > This is the patch enable FDIR for flow filter, so we can use this. > > Fixes: 14c66a451ef ("net/i40e: parse flow director filter ") > Cc: stable@dpdk.org Updated the commit log, thanks. > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Thursday, April 30, 2020 6:19 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: stable@dpdk.org; Xing, Beilei ; >> maxime.leroy@6wind.com; Kevin Traynor >> Subject: Re: [dpdk-stable] [PATCH v4 2/3] doc: input set requirement of each >> pctype for FDIR >> >> On 4/30/2020 1:52 AM, Zhao1, Wei wrote: >>> Hi, >>> >>> >>>> -----Original Message----- >>>> From: Yigit, Ferruh >>>> Sent: Wednesday, April 29, 2020 6:35 PM >>>> To: Zhao1, Wei ; dev@dpdk.org >>>> Cc: stable@dpdk.org; Xing, Beilei ; >>>> maxime.leroy@6wind.com >>>> Subject: Re: [dpdk-stable] [PATCH v4 2/3] doc: input set requirement >>>> of each pctype for FDIR >>>> >>>> On 4/29/2020 3:03 AM, Wei Zhao wrote: >>>>> Add input set requirement info to i40e doc. >>>>> >>>>> Bugzilla ID: 403 >>>> >>>> Should this document update backported to the LTS? >>>> If so which LTS versions are in the scope, it is better if you can >>>> add a fixes tag to help us to figure out that. >>> >>> Maybe we can use this, it is the latest update for i40 doc. >>> Btw, this is not a bug although it is report in bug list. >>> >>> Fixes: 3d91e097a352 ("doc: add feature support matrix link in i40e >>> guide ") >> >> Hi Wei, >> >> I agree this is not bug, but this documents a limitation for users. And if this >> limitation is valid for the stable trees, it make sense to update documentation >> for those releases too, so that they can have correct/complete documentation. >> I will add the "stable@dpdk.org" tag to request the backport. >> >> But next question is for which stable trees is this limitation valid, it would be >> wrong to document a limitation that doesn't have the feature, how a stable >> tree maintainer can know if this issue is valid for a specific stable tree or not. >> For that we need the commit that introduces the mentioned feature (and the >> limitation), I don't think the commit above really is that commit, that is >> unrelated doc commit, but we need the commit for code. >> >> If you can provide correct fixes line, I will update it in the next-net. >> >> Thanks, >> ferruh >> >> >>> >>>> >>>>> Signed-off-by: Wei Zhao >>>>> --- >>>>> doc/guides/nics/i40e.rst | 7 +++++++ >>>>> 1 file changed, 7 insertions(+) >>>>> >>>>> diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst >>>>> index 416b3904e..f085a357c 100644 >>>>> --- a/doc/guides/nics/i40e.rst >>>>> +++ b/doc/guides/nics/i40e.rst >>>>> @@ -747,6 +747,13 @@ Use 16 Bytes RX Descriptor Size As i40e PMD >>>>> supports both 16 and 32 bytes RX descriptor sizes, and 16 bytes size >>>>> can >>>> provide helps to high performance of small packets. >>>>> Configuration of ``CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC`` in >>>>> config >>>> files can be changed to use 16 bytes size RX descriptors. >>>>> >>>>> +input set requirement of each pctype for FDIR >>>>> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>> + >>>>> +Each PCTYPE can only have one specific FDIR input set at one time. >>>>> +For example, if creating 2 rte_flow rules with different input set >>>>> +for one PCTYPE, it is will fail and return the info "Conflict with >>>>> +the first rule's >>>> input set", which means the current rule's input set is conflict with >>>> the first rule's. Remove the first rule if want to change the input set of the >> PCTYPE. >>>>> + >>>>> Example of getting best performance with l3fwd example >>>>> ------------------------------------------------------ >>>>> >>>>> >>> >