* [dpdk-dev] [PATCH] net/avp: fix interrupt migration check
@ 2017-04-28 6:49 Ferruh Yigit
2017-04-28 10:52 ` Legacy, Allain
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2017-04-28 6:49 UTC (permalink / raw)
To: Allain Legacy; +Cc: dev, Ferruh Yigit
Bitwise OR within if statement is always true, fix bitwise operator.
Coverity issue: 1423906
Fixes: 82e140b84995 ("net/avp: handle interrupt migration")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/avp/avp_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index 9ca2786..fe6849f 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -712,7 +712,7 @@ avp_dev_interrupt_handler(void *data)
RTE_PTR_ADD(registers,
RTE_AVP_INTERRUPT_STATUS_OFFSET));
- if (status | RTE_AVP_MIGRATION_INTERRUPT_MASK) {
+ if (status & RTE_AVP_MIGRATION_INTERRUPT_MASK) {
/* handle interrupt based on current status */
value = AVP_READ32(
RTE_PTR_ADD(registers,
--
2.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/avp: fix interrupt migration check
2017-04-28 6:49 [dpdk-dev] [PATCH] net/avp: fix interrupt migration check Ferruh Yigit
@ 2017-04-28 10:52 ` Legacy, Allain
2017-04-28 12:47 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Legacy, Allain @ 2017-04-28 10:52 UTC (permalink / raw)
To: YIGIT, FERRUH, Peters, Matt; +Cc: dev, YIGIT, FERRUH
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Friday, April 28, 2017 2:49 AM
> To: Peters, Matt
> Cc: dev@dpdk.org; YIGIT, FERRUH
> Subject: [PATCH] net/avp: fix interrupt migration check
>
> Bitwise OR within if statement is always true, fix bitwise operator.
>
> Coverity issue: 1423906
> Fixes: 82e140b84995 ("net/avp: handle interrupt migration")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Thanks for catching this.
Acked-by: Allain Legacy <allain.legacy@windriver.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/avp: fix interrupt migration check
2017-04-28 10:52 ` Legacy, Allain
@ 2017-04-28 12:47 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-04-28 12:47 UTC (permalink / raw)
To: Legacy, Allain, Peters, Matt; +Cc: dev
On 4/28/2017 11:52 AM, Legacy, Allain wrote:
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Friday, April 28, 2017 2:49 AM
>> To: Peters, Matt
>> Cc: dev@dpdk.org; YIGIT, FERRUH
>> Subject: [PATCH] net/avp: fix interrupt migration check
>>
>> Bitwise OR within if statement is always true, fix bitwise operator.
>>
>> Coverity issue: 1423906
>> Fixes: 82e140b84995 ("net/avp: handle interrupt migration")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Allain Legacy <allain.legacy@windriver.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-28 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-28 6:49 [dpdk-dev] [PATCH] net/avp: fix interrupt migration check Ferruh Yigit
2017-04-28 10:52 ` Legacy, Allain
2017-04-28 12:47 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).