From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B81DCA034F; Tue, 1 Mar 2022 07:32:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CDA740DF6; Tue, 1 Mar 2022 07:32:10 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 0CE98407FF for ; Tue, 1 Mar 2022 07:32:08 +0100 (CET) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K76n53fg2zBrRY; Tue, 1 Mar 2022 14:30:17 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.21; Tue, 1 Mar 2022 14:32:05 +0800 Subject: Re: [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion To: Ferruh Yigit , CC: References: <20220228032146.37407-1-humin29@huawei.com> <20220228032146.37407-5-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: Date: Tue, 1 Mar 2022 14:32:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Ferruh, 在 2022/3/1 1:09, Ferruh Yigit 写道: > On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: >> @@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter >> *hns) >>               return 0; >>           wait_data->check_completion = NULL; >> -        wait_data->interval = 1 * MSEC_PER_SEC * USEC_PER_MSEC; >> +        wait_data->interval = >> +        HNS3_WAIT_PF_RESET_READY_TIME * MSEC_PER_SEC * USEC_PER_MSEC; > > Can you please fix the syntax? > I guess all can fit into single line... If not so, the code in single line will exceed 80 characters. > .