From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <akhil.goyal@nxp.com> Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20089.outbound.protection.outlook.com [40.107.2.89]) by dpdk.org (Postfix) with ESMTP id 429511B39A for <dev@dpdk.org>; Fri, 12 Oct 2018 13:40:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+k3iRWBzX5jkhWEkPdOXuVE6D41EAn9BvGtPOyatZNc=; b=JgHvsSEq0JAP2xUWV4QgPzXTFk0x2a0N45uxrFBoPGe3XQnTr+6HZJsPeMK6ozeHLHmiT6gbF5K1DBh+nuzYD0PZZVpgkHdo0TPaVkifJfA67QN6THhw5KT/ojU67m0BiDpC88Rf1U7rsAvxwU6h9EAZf5LCOwVsOGnPcfy60+I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by VI1PR04MB4896.eurprd04.prod.outlook.com (2603:10a6:803:56::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.21; Fri, 12 Oct 2018 11:40:06 +0000 To: "Trahe, Fiona" <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com> References: <1532108791-20683-1-git-send-email-fiona.trahe@intel.com> <1538756310-13472-1-git-send-email-fiona.trahe@intel.com> <ed108959-ba77-1d8f-0e23-155bd547f870@nxp.com> <348A99DA5F5B7549AA880327E580B43589646AF8@IRSMSX101.ger.corp.intel.com> From: Akhil Goyal <akhil.goyal@nxp.com> Message-ID: <c3bc7031-7cd9-c020-3ace-0f6ab7e7debf@nxp.com> Date: Fri, 12 Oct 2018 17:09:49 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <348A99DA5F5B7549AA880327E580B43589646AF8@IRSMSX101.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BMXPR01CA0041.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::27) To VI1PR04MB4896.eurprd04.prod.outlook.com (2603:10a6:803:56::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0a37701-d56e-49db-ae7c-08d630377562 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB4896; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4896; 3:HK/lMqWQXULWlmcZpqD5+OVVnNurcWks4zdIHiQzXj/5G5Uq3LXIhdyQq3N/2Y7FlAV9t7zNKVbudZu+4P3O71Kut4U/t/rRinIkKY3T2SMrgij1zhM/X1QKzEhqmgbW0bD9aoiX1ZlxIhsQPPiWBWG8eWm9Qzg4FtCsGsSrsC7IBRZZtomGerrnmDcfHKJc36wy30N70E3P913pxr6dgkkB2agtZB7A7JQ/T+FmYLhGTJtzCibwyTpbxIBy1Hfn; 25:qEkMgOZl6oEDiu/fs/i9RXyVte++RD/eiGBDNOS6LEAm3L9kq9g2Yk4VI3UN+0W/qGpRroUHhRYMic9qF5slwunXXv2EWVjphLt0mp+as14bSustxKEEzK7HE1iY1t4h3jECLFL7feejcWQbumrOxuy+Gz1hzpJYaMW19/sF52X5R111HgUvkkO/jWv/P3/Qf2XzVWG4dNtUe83vKm3SekEQ4qm2cnkXZCaoiWFYb7LvSSfJoOi1NcrSPv3rADL/mDPlF2bGigqjirwQ1kKXF5NMcJ/DInodS1mccI/dqTnZ+OhS6D/0epaDT8M7DWVfiNhp2kpw31abEuRZRBb5OA==; 31:gt7uUewJ4CsOx9LbwrclspFo1c0r6IxTbX2DfA1FIKAUE75LfgEnqHekIgJWTIWiPVo2HnJPfrw+qp2EFNBLUYIVMgtxVQbOOIBjfG/urOuQFMS1ANL3sRiXAoAkFpT9i/Gp0vcfMTnb3RAJK1O7C+6+2LZUtbzGzkNRCvsDVSKBsHr5R0qMHSiQoDq2Peq7hsflSS8wx9o8gR7OxxcJ5isuGOf2MqfT7E0ba8ccE9g= X-MS-TrafficTypeDiagnostic: VI1PR04MB4896: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4896; 20:Uclh7jyY4bfCidYg8hBV/OIVIzJdyYn+rTTZfC8aWvFvz8RnuiYnvJfFhmQpJ0c9vTZLR2m7hmKcnl9e24y4/wcc4brCM0arjibR7Y50EOln4mje3lGUK1BzJpeA7vsRz36qEDmhw0bBFsJXLVS7JM6mjvdVLNJ1B3qC0TB6pDAUDAXELEvBdyR2ZrzInho6TObnV1V1hXCosIQ5ofpVtNu/opxvOjc5NFf9XvnoEQPgMMq3IuPPHFLswnLtjJpnv5cjSk7R/cBffJ6ARCbTCec7Qn2yJ4T/pa2lrBC/vRWW2CgGxfytf6GpQzicsoKwcx/bNDcZ0yaSyi+YviitWgKKfi9YQHikKGPBdPGfA9v4+YKaMjbhOmzYBwVGpgxFHN51FWXsZ/buCrwSMgwzucwl5leHYivyCbHlHjDCAHq62Y4Wwb/kJznEl6DlrioGKmDUWGAn7/qoNVcFrM/s90jnLNnbm1ewYfeks5nAKa5jfDyj/6DujqTp5f2NY35Q; 4:C8d4IcLZkzsFzm9wVyNFMHtGbdOCrwnNCpBgV+SGuSmTRdSWKL92gBNZM7aie6mWOoUM2uJ8yOKzk+e4GycEhd0XsYz0mRMLp9ocbGacf8Yz457ldtLDwKJEjFd5uTjSJdEWe8FcgBSJ5A2UnSdzV+J+hbqhFn6SITInNqXLDXaaGaVjYEWx3ifmlwkKrxpRLk3ab0C7bWSbB8ch+hBYNnpDcI3afk64gsq6HoCLNWrtbOPjRwgfwnSK9QyQVsoEuKZ51Z2IOlpIjSlHvuZYDnJlp2dggWOr2XbDQZVOkHH9PMv+O8J3Q2Uj2umwUcGIHawPx/sZuPnVdLg1ftXsYVH1mT2VBXlp8dPc5CvDglY= X-Microsoft-Antispam-PRVS: <VI1PR04MB48963E10EB68787FC3427E8EE6E20@VI1PR04MB4896.eurprd04.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(201708071742011)(7699051)(76991067); SRVR:VI1PR04MB4896; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB4896; X-Forefront-PRVS: 0823A5777B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(366004)(136003)(376002)(346002)(396003)(13464003)(199004)(189003)(43544003)(86362001)(65806001)(4326008)(64126003)(316002)(229853002)(486006)(97736004)(11346002)(110136005)(105586002)(956004)(7736002)(2616005)(476003)(386003)(446003)(305945005)(478600001)(106356001)(53546011)(55236004)(6246003)(16576012)(65956001)(966005)(5660300001)(36756003)(58126008)(44832011)(52116002)(93886005)(53936002)(66066001)(81166006)(2906002)(26005)(50466002)(230700001)(6306002)(8936002)(25786009)(186003)(6666004)(68736007)(81156014)(1006002)(77096007)(31686004)(16526019)(47776003)(67846002)(3846002)(6116002)(23676004)(2486003)(52146003)(2501003)(6486002)(76176011)(31696002)(8676002)(65826007)(3260700006)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4896; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0TUI0ODk2OzIzOmM4TUpjNDJkbjJhUER4Y3lUR2lEcEhjV1px?= =?utf-8?B?WU1sblBXemgySDRpcVFtbzNLSmMwWU44a3lSM29LZk5DN2dVcVkwMHpoSnU1?= =?utf-8?B?cjhmaGdyZzk4cy9nN1ZWQ2VSSnhWcXV6WWZoMit5U2FSUHFpZGdwQkpBUzBJ?= =?utf-8?B?RkMwamp2MUJlWGxvc2tUMVA2Y0xpaG8zVXNIWlpIcFl2RU1GNGZETkxZU2lF?= =?utf-8?B?VEpBUWkvbjJaenhIM1ZDVmI1cEpobVN6TXVUZktKSldhMlkyajRzbzMrb3lP?= =?utf-8?B?TUtRcVlCbVk2aHMyazZFUSs2aFUvYWRobUJHWUo4aXU3dDdjYW9hVUZEK0Vn?= =?utf-8?B?dnozcTljR2Y0Q3N2Z1h3d2NhcXVqeGsyZERCMHpxbmxGeXJmZGRSWlllbjZG?= =?utf-8?B?YkREU2lPVXpBNTE1emNUVHpkQ3A5ZGk2ZTZDaWpIV2xMalVldW1ubzhuWktS?= =?utf-8?B?eTVDNXZhUk4yMlJ6Y1RpNlY3aXRnSjlyUm1FWWlZdWdvWXBrOWUxcFYzUHJK?= =?utf-8?B?bHY3Zk1HK1VrSkRqREpXdmFkck44VkMxRlkxRTh1c3EyQ3BwSFNmWTFrcEo4?= =?utf-8?B?SkhFSHhqaWdkOWtKMk00dFArZHlZa1I0eDJXS2hyQ0VCSVU4VHdCYnhhSkxp?= =?utf-8?B?NDJUSEtrVVdWNUNySVAwb0Z6TGhvbmZQdElacHFXVCtpcm9panlSRWM3cEpk?= =?utf-8?B?SE56dlFieEJQb0JMR0J0RFlGMWZKZDRiNTJ0TFN5bVlEZWhjSVlzSmRwMVdt?= =?utf-8?B?Sk5OSks0QVdlQXh3VHFEVWw0M1g3S0tNRWsyc3dHMDBxVnJvZ0l4eGl4SXBC?= =?utf-8?B?Y093UXZCZXdCOFluOTVkSlBjT1VsU0t0SU9OMmRzd3U5Z0wra3Rtek1PSFZp?= =?utf-8?B?eDQvWi8rYnl1VUtXV3pPVXhhQnFzMXE4cWNnSUZSV3BucEUrNGs3YkhyYThJ?= =?utf-8?B?NHV0ZkZ6ekxHYmt5OFZlZklFK3BDY2VGNmtDODMxRG9IcUhpRHBkS2p0TGNX?= =?utf-8?B?MUNvTU1SNTNGZDJtRFppY2tYNjhUQnAxdFp5R0xLQzJyOFcySkN0YW5SMVJN?= =?utf-8?B?SHJxK1dvOWpkWCt1cWxSbmNYcHdaendMTjVWclN3SzRqY3lFWXFDS1MzeG1j?= =?utf-8?B?bHNpRlViSG40enJWZ3NyNFMyU00xZDNjOEVzMUgrZUllbllpQVlUMU1nN2Ju?= =?utf-8?B?Z1ZRR1NXUjZKNjh5MUdqbU93cDBsZWZoNFZYRUdwcUw0M1FwcFNqSlpKZVBV?= =?utf-8?B?VG5zVi9aeWdRZkEyeVE0VEg0cld6M0hxK3VzRVlMVzBYNWppQUhOdmMzODZy?= =?utf-8?B?L01XblVWRFN3Sm5uWFpRRTdTZDJRQlorczFaeTk3VEt2VDUySExKU2t0dHdZ?= =?utf-8?B?R2N3eFc2ZmFBZTZtYklTMmliYXF0dlAycXMraXFHZ2gvL1NJUEhES3ptQXQy?= =?utf-8?B?SVBYdUdGSHorL3hvYkdiOEVRdkM5YnFDYXQ0MmMyLzZZM002SVlmU3RkaTdL?= =?utf-8?B?MldyaEp3Z1MwdW96dFA3dUNhUTNScjVHZjVPMDdRZTlPWndGMEJyeSt6ajVI?= =?utf-8?B?VVYwRmxQUTZNTmo1MjhvS1ByVml5akFseXgrMUJxcmJPR25zWUJhUUx3N3o2?= =?utf-8?B?bCtVdllmVDJmYkVabE1uQm9DeGgxamFhWDhaV1RrclVzR3VxeWhRU2MwMVBu?= =?utf-8?B?L1NhKzV4YzYzNDR3SDlJN0ltSEhoR3pLQUxadFNUY2x5RUVnSFBKckphUk5T?= =?utf-8?B?MU1LZitweldRRnB2YmtuUkVpemVGOCtBbjBGbUg0cHhPNHhBYmNaZlptaTgz?= =?utf-8?B?aDJIbEcvMUNnRE5FQldJQlBacFZrUVhJaWh6bTZ6T3lIZmhsWGlqZmZ2dGNj?= =?utf-8?B?enEyNktjYWRFc3EvaVZzc2p6cjFVdXVycGJldG8vLzVUdHVOM0x5T1VJVEN6?= =?utf-8?B?di9uSzA4V3JXdnIvMzJUMW84TlVhR2RDeHM1Y3lUZ3dYejd4YmNJZE53a0FT?= =?utf-8?B?Q1ZMMGF0Y25pcmV3NVNkdlJ3WkovMGNNWWNxQnJ6dDJuTWlWdi95VGgzSXA3?= =?utf-8?B?d21oeG9wZmFTN1prSXEzSGI0TDlxMUFueXE4L0hPZWdsclpUZHNwVDlXeGRV?= =?utf-8?B?LzZOWXdqdzNMMzIvV1lYNGI3TnNkNk9yMm1HMHZDdmdyVkk1N1BrNUlpRWx6?= =?utf-8?B?a2pUZzFQWWFkNVU3SFpxMzBPVGM0Wm5WSU9uRzQ2ZklQTThBUHVUelhYWnFC?= =?utf-8?Q?+yqUfco5P60Nb4v46G?= X-Microsoft-Antispam-Message-Info: S+Ay+azzEmIikM33/X0cIdYRQ+6NrLz2Giak4vye7KkIwe8ZmnPMZFRznA8/CwKxSMkSsNKQeBHBJF84cvkWWd+lUnrtjrR0J+dxmGGQEuChNlocOp3CcW0UjN7DZsrvPkzlThghU2FfcF0pTGH5b18chtS0Nev90ULyu0XmrzFB1erHANlvbblLHHRdV4lt72rVubsnmGGl3ung2WDR1Cljp0oRwkG7TKS8xFcwi405kNJC+HLEhG9FJXkekIOhSzggv85LmXcxbWvpfIFP5flOeAXA0XrdEJT6ElmZ2MzzBx4sf0dMZL+avjMbsgns0bZZcy3zVVfyxrcGwtPp+DD0qI1/nAeGqTQt3Z6qifg= X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4896; 6:cWu1QkumLow2ZSZhK7Gu4RKW0u/wMxyESrWfnoIDQLO5Z6GyEyayfmnvWz3gJ8gHAPC7BY/jc+1FeutaWntFBdMCCUkhbmuCj1rYZ0r6imyeZphJgr7c1Iregk10wrPtzWiyo2Y9xp5SEXQu60x6kBjD2zfhFfjD+GorQgAd+jE9nLyrSFqYsBJ8YeNvV3Xi24OsCM/1Vk8hAiZiJa7d9Zy6dsIb2z4RBdKdx4ZQT3MoIxMRqVmfYkhh0ostoAG5V5s0Modf60UVYkgdFzrvwWEWRmHOyuC381LIInZIr4onvOcuwxa7xBPJDvs1W0Ud7ceo7qSv5pFkGM+wFF1gAqdAkIsTikkl7ohgAQ0apHhMLJnTO3lrVpFJVuyuDm3efMrSHOHcyDC+ZkATjXKoO/tOpfb2RC42O+TeOtA6MSXC2OiafpToQhMhMzmrRfJ+vLIIBejJ+vLbq1q2ke2WJQ==; 5:vvlGnn44uCVywsWd67Z77EKQCFaPircM7HnZfLrXPTcCOSEseNnFdeEizIaTjuqZlDZTrhUQ1eyElZhcI+rk1hLxqdzl7++vkqZ2IsiUJZQYq7+az5UyXxpebZO7l8vlz3cC95M1c/mBqW0i/eLphNj6ruiUJrvYF5OJS4+3ZQQ=; 7:x1ejFoExpUdWwLJ/CmiTUA8JirukScUlAygMIHCww4yKSEzxom9xzTXMOoTBdUZ/jAv/U0YSOILT0fZU0JFLYtqJxybhPJXCZXwbaC19gPUs9Dyag248AmP14Kb0I7pBw/eDQmV5CFk6xkd/vZxy6lH/dfACOs94+ryyDWtPsxQZ7ke9IWlSG2BiqeOG9WMOofdY7suJU6tQxaf2IjADdxbtEXAHilY3AEyAAw7tIbk6EBZvpwp8waJzRU8eChIb SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2018 11:40:06.2214 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0a37701-d56e-49db-ae7c-08d630377562 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4896 Subject: Re: [dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 12 Oct 2018 11:40:08 -0000 On 10/9/2018 7:39 PM, Trahe, Fiona wrote: > Hi Akhil, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Tuesday, October 9, 2018 12:02 PM >> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org >> Cc: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com> >> Subject: Re: [dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding >> >> >> >> On 10/5/2018 9:48 PM, Fiona Trahe wrote: >>> Enable dynamic huffman encoding in the QAT comp PMD. >>> >>> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com> >>> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com> >>> --- >>> v2 changes: >>> - allocate 2 buffers per intermediate buffer sgl >>> - Compile out trace for debugging intermediate buffers >>> >>> Depends on: >>> https://patches.dpdk.org/patch/45794/ >>> >> //snip >>> +#if 1 >>> + QAT_LOG(DEBUG, " : phys addr of sgl[%i] in array_of_pointers" >>> + "= %lx", i, array_of_pointers->pointer[i]); >>> + QAT_LOG(DEBUG, " : virt address of sgl[%i] = %p", i, sgl); >>> + QAT_LOG(DEBUG, " : sgl->buffers[0].addr = %lx, len=%d", >>> + sgl->buffers[0].addr, sgl->buffers[0].len); >>> + QAT_LOG(DEBUG, " : sgl->buffers[1].addr = %lx, len=%d", >>> + sgl->buffers[1].addr, sgl->buffers[1].len); >>> +#endif >>> + } >>> +#if 0 >>> + QAT_DP_HEXDUMP_LOG(DEBUG, "IM buffer memzone:", mz_start, 1504); >>> +#endif >> I believe #if 0 and #if 1 should be replaced with some debug macros, or >> else dynamic logging shall take care of that. > [Fiona] These are not on the data path, so I didn't think it appropriate to wrap with the DP log level compile option. > And they generate a lot of trace, so make it impossible to see the other debug trace enabled with > dynamic logging using level 8/DEBUG. Really a level 9 would be useful here, but I think this is overkill. > I could have removed this code, but it's handy for debugging. > How about if I add a local QAT define for it? > #define QAT_IM_BUFFER_DEBUG 0 > #if QAT_IM_BUFFER_DEBUG > ... > #endif I think local define would be better.