From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: "humin (Q)" <humin29@huawei.com>,
wangyunjian <wangyunjian@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "chas3@att.com" <chas3@att.com>,
Huangshaozhang <huangshaozhang@huawei.com>,
"jilei (F)" <jilei8@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: 答复: [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst
Date: Thu, 25 Aug 2022 17:39:19 +0100 [thread overview]
Message-ID: <c3bd6f50-6ee2-dab4-debc-0ec1be33a3f7@xilinx.com> (raw)
In-Reply-To: <5001c75008d9423c885747b51cb1ad55@huawei.com>
On 7/20/2022 2:28 AM, humin (Q) wrote:
> -----邮件原件-----
> 发件人: wangyunjian <wangyunjian@huawei.com>
> 发送时间: 2022年7月18日 21:09
> 收件人: dev@dpdk.org
> 抄送: chas3@att.com; humin (Q) <humin29@huawei.com>; Huangshaozhang <huangshaozhang@huawei.com>; jilei (F) <jilei8@huawei.com>; wangyunjian <wangyunjian@huawei.com>; stable@dpdk.org
> 主题: [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst
>
> In bond_ethdev_rx_burst() function, we check the validity of the 'active_slave' as this code:
> if (++active_slave == slave_count)
> active_slave = 0;
> However, the value of 'active_slave' maybe equal to 'slave_count', when a slave is down. This is wrong and it can cause buffer overflow.
> This patch fixes the issue by using '>=' instead of '=='.
>
> Fixes: e1110e977648 ("net/bonding: fix Rx slave fairness")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lei Ji <jilei8@huawei.com>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-08-25 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 6:43 [dpdk-dev] [PATCH] net/bonding:fix balance-xor link down stack overflow jilei
2021-08-10 7:50 ` Min Hu (Connor)
2022-05-20 15:33 ` Ferruh Yigit
2022-07-18 13:08 ` [dpdk-dev] [PATCH] net/bonding: fix array overflow in Rx burst Yunjian Wang
2022-07-20 1:28 ` 答复: " humin (Q)
2022-08-25 16:39 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3bd6f50-6ee2-dab4-debc-0ec1be33a3f7@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=huangshaozhang@huawei.com \
--cc=humin29@huawei.com \
--cc=jilei8@huawei.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).