From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8ADC6A052A; Wed, 27 Jan 2021 18:49:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 451EB141008; Wed, 27 Jan 2021 18:49:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 7B6C6141000 for ; Wed, 27 Jan 2021 18:49:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611769747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=InSZiQCb0PkxHM1iYSgm0XgFUUbQnK4a9OK1HH8XBeQ=; b=TF4xGzszjY9V+6vMJB9P+cV18IloDbeNuZchSSzwjs8WIqzfY50CnfKXRNY5KonoDySh9T 3g+Hz6dtbMBY9c/zWRY9mVe8gqHq0I53GJPf2u5Vqv0Wp07OwtFvw35hU1VPDd5q9bCEas SaNLuaqt7rhpF/KFho4t54qcHjEQBO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-600-ksQXsa11NjSAC6rARBCOKA-1; Wed, 27 Jan 2021 12:49:05 -0500 X-MC-Unique: ksQXsa11NjSAC6rARBCOKA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 761528030B4; Wed, 27 Jan 2021 17:48:59 +0000 (UTC) Received: from [10.36.110.31] (unknown [10.36.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA33C1002C26; Wed, 27 Jan 2021 17:48:35 +0000 (UTC) To: Bruce Richardson , dev@dpdk.org Cc: david.marchand@redhat.com, Chas Williams , "Min Hu (Connor)" , Reshma Pattan , Hemant Agrawal , Sachin Saxena , Nipun Gupta , Jerin Jacob , "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Konstantin Ananyev , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , David Christensen , Ruifeng Wang , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Ferruh Yigit , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , Long Li , Martin Spinler , Heinrich Kuhn , Tetsuya Mukawa , Harman Kalra , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Jiawen Wu , Jian Wang , Chenbo Xia , Yong Wang , Thomas Monjalon , Ori Kam References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-5-bruce.richardson@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 27 Jan 2021 18:48:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210127173330.1671341-5-bruce.richardson@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 4/8] ethdev: make driver-only headers private X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, On 1/27/21 6:33 PM, Bruce Richardson wrote: > |drivers/net/vhost/rte_eth_vhost.c | 4 ++-- > drivers/net/virtio/virtio_ethdev.c | 4 ++-- > drivers/net/virtio/virtio_pci.h | 2 +- drivers/net/virtio/virtio_rxtx.c > | 2 +- drivers/net/virtio/virtio_rxtx_simple.c | 2 +- > drivers/net/virtio/virtio_rxtx_simple_altivec.c | 2 +- > drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 +- > drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 +- > drivers/net/virtio/virtio_user_ethdev.c | 2 +-| Both the Virtio & Vhost looks good to me: Reviewed-by: Maxime Coquelin Note that you'll need to rebase, as my Virtio rework series just got merged by Ferruh on net-next main branch, and it conflict a bit. There are new files created, so you may want to look carefully! Thanks, Maxime