From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF7ACA0C46; Tue, 14 Sep 2021 11:34:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 422D04068F; Tue, 14 Sep 2021 11:34:47 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 637194003C for ; Tue, 14 Sep 2021 11:34:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10106"; a="209168145" X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="209168145" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2021 02:34:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,292,1624345200"; d="scan'208";a="470061162" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 14 Sep 2021 02:34:43 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 14 Sep 2021 02:34:43 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 14 Sep 2021 02:34:43 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 14 Sep 2021 02:34:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j2MQ0p6kpv5NPIQ+AJOMyHpfl6Wzlw7mLIxOmT3Uknj97wXdN/j6zTBC6+KjVITh1ARYHZxz/kAjbaUzg4SFTuaj/92BQeh3EkNlWQ9jjiv90rE/fR4XEqfeRPR8NCd9ADrDU8mUZIoAX0dfxqwGvVUG2NTUFZ8B/AqhLVAL6bzJOPdRDaSfwyw5FcEaaPvA3bi6+Mr7gWUmt1L+rE4UcnnX11VIn2Q6XxrSKE8xyBiz2M3GDjMCAX3UPk7Vw55Dg8uiFM81TVLIkJToUiF84lPSD9J7EkX8232ogktYHg+xFoWWH/c9OHX1XfJfeSkHCgUBIbrF3rCaPazhyTuYtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5YODm0bOq6DBAevDeZYDx3uoC2AlT4vNT0n1nDG30aY=; b=Sfosg5mJzHo+GWiENONKbxBlfhIg28XJo8zPlvnT583GwElbq4oKCtplXlxdI7DbjJooa6an1uzLwfrgJnqDkzcvEO0GocOF2RrEUcUL/y7bbQp75GcCfR1SRl3jKAwFsXWax/hmfGorq2xjadu+x67NUQAeNZqsrTeXL1yYDYBq7xJWR/j0UzCUJtXO3qkqmvBcbKJf24VPk8bItYuSJUV4X7SBp1OETXKvcsfsSR7yNAlq6maxBs91YbUaFjGtQ2H/QjWExQAuSEQVIs/x+kmMxr/XSDqXkX3vAICm1de+dZsZMPvrnDuoWZqAfnhGIk1hbUV64pr8sFyYEVtNlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5YODm0bOq6DBAevDeZYDx3uoC2AlT4vNT0n1nDG30aY=; b=xy2U4FgW/pJ+ilz6rXVfPKAya/KAPieSP2qPQWm7ro397oZuxVpq0wtVL1wI3j3iF1az8QWCFrpmS8aCoX+RjZKA+ecqgJOPkrgyuIATgpfHFy96zN1jGPaAAPqKv0KL/DeLr4dVpj9TKGZK6BY5bfj49PH8Mv63Fri4jZd+F+E= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 14 Sep 2021 09:34:41 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::513:57f8:360:23fc]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::513:57f8:360:23fc%8]) with mapi id 15.20.4500.018; Tue, 14 Sep 2021 09:34:41 +0000 To: Thomas Monjalon , Bruce Richardson , David Marchand CC: References: <20210909134511.18871-1-david.hunt@intel.com> <5148108.61zlV0aQVf@thomas> From: David Hunt Message-ID: Date: Tue, 14 Sep 2021 10:34:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <5148108.61zlV0aQVf@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: DU2PR04CA0004.eurprd04.prod.outlook.com (2603:10a6:10:3b::9) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 Received: from [10.4.11.161] (95.45.23.115) by DU2PR04CA0004.eurprd04.prod.outlook.com (2603:10a6:10:3b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16 via Frontend Transport; Tue, 14 Sep 2021 09:34:40 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c581ee6-c85e-4e8a-5742-08d97762e0dc X-MS-TrafficTypeDiagnostic: PH0PR11MB4984: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9OgLJms9HWI+WT/7jPkPZ9eYnbtyZiS463ulvQBy+1rmChGwf7QjeXmmNp5St1QYQ2hPddBbvXe/J8S+wLzFZf65/3bjZIEPB0eJkAPd9tN8134KAr9h7pX204MRsYd6ChDZhvmo4sT+8ZyTwIaUWtIKkN2HVL4Xd8NTJ5l2eSKkfq2sjBqB72cMLSBL64gSq+A3xPykdJH0nfS6C3phkBpgkUIj8h1CnWMhlb/AvvBgyFdjKCMEInSxyhJAbOWGrn2DBl5xQyG3VgQ9dFhIqrsfOLQM24gKyXj+hUnNQ32bYSp9r3lGNNZfKvoPCFst0/6wdKwfevvMzmfy5G2TVo+tCYNt2+HAlBDK5x2SmlDMK0lNT53M0867MOYXyjnKc+LZ3m/TzYfXACewacFRP/8f6jyGSEZbALQOnEP/drgQ45FRPQUWK6oA8RLKwVXf3U2lpBWPePVKIx1sjAnFu3HFZz2lrSrxm4WBonJ6MDlvlwZAolmt7DXomkePiXw8vHC2sU01/GPzlUUzl4IAFzAWA684/Jm6W0c9lN4/ewlcIpaWMq9dCI5AcDI7yLVrbOZMCSTPfXaA4pd73lPx9zsWhE+IqhU1CYn+WSso4MjVUe55YyUr8R4Z/GDgPtt9LCVx0janlOQzbg5IQ6hpELeV0IBbO0JdJweQA7XL0E36+q3D+goeTtn9xaAn7kUlKJSwws4c2S2uxVWQ/Xiq5AOVhg6i2HyBcqS0ADnwFQw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(366004)(396003)(136003)(6486002)(83380400001)(2616005)(4326008)(956004)(66476007)(66556008)(66946007)(478600001)(5660300002)(6666004)(316002)(2906002)(8936002)(36756003)(38100700002)(44832011)(31686004)(26005)(86362001)(8676002)(53546011)(110136005)(16576012)(31696002)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1RpUzVZeHJJaFR2V0VRcWVYWXNobVJpaFJQSWV0RVFTa0pzS1VadVhET2J2?= =?utf-8?B?M3JCcm9kRDgyNkRsVk55TGgvNTNJb1lXeThWWVduL3JKQWtaMjFZaFExSzZU?= =?utf-8?B?dmcvSUJrNUlSdTdaNncxWVVRUyttTmw2V0N2SHdUd3hkMFJnRFB3alQwYUxq?= =?utf-8?B?TEE5SEhYWTdRQTJpTFNhMjdOdEFpRysrMHJIZDMvUktFQXN5cFVlRXRlQUhm?= =?utf-8?B?Wm11Rk9tQ2xYV1RBalZNbkFUdDN5VXlaQmc5a3RXYWt2cG1rMXd5Q3o0V0Fr?= =?utf-8?B?d0k4ZFdyb08vM0VJQTAwSkk0ZTBCc1lSYVVPbW5EM2JEWldWUXJwUEo5SUhp?= =?utf-8?B?TXhVNTFBbE5DSWF6dTIrMmpDNm00UVJWQVJSa1FsdUFKNlN6bUZ1RXZaK0ZV?= =?utf-8?B?QXBXU2Q4TGVJYTBiTkZiQ0VLQnNmdnkyOWtoRmFaQ2wwNzUvMWdxd3B4aVBH?= =?utf-8?B?ZHMrVEoyemFqVjAyaHVsWi9nT1B5SEk4WU9QYzJNS3hWclhhVjlhbXNjWHE1?= =?utf-8?B?Ni9CMm5aSHVSMTVrM0dZZVhKRnRNTnFkZ0pzZ0FraDdFMWZUNjVaTG1wNG5x?= =?utf-8?B?bEZOaDRjZjkwWVZIWHZ6TG53WWp1Q1RxelFwWWtVMElHYko2ZzMwUmowb25m?= =?utf-8?B?N2xqNUpRSEFZSDcrSzlPL2ozRFcvNE1DK1lWaFFiQktVZUd6dmFvQzZsNFc1?= =?utf-8?B?ZHFXYVE4eEdXZmE5Z3p4ckxqL215Tk03VEN1dUlXSDRPR01Fd1dJMWE0L3hG?= =?utf-8?B?N1ptZDVwWHNZU0NkbWtwOWV0OUkxa2UyQVVHcEU4ajdJeGFNVVR1UURNTzVj?= =?utf-8?B?aCt4WFdPWWdxeHY4OGJuMFhsRnVnQVhEbHVab2dVK1BjUzhHc3U0dE5qWHMx?= =?utf-8?B?ZW1wSGk0cldjeEhBelBFZ1dENU5NTzhRM205REQ4T3hUek1yOWp6Nnl3NFZk?= =?utf-8?B?OU1DNXNzaVhVN2Q2ZSt5OXo1SmFzanE3L3kyZWc5TFR5WUlZWGxzSzcvcklZ?= =?utf-8?B?YWdYS3JJOFVaaFdIQ0w3UHdNWHh1RFpNRVpJNXFFazRtU2VySzJkQndyVFdH?= =?utf-8?B?MXpGakdkZHFFVjJkZytNbmNxZGljK0U0SFJoMFhnN3p6b1JYRGtGQmhOUjdu?= =?utf-8?B?RzY4MlJ5MzU1ODg3UDRtYU40MUcxalJEZjJieHlnRkxZaEEwbHU0eTB4REdZ?= =?utf-8?B?WHF0WEsvWk9WejNxS1dGRTlpOWs2Vkt4R2FXVnNEWERBRk9kNGRSVWY5cEZT?= =?utf-8?B?NEdwRytZWUJnSHZmais4WnRlSTRNTW5YMi9kZ3dqUVJIbjJPM2I3QkprYTJt?= =?utf-8?B?ZlgvaDZyOTMwSFUyc0RRZEJOQTFFMmtWQVBTMXBKem1NUFM1Z0dBRW13RU16?= =?utf-8?B?OUx5QzVubzIwRFJ6KzVxQ1JEYVNrWHlFTWhiZEc4djBzWndCRlN6MHlZVXcx?= =?utf-8?B?WUxpK2FoZVA4MjEwalkzUGtibUZJOUNGNFFpSENuME10a3UzSU5iNitqYUFZ?= =?utf-8?B?YWljb1Q2cmZSTWFVc0NiejJRcldZUmxQNW5zRDN2dkw0azV2WWVhUFpkV2N1?= =?utf-8?B?L3g0TWpqUzlVWUZac3pGWkhWUHVuZFNpdXdmdmpsTzczY3p1VERiQUJvZk1s?= =?utf-8?B?SVRLMldMVXVOdUhMbGdIcDYwMlJDS01pNFhPSkI0VFFCTlcxbVNzUU8yV1ZU?= =?utf-8?B?WkMxbnNXNWdMOXFwSCttRWE3YTV2ZW0wTWZOdzVTK0JFU1lYcnlwOG1GbTRT?= =?utf-8?Q?ISDI6oA72WvkVE1REqCIfHFF1/oaNKYubsICLn7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4c581ee6-c85e-4e8a-5742-08d97762e0dc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 09:34:41.5082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lTHVi4e0QHx029y8ZPYcZkoRLNel0aQb1X9Za+2c5pH+hC492WAqeuHdkUjVVk1+S51qgKye11Od7rpelWeqOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/9/2021 9:24 AM, Thomas Monjalon wrote: > 10/09/2021 10:06, David Marchand: >> On Fri, Sep 10, 2021 at 9:54 AM Bruce Richardson >> wrote: >>> On Fri, Sep 10, 2021 at 08:51:04AM +0200, David Marchand wrote: >>>> On Thu, Sep 9, 2021 at 4:38 PM Bruce Richardson >>>> wrote: >>>>> On Thu, Sep 09, 2021 at 02:45:06PM +0100, David Hunt wrote: >>>>>> Modern processors are coming with an ever increasing number of cores, >>>>>> and 128 does not seem like a sensible max limit any more, especially >>>>>> when you consider multi-socket systems with Hyper-Threading enabled. >>>>>> >>>>>> This patch increases max_lcores default from 128 to 512. >>>>>> >>>>>> Signed-off-by: David Hunt >>>> Why should we need this? >>>> >>>> --lcores makes it possible to pin 128 lcores to any physical core on >>>> your system. >>>> And for applications that have their own thread management, they can >>>> pin thread, then use rte_thread_register. >>>> >>>> Do you have applications that require more than 128 lcores? >>>> >>> The trouble is that using the --lcores syntax for mapping high core numbers >>> to low lcore ids is much more awkward to use. Every case of DPDK use I've >>> seen uses -c with a coremask, or -l with just giving a few core numbers on >>> it. This simple scheme won't work with core numbers greater than 128, and >>> there are already systems available with more than that number of cores. >>> >>> Apart from the memory footprint issues - which this patch is already making >>> a good start in addressing, why would we not increase the default >>> max_lcores to that seen on real systems? >> The memory footprint is a major issue to me, and reserving all those >> lcores won't be needed in any system. >> We will also have to decide on a "640k ought to be enough" value to >> avoid ABI issue with the next processor that comes out and has more >> than 512 cores. >> >> Could we wire the -c / -l options to --lcores behavior ? >> It breaks the 1:1 lcore/physical core assumption, but it solves your >> usability issue. > Why would we change existing options while we already have an option > (--lcores) which solves the issue above? > I think the only issue is to educate users. > Is there something to improve in the documentation? > Hi all, I agree that it’s a good idea to switch to using the “--lcrores” option for cores above the default, that’s already future proofed. However, I’m still a little concerned about usability, if our users are accustomed to the “-c” and “-l” options, I suggest that we add a warning to suggest using the “--lcores” option if any of the cores provided on the command line are above RTE_MAX_LCORE. That would help them with the solution to using physical cores above 128 (or whatever the compiled default is). Example: “ERROR: logical core 212 is above the maximum lcore number permitted. Please use the --lcores option to map lcores onto physical cores, e.g. --lcores="(0-3)@(212-215).” I’ll replace the first patch in the set with a patch that adds the additional information in the error message. Thanks, Dave.