From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F531A0C43; Tue, 19 Oct 2021 11:23:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EB7140142; Tue, 19 Oct 2021 11:23:09 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 50E844003E for ; Tue, 19 Oct 2021 11:23:08 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E08E07F56B; Tue, 19 Oct 2021 12:23:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E08E07F56B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634635387; bh=TeVHjEzgPMFO5KaFsokqR23xyhe/sZTkj2+QOBzJwLM=; h=Subject:From:To:Cc:References:Date:In-Reply-To; b=BBMYXdOeLUDB2X+Bp3cYvD1bHSqzhXx334o1oyKblZfifh19smb/98ByaaseuiXGD ggI+bWaaUTDLOEkVBekzcdUfPKiR4usLADXBLRdDo4nYsVsUBmXRFVA8w7PIHDix/u hCc+Tbv0LFOe5U68JLeICc9eh5s2+6jrk2vujv/w= From: Andrew Rybchenko To: David Marchand Cc: Olivier Matz , Ray Kinsella , "Artem V. Andreev" , Ashwin Sekhar T K , Pavan Nikhilesh , Hemant Agrawal , Sachin Saxena , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , dev , Thomas Monjalon References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211018144907.1145028-6-andrew.rybchenko@oktetlabs.ru> <86905833-5c40-76ce-3794-ec3c2e447242@oktetlabs.ru> Organization: OKTET Labs Message-ID: Date: Tue, 19 Oct 2021 12:23:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <86905833-5c40-76ce-3794-ec3c2e447242@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 5/6] mempool: add namespace to driver register macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/21 12:04 PM, Andrew Rybchenko wrote: > On 10/19/21 11:49 AM, David Marchand wrote: >> On Mon, Oct 18, 2021 at 4:50 PM Andrew Rybchenko >> wrote: >>> >>> Add RTE_ prefix to macro used to register mempool driver. >>> The old one is still available but deprecated. >> >> ODP seems to use its own mempools. >> >> $ git grep-all -w MEMPOOL_REGISTER_OPS >> OpenDataplane/platform/linux-generic/pktio/dpdk.c:MEMPOOL_REGISTER_OPS(odp_pool_ops); >> >> I'd say it counts as a driver macro. >> If so, we could hide it in a driver-only header, along with >> rte_mempool_register_ops getting marked as internal. >> >> $ git grep-all -w rte_mempool_register_ops >> FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); >> FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); > > Do I understand correctly that it is required to remove it from > stable ABI/API, but still allow external SW to use it? > > Should I add one more patch to the series? > I'm afraid not now. It is too invasive or too illogical. Basically it should more rte_mempool_ops to the header as well, but it is heavily used by inline functions in rte_mempool.h. Of course, it is possible to move just register API to the mempool_driver.h header, but value of such changes is not really big.