From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CCEFF2C37 for ; Fri, 30 Jun 2017 19:47:16 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2017 10:47:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,287,1496127600"; d="scan'208";a="103249747" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 30 Jun 2017 10:47:12 -0700 To: Adrien Mazarguil Cc: Nelio Laranjeiro , dev@dpdk.org References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com> From: Ferruh Yigit Message-ID: Date: Fri, 30 Jun 2017 18:47:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx: update C compliance standard X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 17:47:17 -0000 On 6/30/2017 6:19 PM, Adrien Mazarguil wrote: > This commit addresses a compilation issue against Glibc >= 2.25, which > implements assert() through a nonstandard ({ }) construct. Such constructs > can normally not be used without __extension__ keyword when -pedantic is > enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode. > > While assert.h checks for the compiler ability to support GNU extensions, > Clang, unlike GCC, does not allow the above syntax when combining > -std=gnu99 with -pedantic. > > Work around missing keyword by moving these PMDs to a stricter compliance > standard without GNU extensions but properly checked by Glibc. Doing so is > supported on the DPDK side since includes have been cleaned up. > > Signed-off-by: Adrien Mazarguil Applied to dpdk-next-net/master, thanks.