From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 94766A00C3;
	Thu, 21 Apr 2022 08:49:12 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 31F71410FB;
	Thu, 21 Apr 2022 08:49:12 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id B5C56410E1
 for <dev@dpdk.org>; Thu, 21 Apr 2022 08:49:09 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id A869491;
 Thu, 21 Apr 2022 09:49:08 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru A869491
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1650523748;
 bh=9bz6b0eeBzAtie8wAPoAZ1ibRkX4U72Q131d2moQUcc=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=k8OGz5jjMmWcQcTCn8dlvHHpRqe928VJxg6eCSkZD0Hkvil2js9djK2VBEFyjTZCO
 XAYOIk4Vwwvd2pVfKVzcER8cUvvDbTKsivHIfSlT9Uj8yv0pz0FnbN27kt7i9tCAve
 t2N1lKJFxY45wnHCUBSyvk2MopeAH0MwvKh9Nqx4=
Message-ID: <c3ebf4d9-aa2a-1dd5-4377-e06c7d56e7d1@oktetlabs.ru>
Date: Thu, 21 Apr 2022 09:49:08 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 1/3] ethdev: fix telemetry xstats return null with some
 PMDs
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>,
 Chengwen Feng <fengchengwen@huawei.com>
Cc: thomas@monjalon.net, ferruh.yigit@xilinx.com, ndabilpuram@marvell.com,
 kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com,
 dev@dpdk.org
References: <20220416010747.40714-1-fengchengwen@huawei.com>
 <20220416010747.40714-2-fengchengwen@huawei.com>
 <20220415183831.2473346b@hermes.local>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220415183831.2473346b@hermes.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 4/16/22 04:38, Stephen Hemminger wrote:
> On Sat, 16 Apr 2022 09:07:45 +0800
> Chengwen Feng <fengchengwen@huawei.com> wrote:
> 
>> Currently the telemetry xstats uses rte_eth_xstats_get() to retrieve
>> the number of elements. But the value to be returned when the parameter
>> 'xstats' is NULL is not specified, some PMDs (eg. hns3/ipn3ke/mvpp2/
>> axgbe) return zero while others return the required number of elements.
> 
> Lets fix the PMD's this impacts other code as well.

+1