DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Junfeng Guo <junfeng.guo@intel.com>,
	qi.z.zhang@intel.com, jingjing.wu@intel.com,
	beilei.xing@intel.com
Cc: dev@dpdk.org, Rushil Gupta <rushilg@google.com>,
	Joshua Washington <joshwash@google.com>,
	Jeroen de Borst <jeroendb@google.com>
Subject: Re: [PATCH 1/2] net/gve: switch copyright from MIT to BSD-3
Date: Tue, 28 Mar 2023 09:55:25 +0100	[thread overview]
Message-ID: <c40e99fe-bcda-8363-f31c-8900cec8407b@amd.com> (raw)
In-Reply-To: <20230328020826.1269570-2-junfeng.guo@intel.com>

On 3/28/2023 3:08 AM, Junfeng Guo wrote:
> Switch copyright from MIT to BSD-3 for GVE base code.
> In the meantime, remove MIT license exception for GVE driver.
> Also update the maintainers for GVE driver.
> 

I guess you are switching 'license' from MIT to BSD-3, not copyright.
Copyright holder is still Google/Intel etc..

Can you please update patch title & commit log accordingly?

> Signed-off-by: Rushil Gupta <rushilg@google.com>
> Signed-off-by: Joshua Washington <joshwash@google.com>
> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
> Signed-off-by: Jeroen de Borst <jeroendb@google.com>

<...>

> diff --git a/drivers/net/gve/base/gve.h b/drivers/net/gve/base/gve.h
> index 2dc4507acb..ac0fc1472e 100644
> --- a/drivers/net/gve/base/gve.h
> +++ b/drivers/net/gve/base/gve.h
> @@ -1,6 +1,32 @@
> -/* SPDX-License-Identifier: MIT
> - * Google Virtual Ethernet (gve) driver
> - * Copyright (C) 2015-2022 Google, Inc.
> +/*
> + * SPDX-License-Identifier: BSD-3-Clause
> + *
> + * Copyright (c) 2022-2023 Google LLC
> + *
> + * Redistribution and use in source and binary forms, with or without modification,
> + * are permitted provided that the following conditions are met:
> + *
> + * 1. Redistributions of source code must retain the above copyright notice, this
> + *    list of conditions and the following disclaimer.
> + *
> + * 2. Redistributions in binary form must reproduce the above copyright notice,
> + *    this list of conditions and the following disclaimer in the documentation
> + *    and/or other materials provided with the distribution.
> + *
> + * 3. Neither the name of the copyright holder nor the names of its contributors
> + *    may be used to endorse or promote products derived from this software without
> + *    specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
> + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
> + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR
> + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
> + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>   */

Why not using SPDX tag for new BSD-3 License, but add whole license to
the files? We have SPDX tag to prevent this.


  parent reply	other threads:[~2023-03-28  8:55 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  2:08 [PATCH 0/2] update license and copyright Junfeng Guo
2023-03-28  2:08 ` [PATCH 1/2] net/gve: switch copyright from MIT to BSD-3 Junfeng Guo
2023-03-28  8:51   ` Ferruh Yigit
2023-03-28  8:57     ` Guo, Junfeng
2023-03-28  8:55   ` Ferruh Yigit [this message]
2023-03-28  9:06     ` Guo, Junfeng
2023-03-28  9:09       ` Ferruh Yigit
2023-03-28  9:35         ` Guo, Junfeng
2023-03-28  2:08 ` [PATCH 2/2] net/gve: update copyright holders Junfeng Guo
2023-03-28  8:56   ` Ferruh Yigit
2023-03-28  9:35     ` Guo, Junfeng
2023-03-28 10:10       ` Ferruh Yigit
2023-03-29 14:07       ` Thomas Monjalon
2023-03-30  7:20         ` Guo, Junfeng
2023-03-30 13:14           ` Thomas Monjalon
2023-03-30 15:18             ` Rushil Gupta
2023-03-30 15:26             ` Rushil Gupta
2023-03-31  2:32             ` Guo, Junfeng
2023-03-28  9:28 ` [PATCH v2 0/3] update license and " Junfeng Guo
2023-03-28  9:28   ` [PATCH v2 1/3] net/gve: switch license from MIT to BSD-3 Junfeng Guo
2023-03-28  9:28   ` [PATCH v2 2/3] net/gve: update copyright holders Junfeng Guo
2023-03-28  9:28   ` [PATCH v2 3/3] net/gve: add maintainers for GVE Junfeng Guo
2023-03-28  9:45   ` [PATCH v3 0/3] update license and copyright holders Junfeng Guo
2023-03-28  9:45     ` [PATCH v3 1/3] net/gve: switch license from MIT to BSD-3 Junfeng Guo
2023-03-28 10:36       ` Ferruh Yigit
2023-03-29  2:35         ` Guo, Junfeng
2023-03-28  9:45     ` [PATCH v3 2/3] net/gve: update copyright holders Junfeng Guo
2023-03-28 10:37       ` Ferruh Yigit
2023-03-28 22:11         ` Rushil Gupta
2023-03-28  9:45     ` [PATCH v3 3/3] net/gve: add maintainers for GVE Junfeng Guo
2023-03-28 10:00       ` Guo, Junfeng
2023-03-28 10:34         ` Ferruh Yigit
2023-03-29  2:54           ` Guo, Junfeng
2023-03-29  2:26     ` [PATCH v4 0/3] update license and copyright holders Junfeng Guo
2023-03-29  2:27       ` [PATCH v4 1/3] net/gve: switch license from MIT to BSD-3 Junfeng Guo
2023-03-29  8:08         ` Ferruh Yigit
2023-03-29  2:27       ` [PATCH v4 2/3] net/gve: update copyright holders Junfeng Guo
2023-03-29  2:27       ` [PATCH v4 3/3] net/gve: add maintainers for GVE Junfeng Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c40e99fe-bcda-8363-f31c-8900cec8407b@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jeroendb@google.com \
    --cc=jingjing.wu@intel.com \
    --cc=joshwash@google.com \
    --cc=junfeng.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rushilg@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).