From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 6527B4C96 for ; Fri, 9 Nov 2018 11:42:56 +0100 (CET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181109104254euoutp02c4b5aa06137864470760fa14802b6c21~lbrXhGpSw2622026220euoutp02E for ; Fri, 9 Nov 2018 10:42:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181109104254euoutp02c4b5aa06137864470760fa14802b6c21~lbrXhGpSw2622026220euoutp02E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1541760174; bh=VuE7ZfmO7I5OOwOsuoM7TOVdoo2Z0ax9jLdt/dyk/K4=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=m3RGVyaYGtZDTDBZkfLbmqciCGnhmObiK49w8uPMCdUdTtHdhEEQUTymZAxd7xzlI v+RaVpOheSAPT7ukAraZgA8btHZxCqqW2msdSR3tguEPxafHQ2i2q0sGp05zJcX1lo sX4OKYBYgU2qDq2vuSKLMLwmzUhsJMkK7WaSMD/8= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181109104254eucas1p2cdace51587b8b097bd0a3e72397af3c3~lbrXFO2281423314233eucas1p23; Fri, 9 Nov 2018 10:42:54 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id B4.BB.04294.EA465EB5; Fri, 9 Nov 2018 10:42:54 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181109104253eucas1p1b60fccca0a181cc6bb974a3aea697748~lbrWSvI590652106521eucas1p1v; Fri, 9 Nov 2018 10:42:53 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181109104253eusmtrp275d0bcafde754c4e9cfcbaecfed0c097~lbrWCgefi1842118421eusmtrp2J; Fri, 9 Nov 2018 10:42:53 +0000 (GMT) X-AuditID: cbfec7f4-84fff700000010c6-3b-5be564aed8cc Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 77.E4.04128.DA465EB5; Fri, 9 Nov 2018 10:42:53 +0000 (GMT) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181109104252eusmtip1600e0c39b2cbc7484ff707ed4e1b0d54~lbrVQpei42594725947eusmtip1g; Fri, 9 Nov 2018 10:42:52 +0000 (GMT) To: Ophir Munk , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , "dev@dpdk.org" , Adrien Mazarguil Cc: Asaf Penso , Shahaf Shuler , Thomas Monjalon , Olga Shern , "stable@dpdk.org" , Ferruh Yigit From: Ilya Maximets Message-ID: Date: Fri, 9 Nov 2018 13:42:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1541756283-16251-1-git-send-email-ophirmu@mellanox.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDKsWRmVeSWpSXmKPExsWy7djP87rrUp5GG9xYwW7x8ssuNosP2yay WGxuFLZ492k7k8WdvafZLa60/2S3mLngM6PFnRm/mSwmTTnBaHF7jpfFv44/7BafHpxgsdh6 5i+jA6/Hxf47jB6/Fixl9Vi85yWTx7Pph5k8jt2cxu7Rt2UVYwBbFJdNSmpOZllqkb5dAlfG 6vWzWQuaWCve9aY1MDazdDFyckgImEhsn7KKqYuRi0NIYAWjxKm+x8wQzhdGicbvl1khnM+M El2bnzPBtHT0tjFCJJYzSuw82swG4XxklLjV0sPexcjBISxgKdHxyQUkLiLwiVFizg+QhVwc zAIPgebO6gHbziagI3Fq9RFGEJtXwE7i/e/trCA2i4CKRNfqTjBbVCBCouP+ajaIGkGJkzOf gPVyCrhKbHywEqyXWUBcounLSlYIW15i+9s5zBCnvmSXeLe3GsJ2kVjy7SQbhC0s8er4FnYI W0bi/875UK/VS9xveQn2moRAB6PE9EP/oBL2EltenwP7jFlAU2L9Ln2IsKPE9JUfwMISAnwS N94KQpzAJzFp23RmiDCvREebEES1isTvg8uhLpOSuPnuM/sERqVZSB6bheSZWUiemYWwdwEj yypG8dTS4tz01GKjvNRyveLE3OLSvHS95PzcTYzANHb63/EvOxh3/Uk6xCjAwajEwxtQ9yRa iDWxrLgy9xCjBAezkggvo+TTaCHelMTKqtSi/Pii0pzU4kOM0hwsSuK81QwPooUE0hNLUrNT UwtSi2CyTBycUg2MrnYBik+S5gowRf5dHCczyemEzYPTa/62Wew/v+iywmHVMM7yvBkZ+fPi u521L93xZ6zm9TMX2PH7f7WIxTb32km8y1gXWK74tJyj/kdpttUt+/Wn9I977rkuqbnrXI92 m0eZ51prS39evzy2Cxt1gv5MVHy5dWeHJKcBw83YZF3HXRtDHz1RYinOSDTUYi4qTgQAs6bj gl8DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsVy+t/xu7prU55GGzzt4rN4+WUXm8WHbRNZ LDY3Clu8+7SdyeLO3tPsFlfaf7JbzFzwmdHizozfTBaTppxgtLg9x8viX8cfdotPD06wWGw9 85fRgdfjYv8dRo9fC5ayeize85LJ49n0w0wex25OY/fo27KKMYAtSs+mKL+0JFUhI7+4xFYp 2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384mJTUnsyy1SN8uQS9j9frZrAVNrBXvetMaGJtZuhg5 OSQETCQ6etsYuxi5OIQEljJKzJ//mw0iISXx49cFVghbWOLPtS42iKL3jBKbTyxj72Lk4BAW sJTo+OQCEhcR+MQocXr3dCYQh1ngIaNE/6637CDdQgIuEnP+vQCbyiagI3Fq9RFGEJtXwE7i /e/tYBtYBFQkulZ3gtmiAhESZ1+ug6oRlDg58wnYqZwCrhIbH6wEizMLqEv8mXeJGcIWl2j6 spIVwpaX2P52DvMERqFZSNpnIWmZhaRlFpKWBYwsqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3 MQIjd9uxn1t2MHa9Cz7EKMDBqMTDu6LhSbQQa2JZcWXuIUYJDmYlEV5GyafRQrwpiZVVqUX5 8UWlOanFhxhNgZ6byCwlmpwPTCp5JfGGpobmFpaG5sbmxmYWSuK85w0qo4QE0hNLUrNTUwtS i2D6mDg4pRoYp4pOLhFwNFrwoszzT1maRTzrz++3AnXO/wmNU3u49nPej9rZzPINoUcyVL71 LwzKXGBjaJp55VG9QlKNtW6pwivvJb/EVeK4V0wyv9200yPOJjYu5OjXh/tLvzMkRLD4lm7m XOuxWbDwSl6YZF7H0lSpDUaSh7+27f6XmXWK38FsM1/n5wdKLMUZiYZazEXFiQDuIvB18gIA AA== X-CMS-MailID: 20181109104253eucas1p1b60fccca0a181cc6bb974a3aea697748 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181109104253eucas1p1b60fccca0a181cc6bb974a3aea697748 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181109104253eucas1p1b60fccca0a181cc6bb974a3aea697748 References: <1541756283-16251-1-git-send-email-ophirmu@mellanox.com> Subject: Re: [dpdk-dev] [v2] app/testpmd: revert setting default RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 10:42:56 -0000 On 09.11.2018 12:38, Ophir Munk wrote: > This reverts the patch that enables default RSS action by setting > key=NULL and key_len=0. > In current testpmd implementation a key pointer must exist if > key_len!=0. For example, the following flow rule will cause a > segmentation fault: > flow create 0 actions rss queues 0 1 end key_len 40 / end Maybe it's better to check that 'key_len' and 'key' passed both or none? BTW, is there any profit from the 'key_len' argument for testpmd? Can we just always use the size of the passed 'key' and drop the configurable from the user interface? Best regards, Ilya Maximets.