From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4561A0350; Fri, 8 May 2020 18:39:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E05A1D96B; Fri, 8 May 2020 18:39:27 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E02271D96A for ; Fri, 8 May 2020 18:39:25 +0200 (CEST) IronPort-SDR: VmVCNrSaoEsrKjJuYv7x2inS1BunM/pR2NyasfFqwxhX2MHQOogcZdw0j5Cha5MZ3l1keJkQlC VV1c+5ze1//w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 09:39:24 -0700 IronPort-SDR: PXVoqulWA5P/ObSX0A4enhbC1W8v3bKxbFkUsXTLOemibwBcaC27rhPUHrMOao4IugA6i9UcHT Zysz5y5tm71g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,368,1583222400"; d="scan'208";a="435823413" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.197.139]) ([10.213.197.139]) by orsmga005.jf.intel.com with ESMTP; 08 May 2020 09:39:22 -0700 From: Ferruh Yigit To: "Ananyev, Konstantin" , Jerin Jacob , Nithin Dabilpuram Cc: "dev@dpdk.org" , Thomas Monjalon , David Marchand References: <20200507120259.2197813-1-ferruh.yigit@intel.com> <20200507120259.2197813-2-ferruh.yigit@intel.com> Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Fri, 8 May 2020 17:39:21 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/3] mempool/octeontx2: fix build for gcc O1 optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/8/2020 5:20 PM, Ferruh Yigit wrote: > On 5/7/2020 3:05 PM, Ananyev, Konstantin wrote: >> Hi Ferruh, Jerin >> >>> Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using >>> gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2) >>> >>> Build error: >>> In file included from .../drivers/mempool/octeontx2/otx2_mempool.h:13, >>> from .../drivers/mempool/octeontx2/otx2_mempool_ops.c:8: >>> .../drivers/mempool/octeontx2/otx2_mempool_ops.c: >>> In function ‘otx2_npa_alloc’: >>> .../drivers/common/octeontx2/otx2_common.h:94:2: >>> error: ‘aura_handle’ may be used uninitialized in this function >>> [-Werror=maybe-uninitialized] >>> 94 | rte_log(RTE_LOG_DEBUG, otx2_logtype_ ## subsystem, \ >>> | ^~~~~~~ >>> .../drivers/mempool/octeontx2/otx2_mempool_ops.c:643:11: >>> note: ‘aura_handle’ was declared here >>> 643 | uint64_t aura_handle; >>> | ^~~~~~~~~~~ >>> >>> This looks like false positive, assigning an initial value to >>> 'aura_handle' to fix the build error. >>> >>> Signed-off-by: Ferruh Yigit >>> --- >>> This is assuming assigning initial value won't have a performance affect >>> if it does, we need to find another fix. >>> And overall not sure why this false positive warning is generated. >>> --- >>> drivers/mempool/octeontx2/otx2_mempool_ops.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempool/octeontx2/otx2_mempool_ops.c >>> index 162b7f01da..078ffac3e2 100644 >>> --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c >>> +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c >>> @@ -640,7 +640,7 @@ otx2_npa_alloc(struct rte_mempool *mp) >>> struct otx2_npa_lf *lf; >>> struct npa_aura_s aura; >>> struct npa_pool_s pool; >>> -uint64_t aura_handle; >>> +uint64_t aura_handle = 0; >>> size_t padding; >>> int rc; >>> >>> -- >> >> >> Confirm that it helps, though I am seeing one more issue with EXTRA_CFLAGS='-O1' (gcc 7.3.0). >> This time with drivers/event/octeontx2/otx2_evdev_stats.h: >> >> In file included from /local/kananye1/dpdk.2005.rngf1/drivers/event/octeontx2/ot >> x2_evdev.c:15:0: >> /local/kananye1/dpdk.2005.rngf1/drivers/event/octeontx2/otx2_evdev_stats.h: In function ‘otx2_sso_xstats_get’: >> /local/kananye1/dpdk.2005.rngf1/drivers/event/octeontx2/otx2_evdev_stats.h:124:9: error: ‘xstats’ may be used uninitialized in this function [-Werror=maybe-uninitialized] >> xstat = &xstats[ids[i] - start_offset]; >> ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> /local/kananye1/dpdk.2005.rngf1/drivers/event/octeontx2/otx2_evdev.c: At top level: >> cc1: error: unrecognized command line option ‘-Wno-address-of-packed-member’ [-Werror] >> cc1: all warnings being treated as errors >> >> As I can see xtstats is not set for RTE_EVENT_DEV_XSTATS_DEVICE case. >> Just to make gcc quiet, I added: >> --- a/drivers/event/octeontx2/otx2_evdev_stats.h >> +++ b/drivers/event/octeontx2/otx2_evdev_stats.h >> @@ -67,6 +67,7 @@ otx2_sso_xstats_get(const struct rte_eventdev *event_dev, >> >> switch (mode) { >> case RTE_EVENT_DEV_XSTATS_DEVICE: >> + xstats = NULL; >> break; >> case RTE_EVENT_DEV_XSTATS_PORT: >> if (queue_port_id >= (signed int)dev->nb_event_ports) >> >> Konstantin >> >> >> > Thanks Konstantin, > > I will make a v2 including above as you suggested. > Thinking twice, if compiler thinks 'xstats' may be used uninitialized, when is assigned to NULL it should complain about null pointer de-reference. Btw, this is also false positive, 'xstats_mode_count' prevents taking the loop and accessing to 'xstats'. Not sure what is the problem with "-O1" option ... But for the 'RTE_EVENT_DEV_XSTATS_DEVICE' case, the loop is skipped and functions returns '0', I will update as following to get more close to the intention, also this is less work for function. Can you please test below when I send the patch, I can't reproduce this? @@ -67,7 +67,7 @@ otx2_sso_xstats_get(const struct rte_eventdev *event_dev, switch (mode) { case RTE_EVENT_DEV_XSTATS_DEVICE: - break; + return 0; case RTE_EVENT_DEV_XSTATS_PORT: if (queue_port_id >= (signed int)dev->nb_event_ports) goto invalid_value;