From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Stephen Hemminger <stephen@networkplumber.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Dengdui Huang <huangdengdui@huawei.com>
Subject: Re: [PATCH] ethdev: rename functions checking queue validity
Date: Mon, 19 Jun 2023 12:41:33 +0300 [thread overview]
Message-ID: <c42fdc45-b5cb-72d2-30bd-aef3ca1908f3@oktetlabs.ru> (raw)
In-Reply-To: <20230614094446.0e5d6047@hermes.local>
On 6/14/23 19:44, Stephen Hemminger wrote:
> On Wed, 14 Jun 2023 17:20:59 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
>> Two functions helping to check Rx/Tx queues validity
>> were added in DPDK 23.07-rc1.
>> As the release is not closed, it is still time to rename.
>>
>> The name proposed originally
>> rte_eth_dev_is_valid_*xq
>> is consistent with this function:
>> rte_eth_dev_is_valid_port()
>> However, the suffixes "rxq" and "txq" are uncommon in ethdev functions.
>>
>> Also for shortness, many functions are dropping "_dev_"
>> as these functions which manage the queues:
>> rte_eth_*x_queue_info_get()
>> rte_eth_*x_queue_setup()
>> rte_eth_*x_hairpin_queue_setup
>> For completeness, there are some old functions having "_dev_":
>> rte_eth_dev_*x_queue_start()
>> rte_eth_dev_*x_queue_stop()
>> Anyway in all above examples, the subject is after the prefix,
>> and the verb is at the end.
>>
>> That's why I propose renaming into:
>> rte_eth_*x_queue_is_valid()
>>
>> Fixes: 7ea7e0cd3a08 ("ethdev: add functions to check queue validity")
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Shorter is better.
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
next prev parent reply other threads:[~2023-06-19 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 15:20 Thomas Monjalon
2023-06-14 15:39 ` Ferruh Yigit
2023-06-14 16:44 ` Stephen Hemminger
2023-06-19 9:41 ` Andrew Rybchenko [this message]
2023-06-20 15:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42fdc45-b5cb-72d2-30bd-aef3ca1908f3@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=huangdengdui@huawei.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).