From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5300B42CB2; Mon, 19 Jun 2023 11:41:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEF3D40DF8; Mon, 19 Jun 2023 11:41:36 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0B3B040A81 for ; Mon, 19 Jun 2023 11:41:36 +0200 (CEST) Received: from [192.168.1.40] (unknown [188.170.81.161]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9BFB750; Mon, 19 Jun 2023 12:41:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9BFB750 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1687167695; bh=HX6WGLcQt6rbYXOzzMIzj+h9a18OyYFUAfyw5fZn1Os=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=A/UCZgrCXPMPrYCdNdSUHsu29eJe7XJwQl0jAR0YL/y15iMk2AK0e1zmiOLqIQBsO DkqQE4NdEAEnrual02Al0HYxvOo2vtchuow4+ytbxZ3geAiXxA1w4aPHa43mc+s7+z j8VkNGqYaaiOjvOdm+XR8uKwq7l5kiqNW2q6LqqQ= Message-ID: Date: Mon, 19 Jun 2023 12:41:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] ethdev: rename functions checking queue validity Content-Language: en-US To: Stephen Hemminger , Thomas Monjalon Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Ferruh Yigit , Dengdui Huang References: <20230614152100.1664198-1-thomas@monjalon.net> <20230614094446.0e5d6047@hermes.local> From: Andrew Rybchenko In-Reply-To: <20230614094446.0e5d6047@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/14/23 19:44, Stephen Hemminger wrote: > On Wed, 14 Jun 2023 17:20:59 +0200 > Thomas Monjalon wrote: > >> Two functions helping to check Rx/Tx queues validity >> were added in DPDK 23.07-rc1. >> As the release is not closed, it is still time to rename. >> >> The name proposed originally >> rte_eth_dev_is_valid_*xq >> is consistent with this function: >> rte_eth_dev_is_valid_port() >> However, the suffixes "rxq" and "txq" are uncommon in ethdev functions. >> >> Also for shortness, many functions are dropping "_dev_" >> as these functions which manage the queues: >> rte_eth_*x_queue_info_get() >> rte_eth_*x_queue_setup() >> rte_eth_*x_hairpin_queue_setup >> For completeness, there are some old functions having "_dev_": >> rte_eth_dev_*x_queue_start() >> rte_eth_dev_*x_queue_stop() >> Anyway in all above examples, the subject is after the prefix, >> and the verb is at the end. >> >> That's why I propose renaming into: >> rte_eth_*x_queue_is_valid() >> >> Fixes: 7ea7e0cd3a08 ("ethdev: add functions to check queue validity") >> >> Signed-off-by: Thomas Monjalon > > Shorter is better. > Acked-by: Stephen Hemminger Acked-by: Andrew Rybchenko