From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 706645B34 for ; Mon, 24 Sep 2018 17:49:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 08:49:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,298,1534834800"; d="scan'208";a="91465113" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga004.fm.intel.com with ESMTP; 24 Sep 2018 08:49:24 -0700 To: Stephen Hemminger , dev@dpdk.org Cc: Stephen Hemminger References: <20180921165425.18168-1-stephen@networkplumber.org> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Mon, 24 Sep 2018 16:49:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180921165425.18168-1-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] netvsc: support multicast/promiscuous settings on VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 15:49:26 -0000 On 9/21/2018 5:54 PM, Stephen Hemminger wrote: > Provide API's to enable allmulticast and promiscuous in Netvsc PMD > with VF. This keeps the VF and PV path in sync. VF and PF? > > Signed-off-by: Stephen Hemminger > --- > Patch against dpdk-net-next > > drivers/net/netvsc/hn_ethdev.c | 14 +++++++++++++ > drivers/net/netvsc/hn_var.h | 9 +++++++++ > drivers/net/netvsc/hn_vf.c | 37 ++++++++++++++++++++++++++++++++++ > 3 files changed, 60 insertions(+) > > diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c > index b67cce1ba8f5..3092066ada36 100644 > --- a/drivers/net/netvsc/hn_ethdev.c > +++ b/drivers/net/netvsc/hn_ethdev.c > @@ -255,6 +255,7 @@ hn_dev_promiscuous_enable(struct rte_eth_dev *dev) > struct hn_data *hv = dev->data->dev_private; > > hn_rndis_set_rxfilter(hv, NDIS_PACKET_TYPE_PROMISCUOUS); > + hn_vf_promiscuous_enable(dev); This VF approach is confusing to me, is this calling a underlay device a VF device? <...> > +static int > +hn_dev_mc_addr_list(struct rte_eth_dev *dev, > + struct ether_addr *mc_addr_set, > + uint32_t nb_mc_addr) Just to double check, this dev_ops to add MAC multicast filters, to add MAC filters it is mac_addr_set, mac_addr_add, mac_addr_remove. Many HW seems can set the multicast MAC filters via "mac_addr_add" too. If this is the intention please enable "Multicast MAC filter" in netvsc.ini