From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1683BA0C43; Fri, 1 Oct 2021 00:13:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA67A4067A; Fri, 1 Oct 2021 00:13:51 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 5E05A40040 for ; Fri, 1 Oct 2021 00:13:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="225378694" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208,217";a="225378694" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 15:13:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208,217";a="520649834" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 30 Sep 2021 15:13:47 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 15:13:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 15:13:47 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 15:13:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UhFRfuNaXBheIKFNo7HkECcQTEglmXbQPloQEfdS3sn58qN3OC2l9TzHfIQZ79gpvvawrTND12vKR5nOmsVMRZfjGRQlt96R2bCisr3n6uBTS5gk2F7DJsG6sSpFPrZ5f086cLF9ULZazei6Cny8voWhW7nLzMjBy5EUdMv7X2eNxmMd2l2WXl6DFQMSFFV7JdrnUNj8t7h1HcMM2rJDiEyGRbRt71rTVBbTF32yEpAmE3EC8kcHH9TGUKPVJPunSqnocn+/qctApls+OBtgkTGIDQIE5zubmkmQvcDGzbCyODwroSy1Vx6BFu4db7xUwEn9O8Nk/1V/1UGhZqhFpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AkQAtpXoVipLX5EZ4Md5jGwUSMeF+HxQfNQkucO6/WA=; b=PP2Hoxfd9TzQWOlakvszC1lYYV2SImAOpCtv4XE8HO5pUEh7VK6wS/yQeAm821ThfSfgj1jek3vjLl/mKNKRDt4rKmq9yuzGQiNbuTBNB0Z9f/rex62MCpYEcV/iLsGvuduG72CUuwt87ERrdG24pcttRnJhxDgNrj7zEI5iT++UXvSCgXZOU4pfKrvBSlTfQcebAA3SKW9c+nsproph5KplvxBdB0oLGAi6OLYqi8+Gd45ha/Dl9Ld7AjBlsTKHfNrTXwmFqs0y659CUgXOkqhTGoDdHsBUxu2z1rjxidDRH9Q0nnJIXPmj1U9ccGiL0/rJHtjrDgW4/dSo9rp7pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AkQAtpXoVipLX5EZ4Md5jGwUSMeF+HxQfNQkucO6/WA=; b=w5jGzdnqDJTCgL1IJ7KQfpQZvNKgzBnEUyYJxVg6CHHKBE4nj3Q25z27UHV+e4fyoZBFEIid6BF36SXc9DClUFPhXdNVMOuAMcDedFbaEOKPQ//hVC5lE5Xnz8d5E/+A8HUNPifKznkunYZReo9/xjQ1qBlVgRARJ/RxJLi/aVo= Authentication-Results: mayadata.io; dkim=none (message not signed) header.d=none;mayadata.io; dmarc=none action=none header.from=intel.com; Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) by SN6PR11MB3104.namprd11.prod.outlook.com (2603:10b6:805:cc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Thu, 30 Sep 2021 22:13:45 +0000 Received: from SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e]) by SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e%7]) with mapi id 15.20.4566.014; Thu, 30 Sep 2021 22:13:45 +0000 From: "Menon, Ranjit" To: Dmitry Kozlyuk , CC: Dmitry Malloy , Narcisa Ana Maria Vasile , Pallavi Kadam , Tyler Retzlaff , Nick Connolly References: <20210501171837.13282-1-dmitry.kozliuk@gmail.com> <20210526210147.1287-1-dmitry.kozliuk@gmail.com> <20210526210147.1287-5-dmitry.kozliuk@gmail.com> <017c2682-4fd6-5fa3-08c3-3ad85d020560@intel.com> Message-ID: Date: Thu, 30 Sep 2021 15:13:41 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <017c2682-4fd6-5fa3-08c3-3ad85d020560@intel.com> Content-Language: en-US X-ClientProxiedBy: MW3PR05CA0003.namprd05.prod.outlook.com (2603:10b6:303:2b::8) To SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) MIME-Version: 1.0 Received: from [192.168.254.28] (50.39.109.205) by MW3PR05CA0003.namprd05.prod.outlook.com (2603:10b6:303:2b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.8 via Frontend Transport; Thu, 30 Sep 2021 22:13:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e79bd85e-00b9-4f87-d742-08d9845f9133 X-MS-TrafficTypeDiagnostic: SN6PR11MB3104: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w3TBeEJQZoxsE7D8+5CvAm8gYaA5iTNy6mFtAY3fFcAzx4TGSmzWGNTmGOLYkWIsvlUQ+POVcA6qNJ6ZXIss5JSHmDLm3m9BYI0Y8/KpK2a/Vel0t3PoHT6+ESfV4egmK5Z+g4GrzHC0AZClOZzfncnJEdGqb2OEcFERiy96Bq7FYr1SzoHl7Xl2vO/69Dq173rwvVYFyguUWG6Ir8RrOl5gYUJ5JjaRy9VqMvQFu8xOt4/um/sW2JqBKzy/4VNX4Njstc+OcBCbz6n4vypCFytZukNTBubeWSfQ1OU/ZzguZH9SS5Wj2Gm4GKDssYBju3kKKo0w0aF5RlKmq5RcqYIhGrSdBPwkaDOO5s3uzTTgzIDA8yHbFmbZnz17r0iirribSo4y1ZDD+bExVFGbzJd+xyfTZjHRrO+bf/fshleLV86fmQ80/COaeTr1+pasTJXdTww3O3PsDPCeE3tLUGWrIfmS9h6ntKkoDuMdZsDmnOdCWDv6r/owlDX4vWpDbWN5w5Df05SuLWIufvbPyBFe3EfqkxtSQWq/MHaz9PRCOqhM1t6Cqbb4HGLHEBacFTymeQz3YPMwTt5Pku1IalRxNRgYqTjI8FqoLXV+KDx3WEuVEKWU4Yi/BH2TLwT+HXLV4jFAM1NEWUAfRp70Q0qYn3gbt8zxQ5S20MjZPX5HRoXC+RYAVGT7P3JSFCGQAMuVkd/hIbkOCUCMvEz7b4vx4vdNMZFyFR96S7PSfW2smNcD6IcKuuqlyxBZ39a6OW44/B58VhVMzqzsNZ+73rRmWiWUJIv6HhpEGXkOJckWX82tJChArq6O4sn/o/7s673SxegpaZgOdrJl3cqLCA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31696002)(4326008)(66946007)(31686004)(66556008)(53546011)(26005)(83380400001)(38100700002)(2616005)(66476007)(956004)(8936002)(36756003)(33964004)(6486002)(186003)(2906002)(966005)(86362001)(508600001)(166002)(8676002)(16576012)(54906003)(5660300002)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHpJRTR6VXQ4K0crWDBnbnp1OGNqVk5TWFpmR1E0cUhBekU2UHFtclpraU1i?= =?utf-8?B?V1BOWXhOdUdlUGh1M3JGekxTVW1sU29oU2kraWFkRFJOMW0xSXNJekJRNnh5?= =?utf-8?B?NUtqV1BuUERwOGpOc292WXQ2M0E1T3VmWFJHenZyWXN6SzIvYS9zLy9rb2Fs?= =?utf-8?B?d0Nsb0Q3RGhoRnpLV1JvNzNoT2NvczhzOE8rRzBUZnpOVm9yajFoME5YNURE?= =?utf-8?B?U3huK0dSTjlXL283b3pDRkphQkF0QWhXWHpVQ2owR2I0WGpmMFRMWGRtSndk?= =?utf-8?B?K1JUMmRxRk1jYmgrNklrVGdBYkZZVHhYMGJYQzc5YmhCUFZxRGJ2SVhzYXVx?= =?utf-8?B?c0xjM3R1WHNYbGtNV09GVVlSVVZXc3dDNzRXZ1U4K3BsZk5iZjUvQTZqMlBW?= =?utf-8?B?OXdjNkJDZ0NjU0w1SEdjbkp5VVdHWFYwQzJuK2NaaFcySU9DQnMwaEVJM2RN?= =?utf-8?B?emFZNFkxSGJZTkFRVmlJam5SNVluQktEN1JEa1pmYWFkNTZ4aGh2NjlySklz?= =?utf-8?B?TjlnRkE1SGd4WDRqR0l2d09GbHorWEhMQk9tQ2F5c2hxdEFaK2gxdzBWNk1h?= =?utf-8?B?MlUwbGkzaXRDeVNTN1JiZ0JFeFg4bEdLSXJVRFJObHdUOW1xOTNTc0RaTzIz?= =?utf-8?B?UGFHcFdNdkRhT3hKM2Fha2FCa2xLWUt0L2x3VHlEMFhqaURsdHdTWjZ1K1pJ?= =?utf-8?B?V29zVkh5N3ZWT2tQczUvQXJiRERCbmljT1hhT09iemY4N29YRk54akVITSt1?= =?utf-8?B?anVURGQ1Zm5lU2dneWdxNnVyQ05SY0hmZlpBT1FvUmtDaUlRUktnQXhJbG1q?= =?utf-8?B?SjJLdHJuWTd5bFp5Zm81Z09TN1FYbE9RSlFDRVd6TEtXelFGb1oweEdxaUVR?= =?utf-8?B?T2JLQmd4ZHpTeUREU3FnNXRRY3g5d0t5MlJ2L2Q0bkVqTkI0a09wcyt6UUc1?= =?utf-8?B?VnJrRDMxVXp4VTlTWWlDMkZMeTVSQWM2cUhnZkJSZ0VrN1ViOGtEWkNrVkhw?= =?utf-8?B?ZXZHVzl5MUVSMldXNjhyNVhhK0tYcHorNDdqanpzRnhOUnhsdHcrYUl1aXQ0?= =?utf-8?B?aWVsMjlqdXoxVkNCOUZPQUdWR1NTN0pDbytwb05ncFcxV1NCOTlrUVFBSG84?= =?utf-8?B?SXhZU09yN2dsMVcvN0tOTy9uZ1Z0ODNML1lad0o2cVVUS1BKVTdReVBZZWNV?= =?utf-8?B?ZXpnNXc2WmZZNmI4bTlGa1JkL04xekhwNDlWN09BdFNRRzRUT2tOaFlVYjB2?= =?utf-8?B?RlNUWjJtbzFFVVdpOW9QSVZ0RjVsUjgxVEo5MFdSRzFBeXpOWnFJK0ZBSXJs?= =?utf-8?B?TkUyNmFvd1A3U2Y4L0xKWVNRS1BWYXh0NGFPN3NUdnBQVDg2U0lsOEM0bStX?= =?utf-8?B?a2o0Ulk3cjZ6c09rcVhKSGpWdkQvV1VOcGFBWXJFRGxRcGRsd2UrUTM4RjFz?= =?utf-8?B?a1RuVEpwenM2dGJSWWsybE9veHlTbm9zLzlES29oL2dzR0hhNVNwWXhyT0wx?= =?utf-8?B?eStaRXBSaGQ3ejY2eWphRjA3UzYvd2FKM2Jqdlk4TDVHSkhFYktMVVJiRWQz?= =?utf-8?B?Z05HU0hVa0hNbHlEcTQyR29FaFlXclJ6YzVnZjhQMzFNcVBnWmh6QThBcnI0?= =?utf-8?B?Q1NTUGF6WlZ2RlNaZVo3US9KMGRCT0E2dEF6TTV1OGNXU280ZHlGNTRvbU9j?= =?utf-8?B?bFFHUERabjc0TFZjTXZmQzgwcm9KeWVrK1pPSVU5amtkU1VUZ2Q3VEtmZWFm?= =?utf-8?Q?XRCwNJgxiYOVyejjC1jXQsso+Eg5LGm/ncU/7yd?= X-MS-Exchange-CrossTenant-Network-Message-Id: e79bd85e-00b9-4f87-d742-08d9845f9133 X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 22:13:44.5426 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mO5xrBr0UqnLkJYMVwMXU5oRcyoTUw9SdY9DbWxLDwEoiOAo0KlRkBkoP3FWUAv86VvVBE5uP+XlS+tedy3D1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3104 X-OriginatorOrg: intel.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Typo below: On 9/30/2021 3:07 PM, Menon, Ranjit wrote: > Hi Dmitry, > > On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: >> WPP tracing [1] allows kernel drivers to print logs that can be viewed >> without attaching a debugger to the running system. Traces are colelcted >> only when enabled. Instrument virt2phys with traces: >> * ERROR:   failures that prevent the driver from working. >> * WARNING: incorrect calls to the driver. >> * INFO:    starting or completing operations with memory. >> >> [1]: >> https://docs.microsoft.com/en-us/windows-hardware/drivers/devtest/wpp-software-tracing >> >> Signed-off-by: Dmitry Kozlyuk >> --- >> > diff --git a/windows/virt2phys/virt2phys.vcxproj > b/windows/virt2phys/virt2phys.vcxproj >> index b462493..c9f884a 100644 >> --- a/windows/virt2phys/virt2phys.vcxproj >> +++ b/windows/virt2phys/virt2phys.vcxproj >> @@ -41,6 +41,7 @@ >>     >>       >>       >> +    >>     >>     >>       >> @@ -169,9 +170,9 @@ >>     >>     > Condition="'$(Configuration)|$(Platform)'=='Debug|x64'"> >>       >> -      false >> +      true >> true >> -      > Condition="'%(ClCompile.ScanConfigurationData)' == >> ''">trace.h >> +      > Condition="'%(ClCompile.ScanConfigurationData)' == >> ''">virt2phys_trace.h > > This change is also required for the 'Release|x64' configuration, > otherwise 'Release' builds fail. > > > > Also, it appears the newer version of the compiler (combined with the > new version of WDK/SDK), requires that the driver signing process > mandate a File Digest Algorithm (using the /fd option). It is a > warning today, but they claim it could become a requirement in the > future. > > To fix this, we can include the following in the project file: > > >   SHA256 > > > Or set the above, using project 'Properties'->Driver Signing->File > Digest Algorithm = 256. Should be: "Or set the above, using project 'Properties'->Driver Signing->File Digest Algorithm = SHA256" > > (This will need to be fixed in the netuio driver project also) > > thanks, > > ranjit m. >