From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8E81B8DF0 for ; Wed, 25 Apr 2018 18:15:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 09:15:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,326,1520924400"; d="scan'208";a="223343141" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by fmsmga006.fm.intel.com with ESMTP; 25 Apr 2018 09:15:27 -0700 To: Adrien Mazarguil , dev@dpdk.org Cc: Jacek Siuda , Tomasz Duszynski , Dmitri Epshtein , Natalie Samsonov , Jianbo Liu References: <20180419100848.6178-1-adrien.mazarguil@6wind.com> <20180425151852.7676-1-adrien.mazarguil@6wind.com> <20180425151852.7676-11-adrien.mazarguil@6wind.com> <20180425161028.GT4957@6wind.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: Date: Wed, 25 Apr 2018 17:15:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180425161028.GT4957@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 10/16] ethdev: fix TPID handling in flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 16:15:31 -0000 On 4/25/2018 5:10 PM, Adrien Mazarguil wrote: > On Wed, Apr 25, 2018 at 05:27:56PM +0200, Adrien Mazarguil wrote: >> TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not >> consistent with the normal stacking order of pattern items, which is >> confusing to applications. >> >> Problem is that when followed by one of these layers, the EtherType field >> of the preceding layer keeps its "inner" definition, and the "outer" TPID >> is provided by the subsequent layer, the reverse of how a packet looks like >> on the wire: >> >> Wire: [ ETH TPID = A | VLAN EtherType = B | B DATA ] >> rte_flow: [ ETH EtherType = B | VLAN TPID = A | B DATA ] >> >> Worse, when QinQ is involved, the stacking order of VLAN layers is >> unspecified. It is unclear whether it should be reversed (innermost to >> outermost) as well given TPID applies to the previous layer: >> >> Wire: [ ETH TPID = A | VLAN TPID = B | VLAN EtherType = C | C DATA ] >> rte_flow 1: [ ETH EtherType = C | VLAN TPID = B | VLAN TPID = A | C DATA ] >> rte_flow 2: [ ETH EtherType = C | VLAN TPID = A | VLAN TPID = B | C DATA ] >> >> While specifying EtherType/TPID is hopefully rarely necessary, the stacking >> order in case of QinQ and the lack of documentation remain an issue. >> >> This patch replaces TPID in the VLAN pattern item with an inner >> EtherType/TPID as is usually done everywhere else (e.g. struct vlan_hdr), >> clarifies documentation and updates all relevant code. >> >> It breaks ABI compatibility for the following public functions: >> >> - rte_flow_copy() >> - rte_flow_create() >> - rte_flow_query() >> - rte_flow_validate() >> >> Summary of changes for PMDs that implement ETH, VLAN or E_TAG pattern >> items: >> >> - bnxt: EtherType matching is supported with and without VLAN, but TPID >> matching is not and triggers an error. >> >> - e1000: EtherType matching is only supported with the ETHERTYPE filter, >> which does not support VLAN matching, therefore no impact. >> >> - enic: same as bnxt. >> >> - i40e: same as bnxt with existing FDIR limitations on allowed EtherType >> values. The remaining filter types (VXLAN, NVGRE, QINQ) do not support >> EtherType matching. >> >> - ixgbe: same as e1000, with additional minor change to rely on the new >> E-Tag macro definition. >> >> - mlx4: EtherType/TPID matching is not supported, no impact. >> >> - mlx5: same as bnxt. >> >> - mvpp2: same as bnxt. >> >> - sfc: same as bnxt. >> >> - tap: same as bnxt. >> >> Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API") >> Fixes: 99e7003831c3 ("net/ixgbe: parse L2 tunnel filter") >> >> Signed-off-by: Adrien Mazarguil >> Acked-by: Andrew Rybchenko >> Cc: Ferruh Yigit >> Cc: Thomas Monjalon >> Cc: Wenzhuo Lu >> Cc: Jingjing Wu >> Cc: Ajit Khaparde >> Cc: Somnath Kotur >> Cc: John Daley >> Cc: Hyong Youb Kim >> Cc: Beilei Xing >> Cc: Qi Zhang >> Cc: Konstantin Ananyev >> Cc: Nelio Laranjeiro >> Cc: Yongseok Koh >> Cc: Tomasz Duszynski >> Cc: Dmitri Epshtein >> Cc: Natalie Samsonov >> Cc: Jianbo Liu >> Cc: Andrew Rybchenko >> Cc: Pascal Mazon >> >> --- >> >> v6 changes: >> >> - Reworded patch title as a "fix" (not candidate for backports) since it >> addresses a flaw in the original API definition. >> - Updated API and ABI changes sections in release notes. >> >> v3 changes: >> >> Updated mrvl to mvpp2. >> >> Moved unrelated default TCI mask update to separate patch. >> >> Fixed sfc according to Andrew's comments [1], which made so much sense that >> I standardized on the same behavior for all other PMDs: matching outer TPID >> is never supported when a VLAN pattern item is present. >> >> This is done because many devices accept several TPIDs but do not provide >> means to match a given one explicitly, it's all or nothing, and that makes >> the resulting flow rule inaccurate. >> >> [1] http://dpdk.org/ml/archives/dev/2018-April/095870.html > >> diff --git a/drivers/net/mvpp2/mrvl_flow.c b/drivers/net/mvpp2/mrvl_flow.c > >> + if (mask->inner_type) { >> + struct rte_flow_item_eth spec_eth = { >> + .type = spec->inner_type, >> + }; >> + struct rte_flow_item_eth mask_eth = { >> + .type = mask->inner_type, >> + }; >> + >> + RTE_LOG(WARNING, PMD, "inner eth type mask is ignored\n"); >> + ret = mrvl_parse_type(spec_eth, mask_eth, flow); > > Looks like there's a compilation issue left on the above line, which should > obviously read: > > ret = mrvl_parse_type(&spec_eth, &mask_eth, flow); > > Ferruh, can you update it while applying? > I'd hate to spam the world with v7 :) OK, will update while applying. > > Thanks. >