From: Paul Szczepanek <paul.szczepanek@arm.com>
To: Dean Marx <dmarx@iol.unh.edu>,
probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com,
yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com
Cc: nd@arm.com, dev@dpdk.org
Subject: Re: [PATCH v4] dts: reform hello world test suite
Date: Wed, 8 Jan 2025 09:07:18 +0000 [thread overview]
Message-ID: <c47a3e64-22ec-484a-a462-82e56e07da01@arm.com> (raw)
In-Reply-To: <20250107213434.31595-1-dmarx@iol.unh.edu>
On 07/01/2025 21:34, Dean Marx wrote:> + with
TestPmdShell(node=self.sut_node) as testpmd:
> + testpmd.start()
> + self._logger.log(1, "Hello World!")
You should not be using private members like _logger
you can use get_dts_logger to get the logger but honestly I think we
should not encourage tests to use the logger directly.
Maybe we should add a TestSuite class method to log.
prev parent reply other threads:[~2025-01-08 9:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 21:54 [PATCH v1 0/1] dts: add EAL sanity check suite Dean Marx
2024-12-09 21:54 ` [PATCH v1 1/1] " Dean Marx
2024-12-20 15:49 ` Paul Szczepanek
2024-12-20 16:21 ` Stephen Hemminger
2024-12-23 18:57 ` [PATCH v2 1/1] dts: add EAL confidence " Dean Marx
2024-12-23 18:50 ` Patrick Robb
2025-01-06 17:58 ` [PATCH v3] dts: reform hello world test suite Dean Marx
2025-01-07 16:37 ` Luca Vizzarro
2025-01-07 16:49 ` Patrick Robb
2025-01-07 21:34 ` [PATCH v4] " Dean Marx
2025-01-08 9:07 ` Paul Szczepanek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c47a3e64-22ec-484a-a462-82e56e07da01@arm.com \
--to=paul.szczepanek@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=nd@arm.com \
--cc=npratte@iol.unh.edu \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).