From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4E6242644; Tue, 26 Sep 2023 17:50:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6468840277; Tue, 26 Sep 2023 17:50:27 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7832640269 for ; Tue, 26 Sep 2023 17:50:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695743425; x=1727279425; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=RpaHieRkQ8V06RgVdqzJ/Ncv6gf2SJySByAh4FpdsRk=; b=iPYPzwtjvbzHjGQb5/SaLoNHwnMtymOu1yxR+pE8EYazsCX25048oFiy WmiPITtY2SPurcGhRtm0LBrpiVgGtN/yyHwCBASTbtB41GPvHPZpNVrkY VO2in66Vz5q+uzz4drZE0y5IGluBXTH+eipJhN16OU7zLhc7cBizHQj54 vJFsQsn+rXv2ABfUDNl1YPazPflM7+em/7AGLs4ydcCNopFvb8MYazhcX 0nUvB77d+AL217v6lV/heb57UwQBxnPkdjRGYEXwgbqu/qjQ/AD1fnbys BvmyTm2Ot7ZWDY7UUVcxc+ABu3dMvRjjLDnCO9WfkLoNvum5da6ct5pq5 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="371930786" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="371930786" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 08:50:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="864449006" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="864449006" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 08:50:24 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 08:50:23 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 08:50:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 08:50:22 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 08:50:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bHBe/tKU/SZl9VpAHifnAecS/XzbexYLgok5ta4yY+gF9wS7RRiWBWcanFLarKziDezQzrLqWpyFXle/sXekqofZgbbDDMqExHW9PTtXIZ2lVbAtS874V3yXcJtrpnREI3g7vOJRN4mEMwuv+tPzy1nf06Yaxpw+6bPjSytYjkkcZgYhdkd7+JDGBjjGgNCnF3JXjkPQKtwcGL9gnWiL6bXZP2u4FME/pXEJh79O+7rzpNGTUorApukoOIOzWm6CbNQzNVEj7k9lUoKxp71fRrVLqG8TiPLPHM8hkTWcBkdrKZxKGsSVhiB3n6XI/ydexgleC3AucEIoRkVqMJoYeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kXio0SBSJ/dUcjAUE/gUyFHyWpI4BkhqGgQ4FVQFWc8=; b=mK7zbKmbi3BrL3XQUCwO9Y7UeWKKZHAd6jm+LvHYB5rwuI8UhsHYAQwJ+irdvJpqycE5/9kdYTKLO2n5yoPJyDomMONURWZZ+oxFaQLSuO2H6rkVdzrwQh1njyWzfkZhxt+/3OrkfQgP93XokiYG4WP3mFyBoSpiTsrMrRaZP/H+D22t8fcL9/lEtmXZKmcppCSaSBT89XztVnaA9m+guHvNsO/bAsogQ+iGVIAZz3z27c7PrNeSYzQ5CbvvLkaWAs86GSRpsE/Y9zPL9zTZ1uU3HqiEe2GtSNd1aM1SoUq19TbJB6qAV0SHSuLdDPRMlvKCp1s6zWVlRgu4Ebch+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by SN7PR11MB7068.namprd11.prod.outlook.com (2603:10b6:806:29b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 15:50:18 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::aff0:6db1:520b:2b95]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::aff0:6db1:520b:2b95%4]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 15:50:18 +0000 Message-ID: Date: Tue, 26 Sep 2023 21:20:07 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] testpmd: unregister event callback To: , Yuying Zhang CC: References: <20230915042633.151750-1-okaya@kernel.org> Content-Language: en-US From: "Singh, Aman Deep" In-Reply-To: <20230915042633.151750-1-okaya@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN3PR01CA0015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:95::19) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|SN7PR11MB7068:EE_ X-MS-Office365-Filtering-Correlation-Id: f0a34b57-4716-41d0-069d-08dbbea84866 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mI1f33b+Ww9q2qF3NtdsO0//qF/y5OdVKhlil4t1zb/MybCWnQlDGLLH+zXPh8zCUqWMLhsjZxC/00p6AZFa4dsO7jirMmx42B4b3LLPRB9R/1heAS12XMt1ERIzJF92csqZAfMxtlof4anOLYQ/3RCrvMagKswgJoL1LbEAe7nyBGNMUn8xWt6QlIMZkeLXQEkzxOpkT8KV3NaiiqPNCr3OKrXeMRy+DQE1DlENDDWGZ2TnVffSvH9cS9jZgEZNXTYCg9gCJp6pbzbDqMpiKfINBE2sclmcvKaafyVpJeBEijQXcFarg/j03AkmR/4s6tO9U8jpNZzYrv639SKzrSpleZ+jbPoS4idAl9qLbn8Bb0J3izOzvxuwmIL9QdUZyTMi/q3wKJtNIIIrKe7RA6UDhVw86cTYjs2lyPgyOefMYh/bxPUodqUT9mZZHsTIfKCY2c33U3bta6t2w61+XZjIqWh0jgCgpR85/9gZN6IEZL4SAUkTfb2PDT2310rcIxgcATWnpI4s9YV/Vo+GZvS83a2+jIjquG3MWVWmuf703y+uZgHw3+jjTeH5PbnlMX5zcNPxPF4CuA8kma+FZtzUxWCgaQyG/h2kVaUNN5crWKi9KmWp2S2hrLvQ3S1z1kdTdm+RQEaOS9YIc+zh8w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(366004)(346002)(376002)(39860400002)(230922051799003)(1800799009)(186009)(451199024)(26005)(6666004)(6486002)(478600001)(2616005)(36756003)(86362001)(82960400001)(31696002)(5660300002)(83380400001)(38100700002)(6506007)(53546011)(6512007)(6862004)(2906002)(4326008)(8936002)(8676002)(31686004)(6636002)(37006003)(41300700001)(316002)(66946007)(66476007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUJJbE1hem9nbFpaVldESkFyNnBxQzJLV09xRmhTMkg3WDZOTkJDMGlDbU9m?= =?utf-8?B?aG1Md0d0TG5HRkR5TDl5K0c4WDV6ejFrOUF4bk9uOVJRZ2N6Q1psRmZEL1hi?= =?utf-8?B?dUJwL3d2V2s5YUJSOG5ZVUk2RXFaM0Z4Q3p1cjMrVWVuSUk2NW9QdjU5MXpJ?= =?utf-8?B?RDRyNTVaS05wMDUya0tGWkw0RVRBdHBrYzdMZDhQWXZzVjJXeGxBS2JEaS9T?= =?utf-8?B?RkEvNVpCamdSWWhZcGVCb1VDU3E1RjJZdGhlVmJkRE1URTNyTjZQRGhqaHB5?= =?utf-8?B?c0ZjUDJIZFJxejlYanhsT0pBeXA2am4xQU8wN1BsdzNvclJORXhPRVdLaFht?= =?utf-8?B?dnJmUzgvZ3Y3VStNTnpCMTQ0SzVRV2hIenJRNEJVY21LVVNYRXZzajRaWjJq?= =?utf-8?B?NEVkRmFvRzRrcGc3Mi90eDIvbTFZdDZxSFNEcTJUdlZKQzlaUW5Uemp5UnRO?= =?utf-8?B?V013djBZL3VNZ2R1YWpIZnBFTnFmRVJBMG9EcU0yU3JwWVJjTlZ5WVVNQWJt?= =?utf-8?B?QW5ibXNYNCtDYVM3UmRoZ1lsT1FGOE5hendlRWEreENkTTBTdm80TlkzT1Qz?= =?utf-8?B?Q0g2WXlmTXI5WEFXcVc2QnZpUzVEYkNzQXFqTHRPSTlnTXcxeFhYdEtmd3U1?= =?utf-8?B?NS9KUGdJRnQvRmhmSkZOcWNjcURETDVwOFI2NzF2KzNnbSs4ZXl5a3RBdVkw?= =?utf-8?B?amdRTVNVK0JacFBtOEN4dlF5ZFBjelFRMTRnMWNVYmFEN0VkY2J0OWNLcXFO?= =?utf-8?B?TmlLSStwS2pjTEVFeTBneDcrR1d5Mm56azRndURnSC9kc1ZsdTA0QWRaU20w?= =?utf-8?B?WDk1YmNHSzZabTZxcUZTTHBFVzFUczFPQTBMQ3NmSEVtUExORGJKemFjdGFZ?= =?utf-8?B?QkNWaDhYWEZRU2cvT3FDK01JaG5HOGRPMXRXczdwZnA1bEE1eEw0cUZlRjU1?= =?utf-8?B?V2ViNWVNbVhicHQyUjdoMjJldXI3R1A0d3FSK2lneUZ3QlpyUGJiQVZHNEMy?= =?utf-8?B?RzBpRjVjTWpHWUxRZ0FkYit6V1FlSzZQeis0VXltOTZJMVhORGlWRzI0OG81?= =?utf-8?B?cEpxMTJwRWtBUEhkbHFmbDVnNWJYYkZ3UjdwVG02TDNDaEtYR1dlYUJIS1Fa?= =?utf-8?B?dTEyY3Fscnk3K1o3ZkhZR1BieXRmS1hvbVBhek9iZlZqRTZiUUs5aW9pa1Q0?= =?utf-8?B?YlBWd21ZYUp4QXkyUGRDZ2xna282ejAwU1F2Vi96SGRaVEx6OW5TVTg5NFRE?= =?utf-8?B?TTlSQTlpTnZ3MHMxRzdNV29PMEQzcXZURndzUnVaa3NuK2pwcnl2RWwvdGRS?= =?utf-8?B?UWxVcHRhWHNyazFQYmNYS2YvUVZvYitBa3gwK0x5YzQ0R2szNWJCaUNQZ2xo?= =?utf-8?B?ck16OUE4TmEzc1pnMXJFS2MrMHBHdXlXYUUzOHpSQk55RlNIVERJNlp6ODRw?= =?utf-8?B?SnNRem9wMWtqUEw3RzExZ2dvbDg1UjJqU0dmR0lYVVhUNzB2R2pzeDd6MlVl?= =?utf-8?B?OFJmcjUvY0JVWEtHK21Rdnc1cHl6Y3dkSXpiYXhQMGd0S3djQUlFNS96MkUr?= =?utf-8?B?dU5GZ2FvQzVMY1JlUXBoZmhFT1NQbHphUERma1BpRUxNaFFNNGUzdVhxZ3lH?= =?utf-8?B?NG9EVXhld2xoVkdMdzBLdWZ0VHNuRjR1a1VZcGdkbFM5NnVzWGV2WjEvV2Va?= =?utf-8?B?MkZoa0FzWVJKRFpQVkN3V1l1VjJ5UzhseWthQmVEU1RYRnRmS2c3VVNuKzgr?= =?utf-8?B?YWlFQUJCQnVYRE5TbnZUWW5hcC92V2pBYllXZlBRVkNINDhCUnpsQkJFRWU2?= =?utf-8?B?ZDBIVDNtZUw3bTBLYU1qTEJiZjArN0dmTFp3TDNkR2hNTFFjb0RUY0VJa051?= =?utf-8?B?SGpKQURSd0tZQ25iVDRScFA3OW82aFRXZTNTWEtGTWY3U1VGVHhJd01EU3N2?= =?utf-8?B?bU9kQzBKbUU3TEJDMXdaL2krV0lXT2M5bmVxeFhxV0tXbG9KZVVheFlMdHBS?= =?utf-8?B?NitZK1B5Z2xVcUY3WDR1TjVXYysvS1FkOSsyUCtxblZPSjdUbTNQbXM3Q215?= =?utf-8?B?emhVVjNBRWxiVXVJamN6SGtEd1ltbWw4MXUxUXNtVFVTckZGMkZOcnB4WmJT?= =?utf-8?B?RHlNMHJtWEdOdm1uNW4ycm9MamNUbCszcEFxRE1rWENHSlBSeW5GaEJXU0I0?= =?utf-8?B?dGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: f0a34b57-4716-41d0-069d-08dbbea84866 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 15:50:18.6095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xvflBF+YI9ezFZsxuJMNf7sui9ddEsR97x+YFeGRXVFf4IXJkUw0fPTD7UKgqptM8vB0RAQ9rORgV9GKkL3WE9RwxSuH5/sb/8+int89Ci0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7068 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2023 9:56 AM, okaya@kernel.org wrote: > From: Sinan Kaya Header format doesn't requires to add "From: " as author "Signed-off" is already present. > > Cleanup event registry during shutdown to prevent memory > leaks. > > Signed-off-by: Sinan Kaya Acked-by: Aman Singh > --- > app/test-pmd/testpmd.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index c6ad9b18bf..1de7b7cd51 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -4009,6 +4009,28 @@ register_eth_event_callback(void) > return 0; > } > > +static int > +unregister_eth_event_callback(void) > +{ > + int ret; > + enum rte_eth_event_type event; > + > + for (event = RTE_ETH_EVENT_UNKNOWN; > + event < RTE_ETH_EVENT_MAX; event++) { > + ret = rte_eth_dev_callback_unregister(RTE_ETH_ALL, > + event, > + eth_event_callback, > + NULL); > + if (ret != 0) { > + TESTPMD_LOG(ERR, "Failed to unregister callback for " > + "%s event\n", eth_event_desc[event]); > + return -1; > + } > + } > + > + return 0; > +} > + > /* This function is used by the interrupt thread */ > static void > dev_event_callback(const char *device_name, enum rte_dev_event_type type, > @@ -4737,6 +4759,11 @@ main(int argc, char** argv) > rte_latencystats_uninit(); > #endif > > + ret = unregister_eth_event_callback(); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, "Cannot unregister for ethdev events"); > + > + > ret = rte_eal_cleanup(); > if (ret != 0) > rte_exit(EXIT_FAILURE,