From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBBF84297B; Tue, 18 Apr 2023 10:52:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 492D140EDF; Tue, 18 Apr 2023 10:52:59 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by mails.dpdk.org (Postfix) with ESMTP id 893E740698 for ; Tue, 18 Apr 2023 10:52:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfAXdSvQIg6m8AfMLkxVMJVKFwYlLGDs46njafZva2EU3W6nweSAT9zCY2aLFHbJXEZFw43LVemw+WHvh3NaNQTWaKdlZ1EX2DxaW4LV5K0mNRy4Rw3OnI6RI4vYaZ7hHEHPp+5Ds84xBvIVSwJHfaNCVSLtskMC74oW5WimrItwSUZrVz6lmxJI+93BlucaH4p0Q/hnat8t8qDtr53gVlM+b8Bzoku+BicIKcf/AV1P6Szt4tNdJzHil+Fw5YNddUa5gIwN1swkxg/SyeM5dyRvmSg5GOw4qY4uOwo2Q+rriNMBnnZQ05Z0AINpRbMZAIIxMSscTi4/RxsM7vqXow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7xL9t0byJgYW5DXpa/u4CKhRaML899c/6ws3H9nEug=; b=TaN2b1nYhTkx74pcL/PUNGuqZUHo+gRFS2PK+66CIjdPfUUznNCz1ABYMfh0w5wwyr4qaLl67jkNC0945bbMWc7qQaC54YaLS//eTpvQ/yeO6drNJrXXKy0HM4EcTMcJr9Md9IlLuE/DcgayAM0I2Z9Gg4O1cpIfv2uj3R361M4NjZR+umMaUU9zX54lq4lPag/i/mTpxSvC73IygMInRNzByQ3iFyxb9crorM+fQRY2vyySSuPiJb+KNOMArb4C5NQgNZ1//s/fkE0yFhsFWWEQY787lIttlri1GteTNszel+APeTeErJIL3wP3HLa7fCQHMbutt5GsaGmm0DNeBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7xL9t0byJgYW5DXpa/u4CKhRaML899c/6ws3H9nEug=; b=jvK9A+/brKKKw60lMvmvJbs9lPsVk0y91IRJ4woAVrXzmqTB67su9QLnmS5M6novw80Bg46yC8AsKkK4GCPYIEYd1/vJ0J+Zo8jrMXxoPYCsTITTsmjlbEoTPLlT995AftgpCsXINh8IuAXPQ78dk7jX+7PzoIYluIJYETXl/zk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB5450.namprd12.prod.outlook.com (2603:10b6:510:e8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Tue, 18 Apr 2023 08:52:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::5e2c:c0ed:88a6:a4c7%7]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 08:52:55 +0000 Message-ID: Date: Tue, 18 Apr 2023 09:52:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: Sivaprasad Tummala , david.hunt@intel.com Cc: dev@dpdk.org, david.marchand@redhat.com, Bruce Richardson , Thomas Monjalon References: <20230417043136.470110-1-sivaprasad.tummala@amd.com> <20230418082529.544777-1-sivaprasad.tummala@amd.com> <20230418082529.544777-2-sivaprasad.tummala@amd.com> From: Ferruh Yigit Subject: Re: [PATCH v4 1/4] doc: announce new cpu flag added to rte_cpu_flag_t In-Reply-To: <20230418082529.544777-2-sivaprasad.tummala@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0333.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::33) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB5450:EE_ X-MS-Office365-Filtering-Correlation-Id: 84182683-493b-40f4-9e59-08db3fea4d18 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5KsImxgNlD4j9EHDWjAgm0DvnM1H72g840WT0DbMgGd4jYtJI7VD05i6HVj8TyPhJw14GCsCR1gmW8s3xcrD+Xp6StvQb0sHOAwN4dyA9J1NrgfIvPxM1S83qi6EQJlaMB0VdjKYItUqUoYfWVnZIdA7gK8owg7VYcU8t1z9fxHK/GEyxy3+aCwyXxb5HpS8ZhipVIW9tiSZ66K0YZJd3mpE7kvjQOWo8PlwHS1Xrov4vEKWqLIpudSXk4fxnqMxYPlk8//Isg9roRWFcNbOAKLkdy+HlvsEDCS/ja6TI40qZv2BaE8mbFulLWxWr0BxnNDo+ys2iptsSHRRLiHu45ixxVlDjEixQ0d0pr6cY8IAXM0uVqa8RVyuKxyJomwM+5MsPBHksTPJH3BpNvyA2LjQPT9ywu4G/AePeIWzoO8QuUU49QwRgIxqBEICWqt5cQG5+IjJ4iuYRgbMw6nJmI3aypISFJEJIw3v8sKjItFaCz5V6hdiuzX/JDsT5rE/OT2yH2SXoAYPAN/W5pOcmLFkONX/Vh8UoBIjFWxKSc5ofejxPbCBwbgWZHIHyM0jJ0TPZdXXtstaqLO9Pm9mYMSjNJ79FeIFsnf5zTnXO/71RqEz4jQaVEmxllC4/QQR2MDlk/6o2NAWPQokmzyofA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199021)(36756003)(44832011)(2906002)(5660300002)(8936002)(8676002)(41300700001)(86362001)(31696002)(38100700002)(31686004)(478600001)(2616005)(26005)(6506007)(53546011)(6512007)(54906003)(186003)(6666004)(6486002)(4326008)(66476007)(66556008)(66946007)(83380400001)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0xNSzc1MUt1cmp3ZHh6MndEMkZPcDNMeitjQ09aOUZtMVJQd1hSY3hmNXkv?= =?utf-8?B?U3lkWUNvL3k3c0tqaE41RnRvSENoUytlR3JrNmVZbmI1cmdYSWJVTjFYRFdZ?= =?utf-8?B?S2czR3BNcU5TQ3BxWjdoVUh3NER5TnJGam54aE5XN25sMDN0c3hXWDhFc0ha?= =?utf-8?B?ZDBoY0R1eXRrVElMT1lSMXpkd0dadm5xa3hFTXMyZE5Hb1IxaFUybEdYM0Y3?= =?utf-8?B?dVZINGRCMjE2bHNwdmpLMmU2eEFhQkk3VjgyVEdrRHJvOHlib1AwVGNhWkh6?= =?utf-8?B?MW5uaEo1blV3VlhrSmh0bW4zU3V3enhQVi9zb1lUVnNRdDRqUldxZHc0c25M?= =?utf-8?B?cExQSU1HSGhVYVpjU2x5NEF4c1g2eFlIejEvSkNEOEhjUWM3ZHNpYnowVmdo?= =?utf-8?B?b1cwTm9Bb0VUeXF6dVo4YlQyZGN3bnZNMEdOZjJTcWNReHdpOWNBaGcyZktI?= =?utf-8?B?Mk0rTUpsc01GUVVTYWRtblBZTkU3ekhqWkZGcWFvRVcyLzNlNVgyNnVwZjRQ?= =?utf-8?B?QUtBQzBCZ29sZVpJcHJwQnU1UXhlaytOTXllMnhCVXBteFdmUmpxWGd3R3ZN?= =?utf-8?B?Sm1ra3dMMFVEMHFJSGwwVDB1NExJaEVUYlZGd0pFdFlFNVkzbWN5WGhIdUxa?= =?utf-8?B?MC9yUTZOTEFQdE91QmZXYjFyUFZnMmpyZy9PQ0VpeDVibDFublU5a2w0My83?= =?utf-8?B?YVFJNVpYeEFTNTJWdTZYSll0TzI1S085U0dKMXZnYWJzRWFKbkxIb0p1VkNL?= =?utf-8?B?Um5MekdrbXl5aUp0MWwyRlVoTnliZ1RDWGRJNFM1YVBJY3pHOUhnMVgrcWw2?= =?utf-8?B?ZGY2TCtzbU85WTNkSHdSWExTcUpKL05PMnlTOVNiTFRYK1k5akwrelVqT3Zh?= =?utf-8?B?Y2NCYkxTbm5uaWc2TEMzY3E4ZG1TRGtEQk14L0hjMzZpbUVjSkk4bUErcmZw?= =?utf-8?B?VTZTNExtWlJWT2JaanNrQ0JleU1GYXpkSmF3YkNqSU1FNVpGc2lWMUtaNlll?= =?utf-8?B?LytTdVFzaVNMZm1XQ0owbkVPNlVqQzRsempHOWFxelZrb05hM0NseWhFREVj?= =?utf-8?B?QWNIY2VOZ3RtVXRoSnJpN1BPRFFJM1BhNVV2K1dUclFPWm9JeExxb3lON00y?= =?utf-8?B?ZU42eWMvT1l1b1BVMzFVZ2YrMjllKzFhUHdZZzdxUHFaeE5QTXhWN2NvNDhL?= =?utf-8?B?bSsrRzFhajBVT2t0QlJ6dmtTdlNwSVdhUnpuRThCQ1U4T1hxYjh4a3l0cWlF?= =?utf-8?B?Z24wRW9ndTlZS0ZDc3ErYzNmYjlpMmZnY1h6VlVWSm5DY1RySTdOQXRqQTBN?= =?utf-8?B?YnZGOU9EZXlkT3VHdG90U0FxaHhMUWFWeW5JanIvMGpBaGdkS3pCMCtnamZY?= =?utf-8?B?c2VtV05TN096VnJhL01GcDQ0T1oxaGlRZDltNkpnTVZqMktGU2tZVlpZdjRs?= =?utf-8?B?NTdLYVRVbTdXSVRFTEtCVnlERkN2dW9MZ0J1Q2J1SGNrOTZVOWxkYWRnZlRI?= =?utf-8?B?TEVyNUdEWk52czZFbmczU0lBVmlZVGk1eFpTZUEydmc3ZkNKM0w3RUJiM0dp?= =?utf-8?B?NTJpRlpCMXkrbU9xOEFVU3YySGl2MHVJc0UwWkQ4UHdsT3hBTFFFUy91VG81?= =?utf-8?B?NzZVZ0NEWU54K2J2dEhXeWRQYU4rVDRtRzJPdWJBL3l2MG9ubUg2blRweTJD?= =?utf-8?B?YnVyN3lLL2hqV0ZxdjcwVEJNdk1MRTlRTU9zRTNsbzdoWDFORUdjKzlvRzN6?= =?utf-8?B?WjRlR2pUSExBMlpqWDROQ3QvYlNBVWY2S2tSV0pMbTY4WjIydk42TUxuQWh1?= =?utf-8?B?cVpuRFFKcGRZWC9nVXRtQ0JmN3hYc0dNMXM1VDBqWFhFckU2MFN3UzFWWVhD?= =?utf-8?B?MVVpQTVYZTl0YS93WnV6bnJ1M1Q5dXRXVDF0bm9GNG1FbXBBMUpTZjVldytL?= =?utf-8?B?VnBONzFYcnlEWnN2WkZKWEdBS2liR0RLMlJmNE1zTFdIWWcxUkFXZFhDSVcw?= =?utf-8?B?M2FSNjRDRU8wSjNjcjJhL3gwZzgyRW1ycHVld3ZiOFo4bGhrbVFJWC96dk1S?= =?utf-8?B?VWVTNExlMVVkelR4NEljbWx6bEFHZm5iWVh4US9wdWlWWVBEQ09qbXpqWm40?= =?utf-8?Q?TAWygSW14PicRT7uqMLFR7a3Z?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84182683-493b-40f4-9e59-08db3fea4d18 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2023 08:52:55.3931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LQQAlQYCYzQwbk8585SnaHAtO8PZkNBicxjuKFt8/QqIiB6MvmkwcC2ZSX1M39sj X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5450 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: > A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in > DPDK 23.07 release to support monitorx instruction on EPYC processors. > This results in ABI breakage for legacy apps. > > Signed-off-by: Sivaprasad Tummala > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index dcc1ca1696..831713983f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -163,3 +163,6 @@ Deprecation Notices > The new port library API (functions rte_swx_port_*) > will gradually transition from experimental to stable status > starting with DPDK 23.07 release. > + > +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new cpu flag > + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC processors. OK to add new CPU flag, Acked-by: Ferruh Yigit But @David, @Bruce, is it OK to break ABI whenever a new CPU flag is added, should we hide CPU flags better? Or other option can be drop the 'RTE_CPUFLAG_NUMFLAGS' and allow appending new flags to the end although this may lead enum become more messy by time.