From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D889A0542; Thu, 10 Nov 2022 15:20:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A30A840150; Thu, 10 Nov 2022 15:20:27 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2081.outbound.protection.outlook.com [40.107.223.81]) by mails.dpdk.org (Postfix) with ESMTP id 57792400EF for ; Thu, 10 Nov 2022 15:20:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYkegUGSZ+jqPp1OxLIMvegLMSZWwYb7HW4RZrIph29QF8UD3IZWgCDA4FgLF10R7Ytjz0DIfz7UI2sC6+2TyPRrX3JisH5njYKR6cY0D67rGrHFkG3KcAo0Uj7m8I3kX/CZdQWgOxCuA44tNPZRvzkw1Hg4skKpYD7tmRmFtRXA+Mdxzb4JX+JsQK+8WXKJUFc4U2zas97uPOBXw7shGRsCRkYzw1MdPAYvtJyKgtIGFAsoH6Ty/5Nc84bGJNuSILHhrttkFbAuhwMn83xSp2CrQOsqAB9gYbs6tSZezSz6HqhLthgmTh1NyRpPSXYR9WoXZ16VgUgw6A2c052DKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s57UY6QFW8EWUEe1r4bxYhwx4yvPNtVhIjoqcrn0S18=; b=Uz8Al4EnLR3DdE9IA6Rb2/FUqZ73TelfSPwchUv2IRUTnGiKPuZCAms6hWZDSFulFxet9D66/WpsGNSdEzAAwJeUyTFcEX/k1kYMDv3SfrLiPWdVprecmv8u/WTQHp56GGtfCfT08+zIjW4MGgryQM4q2q94hJmRUHTWH28z4ZWlXyssv619xYofiviL+Tcwlk80HTtyKrOg9D9BxNeeaw3VjvYg0c+lIdwB++gVG4V8IIRMR5w3w9lJmfgpIBncKexS9J+/AsQ8APQaFRpiSQ1Y5h9fHs1fBXH8wGWQ72zwbPSTduC9qnkq5Ivq2J4foYIZ58if17/ctgJcUIooYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s57UY6QFW8EWUEe1r4bxYhwx4yvPNtVhIjoqcrn0S18=; b=03wG5IHjnCmlp2nQl+RmOQ+5+aen4pSQW/RrPKVe4fCOAAVlwwj0R+/qoxdtaFQ2x3yNl5fmVZdTq36NJhHCDjbHURl+IjcJwGjTViLZbgAzxPZM+L6FYm3uVmPXiW254SYSre0h2zCNYfzTKJzI0NhM0Hc7njetPRmT1m1H5gI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by DM6PR12MB4880.namprd12.prod.outlook.com (2603:10b6:5:1bc::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Thu, 10 Nov 2022 14:20:24 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%8]) with mapi id 15.20.5791.027; Thu, 10 Nov 2022 14:20:24 +0000 Message-ID: Date: Thu, 10 Nov 2022 14:20:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues To: Huzaifa Rahman , Andrew Rybchenko Cc: Joyce Kong , "jgrajcia@cisco.com" , "dev@dpdk.org" References: <20220726101628.2118564-1-huzaifa.rahman@emumba.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0021.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::14) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|DM6PR12MB4880:EE_ X-MS-Office365-Filtering-Correlation-Id: 29e8491e-45ef-4c6b-e4a9-08dac326b520 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kQROKOJnC0E8Y9lPtRANtEuHVu4EvbjOu9oj5XbKwkA222EsoRIzAnL2Ke2UWVVRlPX95p7a9REDu5DMB1RWXhgkZO3vtYF9Rgo7pwMtw/Pzm1Oag8j4clxRTs/FWkC3Febq1CZ9MvbUy2AgEneeBm0hUKTzs2RLVGhwbYwifg7qb1P1zHPeIKf7wrrYyRJYZMOStlp5iZs9/Bh8DhBNctIxEXikxRnvIqJFiPCFMJMKyf+XQps+6PsTXQwXeNib2y5DwY1kId6v0CfzpJiEMvYFBW06bP1FDeRR/MzHZhbXI6UgdLDamH3D+GpIb3Jnevhu5UDVlB0jZm9gpkcc3I3E5qJPcBJYpT7hEoWQ+u46YRmRFGhbxZ4Ay7twbYfhbnoVyD4eMMBqaCp396dpiUNrDZhlE/2fVZJH95V6Xdw0V54BGfkg6XYWTju1A6wjm5LdKDGAQIp+SpVamjc9EX1gKmaM1szS4hedzsCfnBglygYFD0BI6QxmmFRk9mz4vIx+AkOvZqO8mENLfTmcF+fzvxbuxqbDfmRF8piZv+belsDnm5J4tHMRs+VWz9gXEGIOBA3yKGu/cT09NRSpbCGpRmPUVXOCIpsB/Hw/yXVTws2cBzf1iw9Tg6yUY8F+ngMandxPmuD04wJ++2VbNjzb4s4aktDfjhuv7x950iIGiZWjNg1NUuBuQ+CU4qbiC7cUrKf1G9nfdYQJMBvtU0XXpkGjJAR+XuHkyejgaCAI1P/x6lz7Vc8Kmd9+/IKs+83YnziqNkC6etEl90j06oAILDeo6PhjyTsIvFqUXT5yDRRr2JkjrKomqtNFfGTQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(376002)(39860400002)(396003)(346002)(136003)(451199015)(54906003)(110136005)(478600001)(316002)(6512007)(66476007)(36756003)(26005)(66556008)(8676002)(66946007)(4326008)(8936002)(41300700001)(2616005)(44832011)(53546011)(6506007)(5660300002)(186003)(83380400001)(31686004)(86362001)(38100700002)(966005)(31696002)(6666004)(6486002)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHNQaE93L09LUnhKM3hjY0VnK2s3THlURDI0RFJja0N0Qys5ZjFleHcreTlx?= =?utf-8?B?NFVPWUpIZEhiaEE3eXBwZ0kxVWRSeUlna1RSUGE0ZTh5L0Y3cVU0MHpRMFZV?= =?utf-8?B?WVkrWG1hclhNb1poSWR5MURjNW05b3VuRlVRem9MaXp1YmEzNnc4M1F3Kzl6?= =?utf-8?B?VVQ2dmVKcTdCZ09BbTJRRkRoNGU1b1lWVUIyY1hZTENBVDZlb3lJVEZOVlFm?= =?utf-8?B?d0hFNlhsclp2TjFoWlFaSHZ5eW9PUjRNWFNZcmlnNE5TWUE5MnZnN090L1lu?= =?utf-8?B?L0YwOGZ6c2dWVmxTOTVCQ01RYVBjaFE0Wm52cXBSSVZ2MFp2bkNnWGQrZFV3?= =?utf-8?B?WVJBUGRlV25tcnpBeTNURGMwOUk4MFF4bHRLeGlJU3dVSG96aXI0dTdYbitU?= =?utf-8?B?aDF0cHRlWlppclpmNkhnRTR1N3JQNjRiUCtyaS80eGJNTVdGRk1rTmZ0SVY2?= =?utf-8?B?Ui9heHNDSzE1ajlPM21teTlCNWZhSzYwUDd6K25Mb1VDbEFlVUp5VU5wS3Rr?= =?utf-8?B?dnozT01PRzBuQnFUZ3JJSDJ5R0FVamF6Q29hUVlLRXV0M3g2dlVmN29wVllB?= =?utf-8?B?ZDdad1NPMVN0T3ZYU3RNRDduTlc1ZlFFNTJEcHcyUjlqcWdJUHJ2a2JOeTNQ?= =?utf-8?B?UGFsTVZjVElYOFIyRXA5U0NsYXNtbnVNVmxRVzY5cFFobUxkK2lrNC80UGVn?= =?utf-8?B?MUlMT0VEaTJQS1F1NlpMYVVxdzd3RmJEeXFkZEpRRlVRdElwVnpxVndtcE9s?= =?utf-8?B?TEVNQ1VaWTNDbjYwdnZpVFVQaXZFRU9ka2VSVlN4VUUxQ2RweUs5cVU4Rmlr?= =?utf-8?B?S3RXcmJLYXo1bTM4cmJCOHJVK1dPMFdOTUw4a1lyMEpMN0d3ZFljZEwzM2xK?= =?utf-8?B?aUVBVnVLVnkzQXZ6eFROSTNFdm95NFUvd0l3c3FwdHpzaWNlanZXdGNiNjc1?= =?utf-8?B?ZlBvZjJOTFVzdGZlVWRzR0hZb3FnV2tBN1JxQzhQN285RVFoWlVpeDJjYjhu?= =?utf-8?B?Z05YUVJhYkRieWF2bVFnMVM0Tno5ZnN2Znp0OFNVU3N4dkVENFpINkJCVTdC?= =?utf-8?B?dWRnNUM1anV2ZVZhZUVqbktJZk04bUhSOGkxQmhKZDY4V0I5ZHUxVzJSeFlh?= =?utf-8?B?VEpZOWxaQWg3WGFpMXhXQW1xYXAvTnppOEE1OGRqRTFUSnEvZS9XMDcrWW12?= =?utf-8?B?Z0NOVXlUZEFpWVFUblZ3UHBLWVhweVJsaUVpZnZ5MitzZitDRWk2cnpTdWNW?= =?utf-8?B?ZFR4eFdwOWZYSGUydy8vRmhvMzA1SUduWlFPcDdmMXZrQU9ocjZ4UnZNdDJu?= =?utf-8?B?TW5rSmgxcHdHc1BKK0p6Wk5LTmx2M3FsWU9BNTh2Vi9SSy9XMXF0MmhZcWdu?= =?utf-8?B?N1NLUEVHb2crVWRZSU5zZEhnbGFFRlR2b252RENzUVVyNnJXOWVSblN3Mldi?= =?utf-8?B?UUFJR0IxOG5yV2NxazBicXRWMkJkbGlod0xXVDdHdkg1UFJ5dVRCSmVZeDJ2?= =?utf-8?B?NjRuYXR0NEZGclBuTWg5M29GZDRZR3o1MnVyNXdKQzVIWmI3dmM1STRTUStP?= =?utf-8?B?VGVxdzZtUVNTbG5tUXBZMEZjTzlEeG1zMDllL1ZXaWlYMWpxanhqc1ZXOEVn?= =?utf-8?B?OW8xMEhmb3RsdldjYUtGcG9oRjV6bjBJL3UvWjJ1eUFGaWpQSEhrY3JZNjhm?= =?utf-8?B?WTV3WUhaR3JPcXJ2V0hXcS9NeEJjTURxUlNEL1NkYWlxamY2WTdvN3ZVTUFq?= =?utf-8?B?ZU90MnhkT3A1NWFKV1BCM3dBNXpLNElEbzlzZE1pNlV4MlZJT3pjZzdiYW5k?= =?utf-8?B?bkRqL05yeFMrZnVCbzhQbVRxU1RLdjZQN0RpQVJRMzBKYnQ3S0R6OGR2UTdz?= =?utf-8?B?SjBoQk5kTkcxdWJkeVI5V2dTMU9ZQmtjN3hJZWdRQW5CaE9HdU14WVR0RGNu?= =?utf-8?B?UTZva01Jdi9JVmdqbEZhemdkcE5Dbk83bThGdGp1R1dyT2Q5UEJFeFdIU3Iz?= =?utf-8?B?c3FCUnE4L1FhOEVLd3FPUFV2VFBJNXpQVEs4MktjVXA5dFFSbERScHRmd1ZB?= =?utf-8?B?UkxDVHZRbXBHYVlFTTVHYUlSb2tISDR0b2JZQWVBTHhucENML3BNSFlNeTIw?= =?utf-8?Q?gs3mxPhFhEeyD7s4Nvt115UlP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29e8491e-45ef-4c6b-e4a9-08dac326b520 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2022 14:20:24.4020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0OnlpaunNBascPcEW+WRVdrrRRhY8rKnfrHTlIXFF0BgbJB2Xpim8TKegLlaz4Tq X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4880 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2022 10:02 AM, Huzaifa Rahman wrote: > Hi, > > Is there any other work/changes required for this patch to be submitted? > Hi Huzaifa, Patch seems already merged by Andrew and pulled to main repo: https://git.dpdk.org/dpdk/commit/?id=231435a5e6c7fa915697d8f84a91b44176 So it will in oncoming 22.11 release. > Thanks > > > On Tue, Oct 4, 2022 at 7:53 PM Andrew Rybchenko > > > wrote: > > On 8/8/22 13:39, Joyce Kong wrote: > > Hi Huzaifa, > > > > This patch looks good to me. > > And would you please help review my memif patches? > > > https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@arm.com/ > > > > Thanks, > > Joyce > > > >> -----Original Message----- > >> From: huzaifa.rahman > > >> Sent: Tuesday, July 26, 2022 6:16 PM > >> To: jgrajcia@cisco.com > >> Cc: dev@dpdk.org ; huzaifa.rahman > > > >> Subject: [PATCH] memif: memif driver does not crashes when there's > >> different N of TX and RX queues > > net/memif: fix memif crash with different Tx Rx queues > > > >> > >> Bugzilla ID: 734 > >> > >> there's a bug in memif_stats_get() function due to confusion > between C2S > >> (client->server) and S2C (server->client) rings, causing a crash > if there's a > >> different number of RX and TX queues. > >> > >> this is fixed by selectiing the correct rings for RX and TX i.e > for RX, S2C rings > >> are selected and for TX, C2S rings are selected. > >> > > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") > > Cc: stable@dpdk.org > > > >> Signed-off-by: huzaifa.rahman > > > Reviewed-by: Joyce Kong > > > Fixed above on applying. > > Applied to dpdk-next-net/main, thanks. > >