From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E1DAA0546; Fri, 19 Feb 2021 19:50:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3DD216096C; Fri, 19 Feb 2021 19:50:17 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 86C1C160937 for ; Fri, 19 Feb 2021 19:50:15 +0100 (CET) IronPort-SDR: Q2v4PhbPwJmDJI7wldvHesI6ZkfUOVdV/PlmQudyUmkCytmD2yqS0LKSZmw3s7zY2GfXHjyoG9 xxdTym+WJYjQ== X-IronPort-AV: E=McAfee;i="6000,8403,9900"; a="163082058" X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="163082058" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 10:50:13 -0800 IronPort-SDR: GiMr3CgsVNxA05kxB5sjje49fTFGwviGCcr1F13VvOv+HvEeAF6i13zNP6UMv28/lfsm+C8RjR CiHVr8cOQf4w== X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="387101321" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.55]) ([10.213.251.55]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 10:50:11 -0800 To: Kathleen Capella , Wenzhuo Lu , Xiaoyun Li , Bernard Iremonger Cc: Honnappa Nagarahalli , "thomas@monjalon.net" , nd , "dev@dpdk.org" References: <20210209154026.30984-1-kathleen.capella@arm.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 19 Feb 2021 18:50:08 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/19/2021 5:25 PM, Kathleen Capella wrote: > The iol-testing warning on this patch seems to be unrelated to the patch. > Yep, it looks unrelated, spdk build is failing, I tried to trigger build again, please check after some time if status changes. > On February 9, 2021 10:40 AM, Kathleen Capella wrote >> The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream >> structure. Deleting helps improve code readability. > >> Signed-off-by: Kathleen Capella >> Reviewed-by: Honnappa Nagarahalli >> Acked-by: Thomas Monjalon >> --- >> app/test-pmd/testpmd.h | 1 - >> 1 file changed, 1 deletion(-) > >> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5f2316210..f805f1b4d 100644 >> --- a/app/test-pmd/testpmd.h >> +++ b/app/test-pmd/testpmd.h >> @@ -247,7 +247,6 @@ struct fwd_lcore { >> streamid_t stream_idx; /**< index of 1st stream in "fwd_streams" */ >> streamid_t stream_nb; /**< number of streams in "fwd_streams" */ >> lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */ >> - queueid_t tx_queue; /**< TX queue to send forwarded packets */ >> volatile char stopped; /**< stop forwarding when set */ >> }; > >> -- >> 2.17.1 >