From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 017F67CC7 for ; Mon, 31 Jul 2017 18:12:42 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2017 09:12:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,442,1498546800"; d="scan'208";a="113951423" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga004.jf.intel.com with ESMTP; 31 Jul 2017 09:12:40 -0700 To: Yongseok Koh , adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com Cc: dev@dpdk.org References: <20170720154835.13571-1-yskoh@mellanox.com> From: Ferruh Yigit Message-ID: Date: Mon, 31 Jul 2017 17:12:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170720154835.13571-1-yskoh@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: poll completion queue once per a call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 16:12:43 -0000 On 7/20/2017 4:48 PM, Yongseok Koh wrote: > mlx5_tx_complete() polls completion queue multiple times until it > encounters an invalid entry. As Tx completions are suppressed by > MLX5_TX_COMP_THRESH, it is waste of cycles to expect multiple completions > in a poll. And freeing too many buffers in a call can cause high jitter. > This patch improves throughput a little. > > Signed-off-by: Yongseok Koh > Acked-by: Nelio Laranjeiro Reviewed-by: Sagi Grimberg Applied to dpdk-next-net/master, thanks.