From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AC1C3A0A0C;
	Wed,  4 Aug 2021 14:10:33 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2763D4014F;
	Wed,  4 Aug 2021 14:10:33 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 67C254003E
 for <dev@dpdk.org>; Wed,  4 Aug 2021 14:10:31 +0200 (CEST)
Received: from [192.168.100.116] (unknown [37.139.99.76])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 22DB07F500;
 Wed,  4 Aug 2021 15:10:29 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 22DB07F500
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1628079029;
 bh=GSDOWJoCUdM4GnRTe+BYxR7ah+yNfjOJyh6li/OSGXE=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=gwA6LU5yuP3JRWRtqthGaoIl3qCRqDXAYj3jX0RcGJBzh5mkHhhRvrlXMQ2yLa4dx
 yBAxHQt+3WP8iJeuztkQU1odWQUyeuEQadoSL+zSQ7TUboOiwQhfzWl2wKJvZRruS4
 5Arqj1h8IWd6zbdujfHU4dIG7wCx0E6IXjyYnANo=
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, Ori Kam <orika@nvidia.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, Ray Kinsella <mdr@ashroe.eu>,
 dpdk-dev <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@nvidia.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Matan Azrad <matan@nvidia.com>,
 Raslan Darawsheh <rasland@nvidia.com>, Akhil Goyal <gakhil@marvell.com>
References: <20210802141004.353754-1-matan@nvidia.com>
 <20210803085754.643180-1-orika@nvidia.com>
 <CACZ4nhtqiWh1ccToU2H+=5wuB-Af0Hms8iNPGgeWmvOxehFHEA@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <c503b377-8630-5e87-b630-89e689010a67@oktetlabs.ru>
Date: Wed, 4 Aug 2021 15:10:28 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <CACZ4nhtqiWh1ccToU2H+=5wuB-Af0Hms8iNPGgeWmvOxehFHEA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action
 modify data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/3/21 9:10 PM, Ajit Khaparde wrote:
> On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
>>
>> In the current implementation,
>> the action rte_flow_action_modify_field is not well defined
>> for fields larger than 64 bits (for example IPv6 source)
>> In addition, the byte order is also not well defined.
>>
>> Both of those issue should be fixed.
>>
>> Signed-off-by: Ori Kam <orika@nvidia.com>
>> Acked-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>