DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>,
	Rasesh Mody <rmody@marvell.com>,
	Jerin Jacob <jerinjacobk@gmail.com>,
	dpdk stable <stable@dpdk.org>
Cc: dpdk-dev <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] net/bnx2x: add support for secondary process
Date: Wed, 15 Jan 2020 12:47:38 +0000	[thread overview]
Message-ID: <c50f16a9-77bc-6d02-e061-bbd0917880fe@intel.com> (raw)
In-Reply-To: <907f9f62-f492-3fbf-22cb-d1fc654037b7@redhat.com>

On 1/15/2020 10:58 AM, Kevin Traynor wrote:
> On 14/01/2020 19:51, Rasesh Mody wrote:
>> Hi Kevin,
>>
>>> From: Kevin Traynor <ktraynor@redhat.com>
>>> Sent: Tuesday, January 14, 2020 10:52 AM
>>>
>>> On 14/01/2020 04:51, Jerin Jacob wrote:
>>>> On Sat, Dec 21, 2019 at 7:12 AM Rasesh Mody <rmody@marvell.com>
>>> wrote:
>>>>>
>>>>> Skip the device re-initialization for secondary process.
>>>>>
>>>>> Cc: stable@dpdk.com
>>>>
>>>> Correct Cc: to stable@dpdk.org
>>>>
>>>
>>> Is it a fix, or secondary process was not intended to be supported previously?
>>> If it is a fix, please provide the Fixed commit (will save Ferruh searching for it).
>>
>> Secondary process was not intended to be supported previously. So it is ok to not backport the change to all ongoing stable releases.
> 
> Thanks for confirming.
> 
>> However, the change has been tested with DPDK 19.11, I am wondering if it can be pulled in that stable tree.
> 
> Cc Luca
> 
>> Please see below the fixline tag.
>>
>> Fixes: 540a211084a7 ("bnx2x: driver core")
>>
> 
> Fixes tag won't be needed now as you've confirmed the code was doing
> what it was intending to do.

Since there is a request to backport this into 19.11, I was planning to add the
fixes tag (stable tag is already there) but will it confuse the 18.11 because
the commit in fixes line is older than 18.11?

> 
>> Thanks!
>> -Rasesh
>>>
>>>> Applied to dpdk-next-net-mrvl/master. Thanks
>>>>
>>>>
>>>>> Signed-off-by: Rasesh Mody <rmody@marvell.com>
>>>>
>>>>> ---
>>>>>  drivers/net/bnx2x/bnx2x_ethdev.c | 5 +++++
>>>>>  1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c
>>>>> b/drivers/net/bnx2x/bnx2x_ethdev.c
>>>>> index 20b045ff87..7864b5b80a 100644
>>>>> --- a/drivers/net/bnx2x/bnx2x_ethdev.c
>>>>> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c
>>>>> @@ -598,6 +598,11 @@ bnx2x_common_dev_init(struct rte_eth_dev
>>>>> *eth_dev, int is_vf)
>>>>>
>>>>>         eth_dev->dev_ops = is_vf ? &bnx2xvf_eth_dev_ops :
>>>>> &bnx2x_eth_dev_ops;
>>>>>
>>>>> +       if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
>>>>> +               PMD_DRV_LOG(ERR, sc, "Skipping device init from secondary
>>> process");
>>>>> +               return 0;
>>>>> +       }
>>>>> +
>>>>>         rte_eth_copy_pci_info(eth_dev, pci_dev);
>>>>>
>>>>>         sc->pcie_bus    = pci_dev->addr.bus;
>>>>> --
>>>>> 2.18.0
>>>>>
>>>>
>>
>>
> 


  reply	other threads:[~2020-01-15 12:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21  1:41 [dpdk-dev] " Rasesh Mody
2020-01-14  4:51 ` Jerin Jacob
2020-01-14 18:51   ` Kevin Traynor
2020-01-14 19:51     ` [dpdk-dev] [EXT] " Rasesh Mody
2020-01-15 10:58       ` Kevin Traynor
2020-01-15 12:47         ` Ferruh Yigit [this message]
2020-01-15 12:57           ` Kevin Traynor
2020-01-15 13:11             ` Ferruh Yigit
2020-01-15 14:02               ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c50f16a9-77bc-6d02-e061-bbd0917880fe@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=GR-Everest-DPDK-Dev@marvell.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=ktraynor@redhat.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).