From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <arybchenko@solarflare.com>
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E7DFD2BD3
for <dev@dpdk.org>; Tue, 2 Oct 2018 11:45:07 +0200 (CEST)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id
2718BB00055; Tue, 2 Oct 2018 09:45:06 +0000 (UTC)
Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com
(10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 2 Oct 2018
10:44:57 +0100
To: Ferruh Yigit <ferruh.yigit@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>, Bernard Iremonger
<bernard.iremonger@intel.com>, John McNamara <john.mcnamara@intel.com>,
"Marko Kovacevic" <marko.kovacevic@intel.com>, Beilei Xing
<beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Olivier Matz
<olivier.matz@6wind.com>
CC: <dev@dpdk.org>, Hyong Youb Kim <hyonkim@cisco.com>, John Daley
<johndale@cisco.com>
References: <20181002101759.10395-1-ferruh.yigit@intel.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <c51146a4-2a8e-ca06-be3f-ccb0197073f9@solarflare.com>
Date: Tue, 2 Oct 2018 12:44:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20181002101759.10395-1-ferruh.yigit@intel.com>
Content-Language: en-GB
X-Originating-IP: [91.220.146.112]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24130.003
X-TM-AS-Result: No-14.378300-8.000000-10
X-TMASE-MatchedRID: hls5oAVArl8OwH4pD14DsPHkpkyUphL9YQXxsZnRwoLK99fyOVK2z8Xp
bYD07gYfKj876iIVrFG8kPq/hbp/3s3f9xf5QhHOH5YQyOg71ZZMkOX0UoduuRS1r4tCARkwP+d
inJjuBkshEeMpOLPsQOLnuPsjYgioNtywwIf5ksX0hv/rD7WVZHzIY7d2+Tz9AnW+Tu2Fi4ZR18
QpzXStTi9BUTTI4YWlioFl5UK3cJ/SduMc6RnI+T5bo3ZLMFMHyouSanPChTR4jy7i2qNcvXlED
b1OO87oNTcc+FGtHL3/voIzhn8wZuVHGbcDbAq6OX/V8P8ail1ZDL1gLmoa/PoA9r2LThYYvJqH
1oJhQIf1tEivK1/1ZAp3rhW+yli9U2oPwhgWcz4lE+V551mNKmPDdA9ov8oipbNMtFVgGvcPYAH
q9UUTDk9A6aPwG8wF3+QLlp26fto=
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--14.378300-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24130.003
X-MDID: 1538473507-cJLea6coYuEP
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] mbuf: clarify QINQ flag usage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 09:45:08 -0000
On 10/2/18 1:17 PM, Ferruh Yigit wrote:
> Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags
> set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN
> should be also set.
>
> Clarify mbuf documentations that when PKT_RX_QINQ set PKT_RX_VLAN also
> should be set.
>
> So that appllication can rely on PKT_RX_QINQ flag to access both
> mbuf.vlan_tci & mbuf.vlan_tci_outer
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Hyong Youb Kim <hyonkim@cisco.com>
> Cc: John Daley <johndale@cisco.com>
> ---
> app/test-pmd/rxonly.c | 2 +-
> doc/guides/nics/features.rst | 7 ++++---
> drivers/net/i40e/i40e_rxtx.c | 3 ++-
> lib/librte_mbuf/rte_mbuf.c | 1 +
> lib/librte_mbuf/rte_mbuf.h | 5 +++--
> 5 files changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c
> index a93d80612..08a5fc2cf 100644
> --- a/app/test-pmd/rxonly.c
> +++ b/app/test-pmd/rxonly.c
> @@ -132,7 +132,7 @@ pkt_burst_receive(struct fwd_stream *fs)
> printf(" - timestamp %"PRIu64" ", mb->timestamp);
> if (ol_flags & PKT_RX_VLAN_STRIPPED)
It looks like it should be PKT_RX_VLAN above.
> printf(" - VLAN tci=0x%x", mb->vlan_tci);
> - if (ol_flags & PKT_RX_QINQ_STRIPPED)
> + if (ol_flags & PKT_RX_QINQ)
> printf(" - QinQ VLAN tci=0x%x, VLAN tci outer=0x%x",
> mb->vlan_tci, mb->vlan_tci_outer);
The first one duplicates above printout, so it should be either put before
PKT_RX_VLAN check and do PKT_RX_VLAN in else branch, or simply removed
from here.
<...>