Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

[Luca Boccassi <bluca@debian.org>]

On Wed, 2020-11-11 at 15:03 +0000, Luca Boccassi wrote:
> On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote:
> > 29/10/2020 23:55, Dmitry Kozlyuk:
> > > MSBuild XML files have to use CRLF line-endings, otherwise any change
> > > results in the whole file being rewritten with CRLF line-endings by
> > > Visual Studio. However, it's inconvenient to have such files checked-out
> > > with CLRF in Unix environments.
> > > 
> > > Add suggested git configuration to top-level README, so that Unix
> > > developers don't miss it. Remove .gitattributes, because core.autocrlf
> > > overrides eol= attribute. Convert line-endings of the existing files in
> > > the repository.
> > 
> > It is converted to what?
> > You mean all files should have LF endings in the repo?
> > 
> > [...]
> > >  windows/virt2phys/virt2phys.sln     |  54 ++--
> > >  windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++--------------
> > >  4 files changed, 259 insertions(+), 258 deletions(-)
> > 
> > The file windows/virt2phys/virt2phys.vcxproj.filters is not converted.
> > And I see other stuff to fix, see below.
> > 
> > > +Some Windows files use have to use CRLF line-endings.
> > 
> > "use have to use" -> "have to use" ?
> > 
> > Isn't it automatic to have CRLF on Windows git working tree?
> > 
> > > +Unix developers can configure git to get only LF on checkout:
> > > +
> > > +    git config core.autocrlf input
> > 
> > Isn't it the default?
> > If all files have LF, there is nothing to do on Unix.
> > 
> > 
> > I think more fixes are required as below:
> 
> <..>
> 
> Yes, I second that - those changes are needed too.

To clarify, having some options that convert after the fact
(clone/checkout) is _not_ a solution - everything needs to be checked
in with LF endings only, otherwise automated infrastructure (where
setting random configs it's just not an option) will break.

-- 
Kind regards,
Luca Boccassi