From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5549AA00E6 for ; Wed, 7 Aug 2019 21:36:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7719A29D2; Wed, 7 Aug 2019 21:36:53 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2D10E29CB for ; Wed, 7 Aug 2019 21:36:52 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 6664A4C0061; Wed, 7 Aug 2019 19:36:50 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 7 Aug 2019 20:36:38 +0100 To: , , , , , , , Neil Horman , "John McNamara" , Marko Kovacevic CC: References: <20190807160927.1197-1-pbhagavatula@marvell.com> From: Andrew Rybchenko Message-ID: Date: Wed, 7 Aug 2019 22:36:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190807160927.1197-1-pbhagavatula@marvell.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24828.000 X-TM-AS-Result: No-6.721900-8.000000-10 X-TMASE-MatchedRID: WMT2WRIkHPPmLzc6AOD8DfHkpkyUphL9NV9S7O+u3KYP75yVmSHRgHHU HCqTYbHtdBHR4O4Kth3y+XFrW3XvQGJZXQNDzktSFGkv4i1aAuZYMtqMzbYRNgQsw9A3PIlLnVt gvxMdrIONDKdr6SwtmEdKNtOe4os5JEAoYs6qcRywWQIt5658217OZ6hrwwnzx6C6dcifNxjgcJ c1hBF7dr/vRYSSG/Zz3I7Tw2vJzRx7rjItHwarhS8s/ULwMh468A6q6O7uVrUPyJBNuE5b61t7c j3cfjaDyg6kqq/YldMN5sID7a5qKC7VJbT1Ye1WGJADAbBHGUy8xE2H2EuMWYfKPDzrg/L+0f/K dYeMxZ2ae1BEXTzaKLfhL1mA+RaMOWTlId8Di5dlHA4/etJ+r2AW2j9VWc0luSti1BoHqPZS5RH xvhDyE94HHBYJtjIue/6aYxCz7bJNfs8n85Te8oMbH85DUZXyseWplitmp0j6C0ePs7A07bxtFR 53UcYCrspYbhze3HBCyvJFNs4mn9RwwhRPqdGhByajeK7xAECgQXfVCzv/EJT1Z4EG2ai+QDUd2 U3nxAyx7A2apwryFBg045Ph9IxNUdNvZjjOj9C63BPMcrcQuXeYWV2RaAfD+kkf6HhPsBc= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.721900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24828.000 X-MDID: 1565206611-ThL4oNss7q_L Subject: Re: [dpdk-dev] [patch] doc: announce API change in ethdev offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/7/19 7:09 PM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh > > Add new offload flags ``DEV_RX_OFFLOAD_PTYPE``, ``DEV_RX_OFFLOAD_RSS`` > and ``DEV_RX_OFFLOAD_FLOW_MARK``. > > Signed-off-by: Pavan Nikhilesh > --- > doc/guides/rel_notes/deprecation.rst | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 37b8592b6..a10f69e98 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -78,3 +78,12 @@ Deprecation Notices > to set new power environment if power environment was already initialized. > In this case the function will return -1 unless the environment is unset first > (using ``rte_power_unset_env``). Other function usage scenarios will not change. > + > +* ethdev: New offload flags ``DEV_RX_OFFLOAD_PTYPE``, ``DEV_RX_OFFLOAD_RSS`` I'd name it DEV_RX_OFFLOAD_RSS_HASH > + and ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11. > + This will allow application to enable or disable PMDs from updating > + ``rte_mbuf`` fields ``rte_mbuf::packet_type``, ``rte_mbuf::hash::rss`` and > + ``rte_mbuf::hash::fdir`` respectively. > + In 19.11 PMDs will still update the fields even when the offloads are not > + enabled. This is done as an optimization to avoid writes to ``rte_mbuf`` fields, > + the exact semantics of the flags will be worked out later. Acked-by: Andrew Rybchenko since I was going to propose something similar. However, there is a problem with all three, since they are efficiently enabled by default now and it is a proposal to change it. As Stephen pointed it out it is bad from application point of view since it is invisible (no API breakage, compilation is still OK), so it is hard for application to notice it. It should be discussed if it is acceptable or should be addressed in a different way (negative offloads? not ideal as well). I think that situation with tso_segsz for LRO, discussed in a separate thread [1], is very similar in fact. No problem with compilation, but semantics change. [1] https://patches.dpdk.org/patch/57493/