From: "Kinsella, Ray" <mdr@ashroe.eu>
To: Akhil Goyal <gakhil@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
"sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>,
Anoob Joseph <anoobj@marvell.com>,
"matan@nvidia.com" <matan@nvidia.com>,
"roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
"g.singh@nxp.com" <g.singh@nxp.com>,
"erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
"jay.jayatheerthan@intel.com" <jay.jayatheerthan@intel.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
Shijith Thotton <sthotton@marvell.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure
Date: Tue, 4 May 2021 10:36:34 +0100 [thread overview]
Message-ID: <c55625bd-267f-509b-47cd-82fa0087455f@ashroe.eu> (raw)
In-Reply-To: <MW2PR18MB22842FEC3EBEC5683EDBE31BD85B9@MW2PR18MB2284.namprd18.prod.outlook.com>
On 03/05/2021 12:18, Akhil Goyal wrote:
> Hi Ray,
>>> @@ -127,6 +127,10 @@ Deprecation Notices
>>> values to the function ``rte_event_eth_rx_adapter_queue_add`` using
>>> the structure ``rte_event_eth_rx_adapter_queue_add``.
>>>
>>> +* eventdev: The function pointer ``ca_enqueue`` in structure
>> ``rte_eventdev``
>>> + will be moved after ``txa_enqueue`` so that all enqueue/dequeue
>>> + function pointers are adjacent to each other.
>>> +
>>> * sched: To allow more traffic classes, flexible mapping of pipe queues to
>>> traffic classes, and subport level configuration of pipes and queues
>>> changes will be made to macros, data structures and API functions
>> defined
>>>
>>
>> I admire the disipline - but since you are not actually removing ca_enqueue,
>> just moving it in memory when the new ABI is declared in anycase, this is not
>> required.
>>
>
> Does it mean we can move elements in a structure without giving deprecation notice?
>
well if memory serves - you aren't depreciating the field, just moving it, right?
And you are aligning the change with an ABI break in anycase - so I think it is all good.
Ray K
next prev parent reply other threads:[~2021-05-04 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 9:08 [dpdk-dev] " gakhil
2021-04-18 9:11 ` Jerin Jacob
2021-04-23 10:53 ` Kinsella, Ray
2021-05-03 11:18 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-05-04 9:36 ` Kinsella, Ray [this message]
2021-05-07 9:17 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c55625bd-267f-509b-47cd-82fa0087455f@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=matan@nvidia.com \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sthotton@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).