From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEB8CA0562; Tue, 4 May 2021 11:36:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2330406A2; Tue, 4 May 2021 11:36:46 +0200 (CEST) Received: from mail-108-mta237.mxroute.com (mail-108-mta237.mxroute.com [136.175.108.237]) by mails.dpdk.org (Postfix) with ESMTP id 03305406A2 for ; Tue, 4 May 2021 11:36:44 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta237.mxroute.com (ZoneMTA) with ESMTPSA id 17936bc95c80004964.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 04 May 2021 09:36:39 +0000 X-Zone-Loop: 000907ecba23ea048f89b86442963f2143423798d835 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vXs+jPNobgnDBi3vIx2sXDTb8ugGQ8LVKvvTVRbU0FE=; b=SyvmLxPQLQyN62vIRQZeC5jRpI viKuaRa6uK4R1Jcrl8EZHbd5SA75fmIqyy+9ARmnGo4Uxr6RuLo6x0jwJGKs6R/fdr9BF28qbjDFm NjNd/vQpn1YMBaQV+m4Ilr4YCUAw0FSZn6oyfnXV7dGP96rMjtAl1afXa5ZLL6ieaOOt9gFR+/0w0 Cc2SczrNRiS91NkA6SbQ+mbWujcpCM5AcB91LKdne9GLQj1WHSL6IphqdkrQlgJLGM8RrgimJUcRj 6DA+sJ+e2ZXs/ZVuzarFpg7SKzEf4MOZMqY8LdP+AB6bcSVIsdtIolN8X4d13Dfge7jmrs4EgWaCi P+cgzIrQ==; To: Akhil Goyal , Jerin Jacob Kollanukkaran , "thomas@monjalon.net" , "dev@dpdk.org" , "david.marchand@redhat.com" Cc: "abhinandan.gujjar@intel.com" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "sachin.saxena@oss.nxp.com" , Anoob Joseph , "matan@nvidia.com" , "roy.fan.zhang@intel.com" , "g.singh@nxp.com" , "erik.g.carrillo@intel.com" , "jay.jayatheerthan@intel.com" , Pavan Nikhilesh Bhagavatula , "harry.van.haaren@intel.com" , Shijith Thotton References: <20210415090859.1319171-1-gakhil@marvell.com> <347ace77-7704-5ac4-7dd9-0cabe88dfce0@ashroe.eu> From: "Kinsella, Ray" Message-ID: Date: Tue, 4 May 2021 10:36:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/05/2021 12:18, Akhil Goyal wrote: > Hi Ray, >>> @@ -127,6 +127,10 @@ Deprecation Notices >>> values to the function ``rte_event_eth_rx_adapter_queue_add`` using >>> the structure ``rte_event_eth_rx_adapter_queue_add``. >>> >>> +* eventdev: The function pointer ``ca_enqueue`` in structure >> ``rte_eventdev`` >>> + will be moved after ``txa_enqueue`` so that all enqueue/dequeue >>> + function pointers are adjacent to each other. >>> + >>> * sched: To allow more traffic classes, flexible mapping of pipe queues to >>> traffic classes, and subport level configuration of pipes and queues >>> changes will be made to macros, data structures and API functions >> defined >>> >> >> I admire the disipline - but since you are not actually removing ca_enqueue, >> just moving it in memory when the new ABI is declared in anycase, this is not >> required. >> > > Does it mean we can move elements in a structure without giving deprecation notice? > well if memory serves - you aren't depreciating the field, just moving it, right? And you are aligning the change with an ABI break in anycase - so I think it is all good. Ray K