From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90E4EA04A2; Tue, 5 Nov 2019 16:12:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 563EE1BF45; Tue, 5 Nov 2019 16:12:13 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id CE96D1BF45 for ; Tue, 5 Nov 2019 16:12:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 07:12:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,271,1569308400"; d="scan'208";a="205005467" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.96]) ([10.237.221.96]) by orsmga003.jf.intel.com with ESMTP; 05 Nov 2019 07:12:08 -0800 To: Slava Ovsiienko , "Damjan Marion (damarion)" Cc: "Liu, Yu Y" , "Wang, Haiyue" , Thomas Monjalon , "dev@dpdk.org" , "arybchenko@solarflare.com" , "jerinjacobk@gmail.com" , "Ye, Xiaolong" , Ray Kinsella , "Sun, Chenmin" References: <20191031171139.105110-1-haiyue.wang@intel.com> <20191031171139.105110-3-haiyue.wang@intel.com> <20693558.VL3dRorq05@xps> <56850BFA-ABD1-476D-9ED0-F599EBD6D1EE@cisco.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Tue, 5 Nov 2019 15:12:07 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2019 7:50 AM, Slava Ovsiienko wrote: > > >> -----Original Message----- >> From: Damjan Marion (damarion) >> Sent: Saturday, November 2, 2019 21:21 >> To: Slava Ovsiienko >> Cc: Liu, Yu Y ; Wang, Haiyue ; >> Thomas Monjalon ; dev@dpdk.org; >> arybchenko@solarflare.com; Yigit, Ferruh ; >> jerinjacobk@gmail.com; Ye, Xiaolong ; Ray Kinsella >> ; Sun, Chenmin >> Subject: Re: [PATCH v1 3/3] ethdev: enhance the API for getting burst mode >> information >> >> >> >>> On 2 Nov 2019, at 09:38, Slava Ovsiienko >> wrote: >>> >>> Hi >>>> -----Original Message----- >>>> From: Liu, Yu Y >>>> Sent: Saturday, November 2, 2019 8:56 >>>> To: Wang, Haiyue ; Thomas Monjalon >>>> >>>> Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh >>>> ; jerinjacobk@gmail.com; Ye, Xiaolong >>>> ; Kinsella, Ray ; Sun, >>>> Chenmin ; Slava Ovsiienko >>>> ; Damjan Marion (damarion) >>>> ; Liu, Yu Y >>>> Subject: RE: [PATCH v1 3/3] ethdev: enhance the API for getting burst >>>> mode information >>>> >>>> Add Damjan from FD.io for awareness... >>>> >>>> Hi Thomas, >>>> >>>> Long time no see. Sorry I use outlook which is not friendly to >>>> community email. >>>> >>>>> Anyway I will propose to replace this API in the next release. >>>> Will your plan be affected by API/ABI stable plan? >>>> BTW, if you propose new change in next release, it will make DPDK >>>> consumer(FD.io) to change again. >>>> So even if it is not affected to the API/ABI stable plan, do we still >>>> have time to get a solution for everyone in DPDK 19.11 with your >>>> contribution/acceleration? >>>> >>>>> I suspect a real hidden issue in Intel CPUs that you try to mitigate. >>>> Please be rest assured it is not the case. >>>> This request is just from one FD.io project internal bug " tx/rx >>>> burst function is shown as nil" reported by Chenmin. >>> >>> Why just the presenting string with function name (possible with suffix) is >> not enough? >>> I would like to see this API (strings approach) in mlx5 either, >>> dropping the entire feature does not look nice, as for me. >>> >>> We could consider some requirements for the name suffices to >>> distinguish whether function uses vector instructions and which ones if any. >>> >>>> My understanding is DPDK behavior was taken as bug for someone in >>>> FD.io project and potentially will mislead other DPDK consumer. >>> >>> Why does FD.io code want to know which vector extension is used by burst >> routines? >>> Is it going to share/preserve some resources (registers, etc.)? Is it robust ? >>> Burst routines might not know whether vector extensions is used (they >>> might call libraries, even rte_memcpy() can use vectors in implicit fashion). >> >> This is jut debug CLI print, it was added by me as a result of frustration of >> dealing constantly with operational issues where people are reporting lower >> performance caused by DPDK deciding for variety of reasons to switch from >> vector PMD to scalar one. > > And it seems there is no need for flags, as for me. > I think the simple string would be quite enough to identify the datapath routine. > Also, we have exact the same issue with mlx5 PMD, so the API (in simple > string version) is desirable (+1 from me). > Hi Thomas, Slava, It has been discussed in the previous mail thread [1], there was no objection to it and Haiyue seems send the version based on it. For me having the flag still makes sense, because: 1) It helps standardizing the provided string. 2) Helps to the application to consume the provided data via API (not text) The idea was PMD sets the flag for the know standard features, provides the text for the non standard part. The APIs converts the flag to the string and append to text so it will be complete for the app if just wants to log it. Flags still has the standard part for the application what to use it. Initially standard part was just vectorization but it can be extended by time as more common data path used by PMDs. Text part is always free text. After above said, I think the API has been already discussed more than enough, and Haiyue already sent an all string version, OK to go with it. [1] http://inbox.dpdk.org/dev/a6893929-f981-4701-7cce-52b5e8ec934e@intel.com/ > With best regards, Slava > >>> >>>> Haiyue is working with Chenmin to address the issue and with your >>>> support it will be even better. >>>> >>>> Your support will be highly appreciated! >>>> >>>> Thanks & Regards, >>>> Yu Liu >>>> >>>> -----Original Message----- >>>> From: dev On Behalf Of Wang, Haiyue >>>> Sent: Saturday, November 2, 2019 1:30 PM >>>> To: Thomas Monjalon >>>> Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh >>>> ; jerinjacobk@gmail.com; Ye, Xiaolong >>>> ; Kinsella, Ray ; Sun, >>>> Chenmin ; Slava Ovsiienko >>>> >>>> Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for >>>> getting burst mode information >>>> >>>>> -----Original Message----- >>>>> From: Thomas Monjalon >>>>> Sent: Saturday, November 2, 2019 06:46 >>>>> To: Wang, Haiyue >>>>> Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh >>>>> ; jerinjacobk@gmail.com; Ye, Xiaolong >>>>> ; Kinsella, Ray ; >>>>> Sun, Chenmin ; Slava Ovsiienko >>>>> >>>>> Subject: Re: [PATCH v1 3/3] ethdev: enhance the API for getting >>>>> burst mode information >>>>> >>>>> Thank you for trying to address comments done late. >>>>> >>>>> 31/10/2019 18:11, Haiyue Wang: >>>>>> --- a/lib/librte_ethdev/rte_ethdev.h >>>>>> +++ b/lib/librte_ethdev/rte_ethdev.h >>>> >>>> >>>>>> +#define RTE_ETH_BURST_ALTIVEC (1ULL << 2) >>>>>> +#define RTE_ETH_BURST_NEON (1ULL << 3) >>>>>> +#define RTE_ETH_BURST_SSE (1ULL << 4) >>>>>> +#define RTE_ETH_BURST_AVX2 (1ULL << 5) >>>>>> +#define RTE_ETH_BURST_AVX512 (1ULL << 6) >>>>> >>>>> Of course, I still believe that giving a special treatment to vector >>>>> instructions is wrong. >>>>> You did not justify why it needs to be defined in bits instead of >>>>> string. I am not asking again because anyway you don't really reply. >>>>> I think you are executing an order you received and I don't want to >>>>> blame you more. >>>>> I suspect a real hidden issue in Intel CPUs that you try to mitigate. >>>>> No need to reply to this comment. >>>>> Anyway I will propose to replace this API in the next release. >>>> >>>> Never mind, if this design is truly ugly, drop it all now. I also >>>> prefer to do the best, that's why open source is amazing, thanks! ;-) >>> >