From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D9B4D23D; Wed, 25 Jul 2018 10:53:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 01:53:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,400,1526367600"; d="scan'208";a="60514783" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.82]) ([10.237.221.82]) by orsmga006.jf.intel.com with ESMTP; 25 Jul 2018 01:53:01 -0700 To: Chas Williams <3chas3@gmail.com> Cc: dev@dpdk.org, Declan Doherty , Chas Williams , stable@dpdk.org References: <1532080957-26940-1-git-send-email-radu.nicolau@intel.com> From: Radu Nicolau Message-ID: Date: Wed, 25 Jul 2018 09:53:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] net/bonding: set started flag at the end of dev start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 08:53:04 -0000 On 7/24/2018 3:34 PM, Chas Williams wrote: > I think this adds another race.  In > bond_ethdev_slave_link_status_change_monitor(), it checks to see if > bonding is started, if not it exits.  So you need to have dev_started > = 1 set before you enable this callback. > Indeed, I will have another look at this. Thanks for reviewing! Can you also have a look at this one? https://patches.dpdk.org/patch/43187/ I think I addressed all your previous feedback.