From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Shani Peretz <shperetz@nvidia.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <stable@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>
Subject: Re: [PATCH] eal: fix DMA mask validation inconsistency in IOVA VA
Date: Tue, 9 Sep 2025 12:17:40 +0200 [thread overview]
Message-ID: <c5a7ce8d-2bd4-47c1-b246-f87c8c1d33b1@intel.com> (raw)
In-Reply-To: <20250908163456.420268-1-shperetz@nvidia.com>
On 9/8/2025 6:34 PM, Shani Peretz wrote:
> When --iova-mode is explicitly specified in command line, DMA mask
> constraints were not being validated, leading to potential runtime
> failures when device DMA capabilities are exceeded.
>
> The issue occurred because rte_bus_get_iommu_class() was only called
> during IOVA mode auto-detection, but this function has the important
> side effect of triggering DMA mask detection (e.g., Intel IOMMU
> address width checking via pci_device_iommu_support_va()).
>
> This created an inconsistency, when choosing explicit mode,
> the DMA checks are bypassed, but when choosing auto-detection mode,
> the constraints are checked and enforced.
>
> The fix moves rte_bus_get_iommu_class() outside the conditional logic
> to ensure it's always called during EAL initialization.
>
> Fixes: 4374ebc24bc1 ("malloc: modify error message for DMA mask check")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shani Peretz <shperetz@nvidia.com>
> ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
prev parent reply other threads:[~2025-09-09 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 16:34 Shani Peretz
2025-09-09 10:17 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a7ce8d-2bd4-47c1-b246-f87c8c1d33b1@intel.com \
--to=anatoly.burakov@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
--cc=shperetz@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).